* [PATCH] arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name
@ 2022-03-24 22:33 Stephen Boyd
2022-03-24 22:35 ` Doug Anderson
2022-03-25 0:10 ` Matthias Kaehlcke
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2022-03-24 22:33 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: linux-kernel, linux-arm-msm, Douglas Anderson, Matthias Kaehlcke
This node should be named sar1-irq-odl, not sar0-irq-odl. Otherwise
we'll overwrite the settings for sar0 with what is intended for sar1,
leading to probe failures for sar1 that are quite confusing.
Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1")
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 7c22f0b062be..4d91909af325 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -741,7 +741,7 @@ sar0_irq_odl: sar0-irq-odl {
bias-pull-up;
};
- sar1_irq_odl: sar0-irq-odl {
+ sar1_irq_odl: sar1-irq-odl {
pins = "gpio140";
function = "gpio";
bias-pull-up;
base-commit: 116f7cc43d28ccd621ff1fecc9526c65dde28dcd
--
https://chromeos.dev
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name
2022-03-24 22:33 [PATCH] arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name Stephen Boyd
@ 2022-03-24 22:35 ` Doug Anderson
2022-03-25 0:10 ` Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2022-03-24 22:35 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, LKML, linux-arm-msm, Matthias Kaehlcke
Hi,
On Thu, Mar 24, 2022 at 3:33 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> This node should be named sar1-irq-odl, not sar0-irq-odl. Otherwise
> we'll overwrite the settings for sar0 with what is intended for sar1,
> leading to probe failures for sar1 that are quite confusing.
>
> Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1")
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Oops! Thanks!
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name
2022-03-24 22:33 [PATCH] arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name Stephen Boyd
2022-03-24 22:35 ` Doug Anderson
@ 2022-03-25 0:10 ` Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2022-03-25 0:10 UTC (permalink / raw)
To: Stephen Boyd
Cc: Andy Gross, Bjorn Andersson, linux-kernel, linux-arm-msm,
Douglas Anderson
On Thu, Mar 24, 2022 at 03:33:31PM -0700, Stephen Boyd wrote:
> This node should be named sar1-irq-odl, not sar0-irq-odl. Otherwise
> we'll overwrite the settings for sar0 with what is intended for sar1,
> leading to probe failures for sar1 that are quite confusing.
>
> Fixes: 116f7cc43d28 ("arm64: dts: qcom: sc7280: Add herobrine-r1")
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-25 0:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 22:33 [PATCH] arm64: dts: qcom: sc7280: Fix sar1_irq_odl node name Stephen Boyd
2022-03-24 22:35 ` Doug Anderson
2022-03-25 0:10 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).