linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach
@ 2022-04-29  5:51 cgel.zte
  2022-04-29 16:21 ` Doug Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: cgel.zte @ 2022-04-29  5:51 UTC (permalink / raw)
  To: dianders
  Cc: andrzej.hajda, narmstrong, dri-devel, linux-kernel, Minghao Chi,
	Zeal Robot

From: Minghao Chi <chi.minghao@zte.com.cn>

Simplify the return expression.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/gpu/drm/bridge/parade-ps8640.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
index edb939b14c04..e2467e58b5b7 100644
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
@@ -542,7 +542,6 @@ static int ps8640_bridge_host_attach(struct device *dev, struct ps8640 *ps_bridg
 	struct device_node *in_ep, *dsi_node;
 	struct mipi_dsi_device *dsi;
 	struct mipi_dsi_host *host;
-	int ret;
 	const struct mipi_dsi_device_info info = { .type = "ps8640",
 						   .channel = 0,
 						   .node = NULL,
@@ -577,11 +576,7 @@ static int ps8640_bridge_host_attach(struct device *dev, struct ps8640 *ps_bridg
 	dsi->format = MIPI_DSI_FMT_RGB888;
 	dsi->lanes = NUM_MIPI_LANES;
 
-	ret = devm_mipi_dsi_attach(dev, dsi);
-	if (ret)
-		return ret;
-
-	return 0;
+	return devm_mipi_dsi_attach(dev, dsi);
 }
 
 static int ps8640_probe(struct i2c_client *client)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach
  2022-04-29  5:51 [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach cgel.zte
@ 2022-04-29 16:21 ` Doug Anderson
  2022-05-10 18:20   ` Doug Anderson
  0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2022-04-29 16:21 UTC (permalink / raw)
  To: jing yangyang
  Cc: Andrzej Hajda, Neil Armstrong, dri-devel, LKML, Minghao Chi, Zeal Robot

Hi,

On Thu, Apr 28, 2022 at 10:51 PM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>  drivers/gpu/drm/bridge/parade-ps8640.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach
  2022-04-29 16:21 ` Doug Anderson
@ 2022-05-10 18:20   ` Doug Anderson
  0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2022-05-10 18:20 UTC (permalink / raw)
  To: jing yangyang
  Cc: Andrzej Hajda, Neil Armstrong, dri-devel, LKML, Minghao Chi, Zeal Robot

Hi,

On Fri, Apr 29, 2022 at 9:21 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Thu, Apr 28, 2022 at 10:51 PM <cgel.zte@gmail.com> wrote:
> >
> > From: Minghao Chi <chi.minghao@zte.com.cn>
> >
> > Simplify the return expression.
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> > ---
> >  drivers/gpu/drm/bridge/parade-ps8640.c | 7 +------
> >  1 file changed, 1 insertion(+), 6 deletions(-)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Pushed to drm-misc-next:

e090532246fe drm/bridge: simplify the return expression of
ps8640_bridge_host_attach

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-10 18:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29  5:51 [PATCH] drm/bridge: simplify the return expression of ps8640_bridge_host_attach cgel.zte
2022-04-29 16:21 ` Doug Anderson
2022-05-10 18:20   ` Doug Anderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).