linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC
@ 2019-05-16 16:29 Matthias Kaehlcke
  2019-05-16 16:29 ` [PATCH v2 2/3] ARM: dts: rockchip: raise GPU trip point temperatures for veyron Matthias Kaehlcke
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Matthias Kaehlcke @ 2019-05-16 16:29 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Mark Rutland
  Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
	Douglas Anderson, Matthias Kaehlcke

This value matches what is used by the downstream Chrome OS 3.14
kernel, the 'official' kernel for veyron devices. Keep the temperature
for 'speedy' at 90°C, as in the downstream kernel.

Increase the temperature for a hardware shutdown to 125°C, which
matches the downstream configuration and gives the system a chance
to shut down orderly at the criticial trip point.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- patch added to the series
---
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
 arch/arm/boot/dts/rk3288-veyron.dtsi       | 5 +++++
 2 files changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index e16421d80d22..ab2a66aa337e 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -64,6 +64,10 @@
 	temperature = <70000>;
 };
 
+&cpu_crit {
+	temperature = <90000>;
+};
+
 &edp {
 	/delete-property/pinctrl-names;
 	/delete-property/pinctrl-0;
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 192dbc089ade..58dc538b5df3 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -99,6 +99,10 @@
 	cpu0-supply = <&vdd_cpu>;
 };
 
+&cpu_crit {
+	temperature = <100000>;
+};
+
 /* rk3288-c used in Veyron Chrome-devices has slightly changed OPPs */
 &cpu_opp_table {
 	/delete-node/ opp-312000000;
@@ -371,6 +375,7 @@
 
 	rockchip,hw-tshut-mode = <1>; /* tshut mode 0:CRU 1:GPIO */
 	rockchip,hw-tshut-polarity = <1>; /* tshut polarity 0:LOW 1:HIGH */
+	rockchip,hw-tshut-temp = <125000>;
 };
 
 &uart0 {
-- 
2.21.0.1020.gf2820cf01a-goog


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 2/3] ARM: dts: rockchip: raise GPU trip point temperatures for veyron
  2019-05-16 16:29 [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Matthias Kaehlcke
@ 2019-05-16 16:29 ` Matthias Kaehlcke
  2019-05-16 16:57   ` Doug Anderson
  2019-05-16 16:29 ` [PATCH v2 3/3] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Matthias Kaehlcke @ 2019-05-16 16:29 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Mark Rutland
  Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
	Douglas Anderson, Matthias Kaehlcke

The values match thorse used by the downstream Chrome OS 3.14
kernel, the 'official' kernel for veyron devices. Keep the critical
trip point for speedy at 90°C as in the downstream configuration.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- also raise temperature of critical trip point
- add entries at position in alphabetical order
- added entry to keep critical trip point for speedy at 90°C
- updated commit message
---
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
 arch/arm/boot/dts/rk3288-veyron.dtsi       | 8 ++++++++
 2 files changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index ab2a66aa337e..3d2769f1bef2 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -75,6 +75,10 @@
 	force-hpd;
 };
 
+&gpu_crit {
+	temperature = <90000>;
+};
+
 &panel {
 	power-supply= <&panel_regulator>;
 };
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 58dc538b5df3..aee8350b2800 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -142,6 +142,14 @@
 	status = "okay";
 };
 
+&gpu_alert0 {
+	temperature = <72500>;
+};
+
+&gpu_crit {
+	temperature = <100000>;
+};
+
 &hdmi {
 	ddc-i2c-bus = <&i2c5>;
 	status = "okay";
-- 
2.21.0.1020.gf2820cf01a-goog


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 3/3] ARM: dts: raise GPU trip point temperature for speedy to 80 degC
  2019-05-16 16:29 [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Matthias Kaehlcke
  2019-05-16 16:29 ` [PATCH v2 2/3] ARM: dts: rockchip: raise GPU trip point temperatures for veyron Matthias Kaehlcke
@ 2019-05-16 16:29 ` Matthias Kaehlcke
  2019-05-16 16:58   ` Doug Anderson
  2019-05-16 16:57 ` [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Doug Anderson
  2019-05-17 10:44 ` Heiko Stuebner
  3 siblings, 1 reply; 7+ messages in thread
From: Matthias Kaehlcke @ 2019-05-16 16:29 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Mark Rutland
  Cc: linux-arm-kernel, linux-rockchip, devicetree, linux-kernel,
	Douglas Anderson, Matthias Kaehlcke

Raise the temperature of the GPU thermal trip point for speedy
to 80°C. This is the value used by the downstream Chrome OS 3.14
kernel, the 'official' kernel for speedy.

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
Changes in v2:
- add entry at position in alphabetical order
---
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index 3d2769f1bef2..6f870d89866b 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -75,6 +75,10 @@
 	force-hpd;
 };
 
+&gpu_alert0 {
+	temperature = <80000>;
+};
+
 &gpu_crit {
 	temperature = <90000>;
 };
-- 
2.21.0.1020.gf2820cf01a-goog


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC
  2019-05-16 16:29 [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Matthias Kaehlcke
  2019-05-16 16:29 ` [PATCH v2 2/3] ARM: dts: rockchip: raise GPU trip point temperatures for veyron Matthias Kaehlcke
  2019-05-16 16:29 ` [PATCH v2 3/3] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
@ 2019-05-16 16:57 ` Doug Anderson
  2019-05-17 10:44 ` Heiko Stuebner
  3 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2019-05-16 16:57 UTC (permalink / raw)
  To: Matthias Kaehlcke
  Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
	open list:ARM/Rockchip SoC...,
	devicetree, LKML

Hi,

On Thu, May 16, 2019 at 9:29 AM Matthias Kaehlcke <mka@chromium.org> wrote:

> This value matches what is used by the downstream Chrome OS 3.14
> kernel, the 'official' kernel for veyron devices. Keep the temperature
> for 'speedy' at 90°C, as in the downstream kernel.
>
> Increase the temperature for a hardware shutdown to 125°C, which
> matches the downstream configuration and gives the system a chance
> to shut down orderly at the criticial trip point.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in v2:
> - patch added to the series
> ---
>  arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
>  arch/arm/boot/dts/rk3288-veyron.dtsi       | 5 +++++
>  2 files changed, 9 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/3] ARM: dts: rockchip: raise GPU trip point temperatures for veyron
  2019-05-16 16:29 ` [PATCH v2 2/3] ARM: dts: rockchip: raise GPU trip point temperatures for veyron Matthias Kaehlcke
@ 2019-05-16 16:57   ` Doug Anderson
  0 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2019-05-16 16:57 UTC (permalink / raw)
  To: Matthias Kaehlcke
  Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
	open list:ARM/Rockchip SoC...,
	devicetree, LKML

Hi,

On Thu, May 16, 2019 at 9:29 AM Matthias Kaehlcke <mka@chromium.org> wrote:

> The values match thorse used by the downstream Chrome OS 3.14
> kernel, the 'official' kernel for veyron devices. Keep the critical
> trip point for speedy at 90°C as in the downstream configuration.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in v2:
> - also raise temperature of critical trip point
> - add entries at position in alphabetical order
> - added entry to keep critical trip point for speedy at 90°C
> - updated commit message
> ---
>  arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
>  arch/arm/boot/dts/rk3288-veyron.dtsi       | 8 ++++++++
>  2 files changed, 12 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 3/3] ARM: dts: raise GPU trip point temperature for speedy to 80 degC
  2019-05-16 16:29 ` [PATCH v2 3/3] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
@ 2019-05-16 16:58   ` Doug Anderson
  0 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2019-05-16 16:58 UTC (permalink / raw)
  To: Matthias Kaehlcke
  Cc: Heiko Stuebner, Rob Herring, Mark Rutland, Linux ARM,
	open list:ARM/Rockchip SoC...,
	devicetree, LKML

Hi,

On Thu, May 16, 2019 at 9:29 AM Matthias Kaehlcke <mka@chromium.org> wrote:

> Raise the temperature of the GPU thermal trip point for speedy
> to 80°C. This is the value used by the downstream Chrome OS 3.14
> kernel, the 'official' kernel for speedy.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Changes in v2:
> - add entry at position in alphabetical order
> ---
>  arch/arm/boot/dts/rk3288-veyron-speedy.dts | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC
  2019-05-16 16:29 [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Matthias Kaehlcke
                   ` (2 preceding siblings ...)
  2019-05-16 16:57 ` [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Doug Anderson
@ 2019-05-17 10:44 ` Heiko Stuebner
  3 siblings, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2019-05-17 10:44 UTC (permalink / raw)
  To: Matthias Kaehlcke
  Cc: Rob Herring, Mark Rutland, linux-arm-kernel, linux-rockchip,
	devicetree, linux-kernel, Douglas Anderson

Am Donnerstag, 16. Mai 2019, 18:29:40 CEST schrieb Matthias Kaehlcke:
> This value matches what is used by the downstream Chrome OS 3.14
> kernel, the 'official' kernel for veyron devices. Keep the temperature
> for 'speedy' at 90°C, as in the downstream kernel.
> 
> Increase the temperature for a hardware shutdown to 125°C, which
> matches the downstream configuration and gives the system a chance
> to shut down orderly at the criticial trip point.
> 
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

applied all 3 for 5.3 with Doug's RB and did a small fix to the commit
message of patch2 ("thorse").

Thanks
Heiko




^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-05-17 10:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 16:29 [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Matthias Kaehlcke
2019-05-16 16:29 ` [PATCH v2 2/3] ARM: dts: rockchip: raise GPU trip point temperatures for veyron Matthias Kaehlcke
2019-05-16 16:57   ` Doug Anderson
2019-05-16 16:29 ` [PATCH v2 3/3] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
2019-05-16 16:58   ` Doug Anderson
2019-05-16 16:57 ` [PATCH v2 1/3] ARM: dts: rockchip: raise CPU trip point temperature for veyron to 100 degC Doug Anderson
2019-05-17 10:44 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).