linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Wenrui Li <wenrui.li@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller
Date: Thu, 16 Jun 2016 08:31:25 -0700	[thread overview]
Message-ID: <CAD=FV=Vw_+HJc+onc6h+b3Fv5faRc0+=W+e3sJv2OLQJeysQLQ@mail.gmail.com> (raw)
In-Reply-To: <20160610083210.17f4fdd6@arm.com>

Marc,

On Fri, Jun 10, 2016 at 12:32 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> On Wed, 8 Jun 2016 16:05:17 +0800
> Shawn Lin <shawn.lin@rock-chips.com> wrote:
>
>> This patch adds a binding that describes the Rockchip PCIe controller
>> found on Rockchip SoCs PCIe interface.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>
>> ---
>>
>> Changes in v2:
>> - fix lots clk/reset stuff suggested by Heiko
>> - remove msi-parent and add msi-map suggested by Marc
>
> I noticed this ^^^^ ...
>
>> - drop phy related stuff
>> - some others minor fixes
>>
>>  .../devicetree/bindings/pci/rockchip-pcie.txt      | 86 ++++++++++++++++++++++
>>  1 file changed, 86 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>>
>> diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> new file mode 100644
>> index 0000000..eb92e29
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
>> @@ -0,0 +1,86 @@
>> +* Rockchip AXI PCIe Root Port Bridge DT description
>> +
>> +Required properties:
>> +- #address-cells: Address representation for root ports, set to <3>
>> +- #size-cells: Size representation for root ports, set to <2>
>> +- #interrupt-cells: specifies the number of cells needed to encode an
>> +             interrupt source. The value must be 1.
>> +- compatible: Should contain "rockchip,rk3399-pcie"
>> +- reg: Two register ranges as listed in the reg-names property
>> +- reg-names: Must include the following names
>> +     - "axi-base"
>> +     - "apb-base"
>> +- clocks: Must contain an entry for each entry in clock-names.
>> +             See ../clocks/clock-bindings.txt for details.
>> +- clock-names: Must include the following entries:
>> +     - "aclk"
>> +     - "aclk-perf"
>> +     - "hclk"
>> +     - "pm"
>> +- phys: From PHY bindings: Phandle for the Generic PHY for PCIe.
>> +- phy-names:  MUST be "pcie-phy".
>> +- interrupts: Three interrupt entries must be specified.
>> +- interrupt-names: Must include the following names
>> +     - "sys"
>> +     - "legacy"
>> +     - "client"
>> +- resets: Must contain five entries for each entry in reset-names.
>> +        See ../reset/reset.txt for details.
>> +- reset-names: Must include the following names
>> +     - "core"
>> +     - "mgmt"
>> +     - "mgmt-sticky"
>> +     - "pipe"
>> +- pinctrl-names : The pin control state names
>> +- pinctrl-0: The "default" pinctrl state
>> +- interrupt-map-mask and interrupt-map: standard PCI properties
>> +- interrupt-controller: identifies the node as an interrupt controller
>> +
>> +Optional Property:
>> +- ep-gpios: contain the entry for pre-reset gpio
>> +- num-lanes: number of lanes to use
>> +- vpcie3v3-supply: The phandle to the 3.3v regulator to use for pcie. If this
>> +  is specified we'll defer probe until we can find this regulator.
>> +- vpcie1v8-supply: The phandle to the 1.8v regulator to use for pcie. If this
>> +  is specified we'll defer probe until we can find this regulator.
>> +- vpcie0v9-supply: The phandle to the 0.9v regulator to use for pcie. If this
>> +  is specified we'll defer probe until we can find this regulator.
>> +
>> +Example:
>> +
>> +pcie0: pcie@f8000000 {
>> +     compatible = "rockchip,rk3399-pcie";
>> +     #address-cells = <3>;
>> +     #size-cells = <2>;
>> +     clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>,
>> +              <&cru PCLK_PCIE>;
>> +     clock-names = "aclk", "aclk-perf",
>> +                   "hclk";
>> +     bus-range = <0x0 0x1>;
>> +     interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>,
>> +                  <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
>> +     interrupt-names: "sys", "legacy", "client";
>> +     assigned-clocks = <&cru SCLK_PCIEPHY_REF>;
>> +     assigned-clock-parents = <&cru SCLK_PCIEPHY_REF100M>;
>> +     assigned-clock-rates = <100000000>;
>> +     ep-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
>> +     ranges = < 0x82000000 0 0xfa000000 0x0 0xfa000000 0 0x600000
>> +                0x81000000 0 0xfa600000 0x0 0xfa600000 0 0x100000 >;
>> +     num-lanes = <4>;
>> +     reg = < 0x0 0xf8000000 0x0 0x2000000 >, < 0x0 0xfd000000 0x0 0x1000000 >;
>> +     reg-name = "axi-base", "apb-base";
>> +     resets = <&cru SRST_PCIEPHY>, <&cru SRST_PCIE_CORE>, <&cru SRST_PCIE_MGMT>,
>> +              <&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE>;
>> +     reset-names = "core", "mgmt", "mgmt-sticky", "pipe";
>> +     phys = <&pcie_phy>;
>> +     phy-names = "pcie-phy";
>> +     pinctrl-names = "default";
>> +     pinctrl-0 = <&pcie_clkreq>;
>> +     #interrupt-cells = <1>;
>> +     interrupt-controller;
>> +     interrupt-map-mask = <0 0 0 7>;
>> +     interrupt-map = <0 0 0 1 &pcie0 1>,
>> +                     <0 0 0 2 &pcie0 2>,
>> +                     <0 0 0 3 &pcie0 3>,
>> +                     <0 0 0 4 &pcie0 4>;
>> +};
>
>
> And yet I don't see anything related to msi-map in the binding or in
> the example. As Doug mentioned issues with MSIs being delivered, I
> wonder if the two are related...

With Shawn's latest patches and following his latest example dts
snippet (which includes the msi-map), things worked much better.  :)

Thank you for your help!

-Doug

      reply	other threads:[~2016-06-16 15:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  8:05 Shawn Lin
2016-06-08  9:24 ` Marc Zyngier
2016-06-08 20:44 ` Rob Herring
2016-06-12  1:42   ` Shawn Lin
2016-06-10  4:01 ` Doug Anderson
2016-06-12  1:34   ` Shawn Lin
2016-06-10  7:32 ` Marc Zyngier
2016-06-16 15:31   ` Doug Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=Vw_+HJc+onc6h+b3Fv5faRc0+=W+e3sJv2OLQJeysQLQ@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=wenrui.li@rock-chips.com \
    --subject='Re: [PATCH v2 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).