* [PATCH v5 1/3] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360
@ 2022-09-23 8:47 Yunlong Jia
2022-09-23 8:47 ` [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
2022-09-23 8:47 ` [PATCH v5 3/3] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia
0 siblings, 2 replies; 7+ messages in thread
From: Yunlong Jia @ 2022-09-23 8:47 UTC (permalink / raw)
To: LKML
Cc: Douglas Anderson, Henry Sun, Yunlong Jia, Bob Moragues,
Yunlong Jia, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm
pazquel360 is an extension project based on pazquel.
We create 3 sku on pazquel360:
sku 20 for LTE with physical SIM _and_ eSIM and WiFi
sku 21 for WiFi only
sku 22 for LTE with only a physical SIM
Both sku20 and sku22 are LTE SKUs.
One has the eSIM stuffed and one doesn't.
There is a single shared device tree for the two.
Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
(no changes since v4)
Changes in v4:
1. Adjust the 'Signed-off-by'.
Changes in v3:
1. Adjust the format of the changelog.
Documentation/devicetree/bindings/arm/qcom.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index b6257683a700..ca4d8ac33353 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -463,6 +463,17 @@ properties:
- const: google,pazquel-sku2
- const: qcom,sc7180
+ - description: Google Pazquel360 with LTE (newest rev)
+ items:
+ - const: google,pazquel-sku22
+ - const: google,pazquel-sku20
+ - const: qcom,sc7180
+
+ - description: Google Pazquel360 with WiFi (newest rev)
+ items:
+ - const: google,pazquel-sku21
+ - const: qcom,sc7180
+
- description: Sharp Dynabook Chromebook C1 (rev1)
items:
- const: google,pompom-rev1
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-23 8:47 [PATCH v5 1/3] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia
@ 2022-09-23 8:47 ` Yunlong Jia
2022-09-23 12:18 ` Krzysztof Kozlowski
` (2 more replies)
2022-09-23 8:47 ` [PATCH v5 3/3] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia
1 sibling, 3 replies; 7+ messages in thread
From: Yunlong Jia @ 2022-09-23 8:47 UTC (permalink / raw)
To: LKML
Cc: Douglas Anderson, Henry Sun, Yunlong Jia, Bob Moragues,
Yunlong Jia, David Heidelberg, Dmitry Torokhov,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-input
Add an elan touch screen chip eth3915n.
Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com>
Suggested-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v5:
1. ekth3915 is the true compatible and ekth3500 is the fallback.
Changes in v4:
1. eth3915n dt bindings added in v4.
.../bindings/input/touchscreen/elan,elants_i2c.yaml | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
index a9b53c2e6f0a..f9053e5e9b24 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/elan,elants_i2c.yaml
@@ -14,9 +14,13 @@ allOf:
properties:
compatible:
- enum:
- - elan,ektf3624
- - elan,ekth3500
+ oneOf:
+ - enum:
+ - elan,ektf3624
+ - elan,ekth3500
+ - items:
+ - const: elan,ekth3915
+ - const: elan,ekth3500
reg:
maxItems: 1
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v5 3/3] arm64: dts: qcom: Add sc7180-pazquel360
2022-09-23 8:47 [PATCH v5 1/3] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia
2022-09-23 8:47 ` [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
@ 2022-09-23 8:47 ` Yunlong Jia
2022-09-23 14:56 ` Doug Anderson
1 sibling, 1 reply; 7+ messages in thread
From: Yunlong Jia @ 2022-09-23 8:47 UTC (permalink / raw)
To: LKML
Cc: Douglas Anderson, Henry Sun, Yunlong Jia, Bob Moragues,
Yunlong Jia, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-msm
Create first version device tree for pazquel360
pazquel360 is convertible and the pazquel it is based on is clamshell.
sku 20 for lte & wifi
sku 21 for wifi only
sku 22 for lte w/o esim & wifi
Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v4)
Changes in v4:
1. Adjust the 'Signed-off-by'.
2. Add touchscreen setting in dtsi.
Changes in v2:
1. Remove the touchscreen setting, as a follow-up patch
arch/arm64/boot/dts/qcom/Makefile | 2 +
.../qcom/sc7180-trogdor-pazquel360-lte.dts | 22 ++++++
.../qcom/sc7180-trogdor-pazquel360-wifi.dts | 17 +++++
.../dts/qcom/sc7180-trogdor-pazquel360.dtsi | 71 +++++++++++++++++++
4 files changed, 112 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index d7669a7cee9f..e7ea577d107c 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -87,6 +87,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-parade.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-lte-ti.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-parade.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel-ti.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel360-lte.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pazquel360-wifi.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r1-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-pompom-r2.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts
new file mode 100644
index 000000000000..021bcafcf815
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts
@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pazquel board device tree source
+ *
+ * Copyright 2021 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor.dtsi"
+#include "sc7180-trogdor-parade-ps8640.dtsi"
+#include "sc7180-trogdor-pazquel360.dtsi"
+#include "sc7180-trogdor-lte-sku.dtsi"
+
+/ {
+ model = "Google Pazquel (Parade,LTE)";
+ compatible = "google,pazquel-sku22", "google,pazquel-sku20", "qcom,sc7180";
+};
+
+&ap_sar_sensor_i2c {
+ status = "okay";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts
new file mode 100644
index 000000000000..defd84c5354a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pazquel board device tree source
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7180-trogdor.dtsi"
+#include "sc7180-trogdor-parade-ps8640.dtsi"
+#include "sc7180-trogdor-pazquel360.dtsi"
+
+/ {
+ model = "Google Pazquel (Parade,WIFI-only)";
+ compatible = "google,pazquel-sku21", "qcom,sc7180";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
new file mode 100644
index 000000000000..54b89def8402
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
@@ -0,0 +1,71 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Pazquel board device tree source
+ *
+ * Copyright 2021 Google LLC.
+ */
+
+/* This file must be included after sc7180-trogdor.dtsi */
+#include "sc7180-trogdor-pazquel.dtsi"
+
+&alc5682 {
+ compatible = "realtek,rt5682s";
+ realtek,dmic1-clk-pin = <2>;
+ realtek,dmic-clk-rate-hz = <2048000>;
+};
+
+ap_ts_pen_1v8: &i2c4 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ ap_ts: touchscreen@10 {
+ compatible = "elan,ekth3915", "elan,ekth3500";
+ reg = <0x10>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_int_l>, <&ts_reset_l>;
+
+ interrupt-parent = <&tlmm>;
+ interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
+
+ hid-descr-addr = <0x0001>;
+
+ vcc33-supply = <&pp3300_ts>;
+ vccio-supply = <&pp1800_l10a>;
+ reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>;
+ };
+};
+
+&keyboard_controller {
+ function-row-physmap = <
+ MATRIX_KEY(0x00, 0x02, 0) /* T1 */
+ MATRIX_KEY(0x03, 0x02, 0) /* T2 */
+ MATRIX_KEY(0x02, 0x02, 0) /* T3 */
+ MATRIX_KEY(0x01, 0x02, 0) /* T4 */
+ MATRIX_KEY(0x03, 0x04, 0) /* T5 */
+ MATRIX_KEY(0x02, 0x04, 0) /* T6 */
+ MATRIX_KEY(0x01, 0x04, 0) /* T7 */
+ MATRIX_KEY(0x02, 0x09, 0) /* T8 */
+ MATRIX_KEY(0x01, 0x09, 0) /* T9 */
+ MATRIX_KEY(0x00, 0x04, 0) /* T10 */
+ MATRIX_KEY(0x03, 0x09, 0) /* T11 */
+ >;
+ linux,keymap = <
+ MATRIX_KEY(0x00, 0x02, KEY_BACK)
+ MATRIX_KEY(0x03, 0x02, KEY_REFRESH)
+ MATRIX_KEY(0x02, 0x02, KEY_ZOOM)
+ MATRIX_KEY(0x01, 0x02, KEY_SCALE)
+ MATRIX_KEY(0x03, 0x04, KEY_SYSRQ)
+ MATRIX_KEY(0x02, 0x04, KEY_BRIGHTNESSDOWN)
+ MATRIX_KEY(0x01, 0x04, KEY_BRIGHTNESSUP)
+ MATRIX_KEY(0x02, 0x09, KEY_MUTE)
+ MATRIX_KEY(0x01, 0x09, KEY_VOLUMEDOWN)
+ MATRIX_KEY(0x00, 0x04, KEY_VOLUMEUP)
+ MATRIX_KEY(0x03, 0x09, KEY_SLEEP)
+ CROS_STD_MAIN_KEYMAP
+ >;
+};
+
+&sound {
+ compatible = "google,sc7180-trogdor";
+ model = "sc7180-rt5682s-max98357a-1mic";
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-23 8:47 ` [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
@ 2022-09-23 12:18 ` Krzysztof Kozlowski
2022-09-23 14:54 ` Doug Anderson
2022-09-23 16:56 ` Dmitry Torokhov
2 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-23 12:18 UTC (permalink / raw)
To: Yunlong Jia, LKML
Cc: Douglas Anderson, Henry Sun, Yunlong Jia, Bob Moragues,
David Heidelberg, Dmitry Torokhov, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-input
On 23/09/2022 10:47, Yunlong Jia wrote:
> Add an elan touch screen chip eth3915n.
>
> Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-23 8:47 ` [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
2022-09-23 12:18 ` Krzysztof Kozlowski
@ 2022-09-23 14:54 ` Doug Anderson
2022-09-23 16:56 ` Dmitry Torokhov
2 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2022-09-23 14:54 UTC (permalink / raw)
To: Yunlong Jia, Dmitry Torokhov
Cc: LKML, Henry Sun, Yunlong Jia, Bob Moragues, David Heidelberg,
Krzysztof Kozlowski, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list:HID CORE LAYER
Hi,
On Fri, Sep 23, 2022 at 1:47 AM Yunlong Jia <ecs.beijing2022@gmail.com> wrote:
>
> Add an elan touch screen chip eth3915n.
>
> Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
>
> ---
>
> Changes in v5:
> 1. ekth3915 is the true compatible and ekth3500 is the fallback.
>
> Changes in v4:
> 1. eth3915n dt bindings added in v4.
>
> .../bindings/input/touchscreen/elan,elants_i2c.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Fabulous. I'll expect this patch to go through the input tree and
patches #1 and #3 to go through the Qualcomm tree.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v5 3/3] arm64: dts: qcom: Add sc7180-pazquel360
2022-09-23 8:47 ` [PATCH v5 3/3] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia
@ 2022-09-23 14:56 ` Doug Anderson
0 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2022-09-23 14:56 UTC (permalink / raw)
To: Yunlong Jia, Bjorn Andersson
Cc: LKML, Henry Sun, Yunlong Jia, Bob Moragues, Andy Gross,
Konrad Dybcio, Krzysztof Kozlowski, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm-msm
Bjorn,
On Fri, Sep 23, 2022 at 1:47 AM Yunlong Jia <ecs.beijing2022@gmail.com> wrote:
>
> Create first version device tree for pazquel360
> pazquel360 is convertible and the pazquel it is based on is clamshell.
> sku 20 for lte & wifi
> sku 21 for wifi only
> sku 22 for lte w/o esim & wifi
>
> Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> ---
>
> (no changes since v4)
>
> Changes in v4:
> 1. Adjust the 'Signed-off-by'.
> 2. Add touchscreen setting in dtsi.
>
> Changes in v2:
> 1. Remove the touchscreen setting, as a follow-up patch
>
> arch/arm64/boot/dts/qcom/Makefile | 2 +
> .../qcom/sc7180-trogdor-pazquel360-lte.dts | 22 ++++++
> .../qcom/sc7180-trogdor-pazquel360-wifi.dts | 17 +++++
> .../dts/qcom/sc7180-trogdor-pazquel360.dtsi | 71 +++++++++++++++++++
> 4 files changed, 112 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-lte.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360-wifi.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-pazquel360.dtsi
If you're planning on a second pull request this cycle, it'd be great
if patch #1 and #3 from this series could be included. Thanks!
-Doug
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
2022-09-23 8:47 ` [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
2022-09-23 12:18 ` Krzysztof Kozlowski
2022-09-23 14:54 ` Doug Anderson
@ 2022-09-23 16:56 ` Dmitry Torokhov
2 siblings, 0 replies; 7+ messages in thread
From: Dmitry Torokhov @ 2022-09-23 16:56 UTC (permalink / raw)
To: Yunlong Jia
Cc: LKML, Douglas Anderson, Henry Sun, Yunlong Jia, Bob Moragues,
David Heidelberg, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-input
On Fri, Sep 23, 2022 at 08:47:17AM +0000, Yunlong Jia wrote:
> Add an elan touch screen chip eth3915n.
>
> Signed-off-by: Yunlong Jia <ecs.beijing2022@gmail.com>
> Suggested-by: Douglas Anderson <dianders@chromium.org>
>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-23 16:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 8:47 [PATCH v5 1/3] dt-bindings: arm: qcom: Document additional skus for sc7180 pazquel360 Yunlong Jia
2022-09-23 8:47 ` [PATCH v5 2/3] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
2022-09-23 12:18 ` Krzysztof Kozlowski
2022-09-23 14:54 ` Doug Anderson
2022-09-23 16:56 ` Dmitry Torokhov
2022-09-23 8:47 ` [PATCH v5 3/3] arm64: dts: qcom: Add sc7180-pazquel360 Yunlong Jia
2022-09-23 14:56 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).