* [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time()
@ 2017-05-23 21:51 Matthias Kaehlcke
2017-05-26 22:46 ` Doug Anderson
2017-06-08 9:22 ` [tip:perf/core] perf/core: Remove unused perf_cgroup_event_cgrp_time() function tip-bot for Matthias Kaehlcke
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2017-05-23 21:51 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Alexander Shishkin
Cc: linux-kernel, Douglas Anderson, Matthias Kaehlcke
The function was added by commit e5d1367f17ba ("perf: Add cgroup
support") in 2011 and hasn't been used since then. Removing it fixes the
following warning when building with clang:
kernel/events/core.c:696:19: error: unused function
'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
kernel/events/core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 6e75a5c9412d..9058fc7ca1fb 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event)
return 0;
}
-static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event)
-{
- return 0;
-}
-
static inline void update_cgrp_time_from_event(struct perf_event *event)
{
}
--
2.13.0.219.gdb65acc882-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time()
2017-05-23 21:51 [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time() Matthias Kaehlcke
@ 2017-05-26 22:46 ` Doug Anderson
2017-06-08 9:22 ` [tip:perf/core] perf/core: Remove unused perf_cgroup_event_cgrp_time() function tip-bot for Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2017-05-26 22:46 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Alexander Shishkin, linux-kernel
Hi,
On Tue, May 23, 2017 at 2:51 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> The function was added by commit e5d1367f17ba ("perf: Add cgroup
> support") in 2011 and hasn't been used since then. Removing it fixes the
> following warning when building with clang:
>
> kernel/events/core.c:696:19: error: unused function
> 'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function]
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> kernel/events/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 6e75a5c9412d..9058fc7ca1fb 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event)
> return 0;
> }
>
> -static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event)
> -{
> - return 0;
> -}
> -
> static inline void update_cgrp_time_from_event(struct perf_event *event)
> {
> }
Definitely seems like no reason to keep this around. FWIW:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf/core: Remove unused perf_cgroup_event_cgrp_time() function
2017-05-23 21:51 [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time() Matthias Kaehlcke
2017-05-26 22:46 ` Doug Anderson
@ 2017-06-08 9:22 ` tip-bot for Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Matthias Kaehlcke @ 2017-06-08 9:22 UTC (permalink / raw)
To: linux-tip-commits
Cc: tglx, mingo, alexander.shishkin, linux-kernel, acme, hpa,
dianders, mka, peterz, torvalds
Commit-ID: d0fabd1cb8b70073a0f44f1cf8b663b5e7241c74
Gitweb: http://git.kernel.org/tip/d0fabd1cb8b70073a0f44f1cf8b663b5e7241c74
Author: Matthias Kaehlcke <mka@chromium.org>
AuthorDate: Tue, 23 May 2017 14:51:32 -0700
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 8 Jun 2017 10:12:39 +0200
perf/core: Remove unused perf_cgroup_event_cgrp_time() function
The function was added by commit e5d1367f17ba ("perf: Add cgroup
support") in 2011 and hasn't been used since then. Removing it fixes the
following warning when building with Clang:
kernel/events/core.c:696:19: error: unused function 'perf_cgroup_event_cgrp_time' [-Werror,-Wunused-function]
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170523215132.189049-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/events/core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 407dad6..bc63f8d 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -925,11 +925,6 @@ static inline int is_cgroup_event(struct perf_event *event)
return 0;
}
-static inline u64 perf_cgroup_event_cgrp_time(struct perf_event *event)
-{
- return 0;
-}
-
static inline void update_cgrp_time_from_event(struct perf_event *event)
{
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-08 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-23 21:51 [PATCH] perf/core: Remove unused function perf_cgroup_event_cgrp_time() Matthias Kaehlcke
2017-05-26 22:46 ` Doug Anderson
2017-06-08 9:22 ` [tip:perf/core] perf/core: Remove unused perf_cgroup_event_cgrp_time() function tip-bot for Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).