From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Mark Brown <broonie@kernel.org>,
ryandcase@chromium.org, boris.brezillon@bootlin.com,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Girish Mahadevan <girishm@codeaurora.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation
Date: Fri, 21 Sep 2018 10:40:14 -0700 [thread overview]
Message-ID: <CAD=FV=Wbj+bgdSBeHSFr+nz6fzCMcmQS-D9oyzkR0yVkxiRb8A@mail.gmail.com> (raw)
In-Reply-To: <153755105782.119890.8484594239463905156@swboyd.mtv.corp.google.com>
Hi,
On Fri, Sep 21, 2018 at 10:31 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Ryan Case (2018-09-20 15:40:54)
> > diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt
> > new file mode 100644
> > index 000000000000..ecfb1e2bd520
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt
> > @@ -0,0 +1,36 @@
> > +Qualcomm Quad Serial Peripheral Interface (QSPI)
> > +
> > +The QSPI controller allows SPI protocol communication in single, dual, or quad
> > +wire transmission modes for read/write access to slaves such as NOR flash.
> > +
> > +Required properties:
> > +- compatible: Should contain:
> > + "qcom,sdm845-qspi"
>
> Does someone have a more generic compatible string that can be added
> here to indicate the type of quad SPI controller this is? I really doubt
> this is a one-off hardware block for the specific SDM845 SoC.
The compatible string used to be "qcom,qspi-v1". ...but Rob Herring
requested [1] "an SoC specific compatible string". While we could do
a compatible string like:
"qcom,sdm845-qspi", "qcom,qspi-v1".
I'm curious if that buys us anything. From all my previous experience
with device tree it is fine to name a compatible string for a
component based on the first SoC that used it. If we later find that
this is also used in an "msm1234" we could always later do the
compatible string for that device as:
"qcom, msm1234-qspi", "qcom,sdm845-qspi"
...and we don't need to try to come up with a generic name.
Obviously, though, I'll cede to whatever Rob says here though.
-Doug
[1] http://lkml.kernel.org/r/20180716222721.GA12854@rob-hp-laptop
>
> > +- reg: Should contain the base register location and length.
> > +- interrupts: Interrupt number used by the controller.
> > +- clocks: Should contain the core and AHB clock.
> > +- clock-names: Should be "core" for core clock and "iface" for AHB clock.
> > +
next prev parent reply other threads:[~2018-09-21 17:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 22:40 [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation Ryan Case
2018-09-20 22:40 ` [PATCH v2 2/2] spi: Introduce new driver for Qualcomm QuadSPI controller Ryan Case
2018-09-20 22:46 ` Randy Dunlap
2018-09-20 23:47 ` Ryan Case
2018-09-21 16:31 ` Mark Brown
2018-09-21 17:30 ` [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation Stephen Boyd
2018-09-21 17:39 ` Mark Brown
2018-09-21 18:33 ` Trent Piepho
2018-09-21 17:40 ` Doug Anderson [this message]
2018-09-21 18:40 ` Stephen Boyd
2018-09-21 18:48 ` Doug Anderson
2018-09-21 18:51 ` Mark Brown
2018-09-23 3:45 ` Stephen Boyd
2018-09-24 17:13 ` Doug Anderson
2018-09-24 18:23 ` Trent Piepho
2018-09-25 16:02 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=Wbj+bgdSBeHSFr+nz6fzCMcmQS-D9oyzkR0yVkxiRb8A@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=girishm@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).