From: Doug Anderson <dianders@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node
Date: Tue, 20 Nov 2018 11:36:09 -0800 [thread overview]
Message-ID: <CAD=FV=XgnzYBgFb7PJCn4Exr2Y9zkfWJHSAVqskgPAtQtCfgLg@mail.gmail.com> (raw)
In-Reply-To: <20181120182133.GR22824@google.com>
Hi,
On Tue, Nov 20, 2018 at 10:21 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> On Thu, Sep 27, 2018 at 02:22:53PM -0700, Matthias Kaehlcke wrote:
> > The temperature information from the temp-alarm block itself is very
> > coarse ("temperature is above/below trip points"). Provide the driver
> > with the die temperature channel of the ADC on the PMIC for more precise
> > readings.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > - based on agross/for-next (7a002fe0179c "Merge branch
> > 'defconfig-for-4.20' into all-for-4.20-redo"))
> > - depends on e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
> > from IIO pull request:
> > git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-4.20a
> > - to work properly https://patchwork.kernel.org/patch/10594491/ is
> > needed
> > ---
> > arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > index 048f19fa0150..fab5a826fb01 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > @@ -58,6 +58,8 @@
> > compatible = "qcom,spmi-temp-alarm";
> > reg = <0x2400>;
> > interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>;
> > + io-channels = <&pm8998_adc ADC5_DIE_TEMP>;
> > + io-channel-names = "thermal";
> > #thermal-sensor-cells = <0>;
> > };
> >
>
> I think this should be ready to land in for-next now that "arm64: dts:
> qcom: pm8998: Add die temperature channel node to the ADC"
> (a789fd0bab57) has been added.
Agreed and this matches my understanding of how things are supposed to
work. FWIW:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
prev parent reply other threads:[~2018-11-20 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 21:22 [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node Matthias Kaehlcke
2018-11-20 18:21 ` Matthias Kaehlcke
2018-11-20 19:36 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XgnzYBgFb7PJCn4Exr2Y9zkfWJHSAVqskgPAtQtCfgLg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).