* [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node
@ 2018-09-27 21:22 Matthias Kaehlcke
2018-11-20 18:21 ` Matthias Kaehlcke
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-09-27 21:22 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland
Cc: linux-arm-msm, linux-soc, devicetree, linux-kernel,
Douglas Anderson, Matthias Kaehlcke
The temperature information from the temp-alarm block itself is very
coarse ("temperature is above/below trip points"). Provide the driver
with the die temperature channel of the ADC on the PMIC for more precise
readings.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
- based on agross/for-next (7a002fe0179c "Merge branch
'defconfig-for-4.20' into all-for-4.20-redo"))
- depends on e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
from IIO pull request:
git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-4.20a
- to work properly https://patchwork.kernel.org/patch/10594491/ is
needed
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index 048f19fa0150..fab5a826fb01 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -58,6 +58,8 @@
compatible = "qcom,spmi-temp-alarm";
reg = <0x2400>;
interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>;
+ io-channels = <&pm8998_adc ADC5_DIE_TEMP>;
+ io-channel-names = "thermal";
#thermal-sensor-cells = <0>;
};
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node
2018-09-27 21:22 [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node Matthias Kaehlcke
@ 2018-11-20 18:21 ` Matthias Kaehlcke
2018-11-20 19:36 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-11-20 18:21 UTC (permalink / raw)
To: Andy Gross, David Brown, Rob Herring, Mark Rutland
Cc: linux-arm-msm, linux-soc, devicetree, linux-kernel, Douglas Anderson
On Thu, Sep 27, 2018 at 02:22:53PM -0700, Matthias Kaehlcke wrote:
> The temperature information from the temp-alarm block itself is very
> coarse ("temperature is above/below trip points"). Provide the driver
> with the die temperature channel of the ADC on the PMIC for more precise
> readings.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> - based on agross/for-next (7a002fe0179c "Merge branch
> 'defconfig-for-4.20' into all-for-4.20-redo"))
> - depends on e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
> from IIO pull request:
> git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-4.20a
> - to work properly https://patchwork.kernel.org/patch/10594491/ is
> needed
> ---
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index 048f19fa0150..fab5a826fb01 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -58,6 +58,8 @@
> compatible = "qcom,spmi-temp-alarm";
> reg = <0x2400>;
> interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>;
> + io-channels = <&pm8998_adc ADC5_DIE_TEMP>;
> + io-channel-names = "thermal";
> #thermal-sensor-cells = <0>;
> };
>
I think this should be ready to land in for-next now that "arm64: dts:
qcom: pm8998: Add die temperature channel node to the ADC"
(a789fd0bab57) has been added.
Cheers
Matthias
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node
2018-11-20 18:21 ` Matthias Kaehlcke
@ 2018-11-20 19:36 ` Doug Anderson
0 siblings, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2018-11-20 19:36 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: Andy Gross, David Brown, Rob Herring, Mark Rutland,
linux-arm-msm, open list:ARM/QUALCOMM SUPPORT, devicetree, LKML
Hi,
On Tue, Nov 20, 2018 at 10:21 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> On Thu, Sep 27, 2018 at 02:22:53PM -0700, Matthias Kaehlcke wrote:
> > The temperature information from the temp-alarm block itself is very
> > coarse ("temperature is above/below trip points"). Provide the driver
> > with the die temperature channel of the ADC on the PMIC for more precise
> > readings.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > - based on agross/for-next (7a002fe0179c "Merge branch
> > 'defconfig-for-4.20' into all-for-4.20-redo"))
> > - depends on e13d757279bb ("iio: adc: Add QCOM SPMI PMIC5 ADC driver")
> > from IIO pull request:
> > git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-4.20a
> > - to work properly https://patchwork.kernel.org/patch/10594491/ is
> > needed
> > ---
> > arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > index 048f19fa0150..fab5a826fb01 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > @@ -58,6 +58,8 @@
> > compatible = "qcom,spmi-temp-alarm";
> > reg = <0x2400>;
> > interrupts = <0x0 0x24 0x0 IRQ_TYPE_EDGE_RISING>;
> > + io-channels = <&pm8998_adc ADC5_DIE_TEMP>;
> > + io-channel-names = "thermal";
> > #thermal-sensor-cells = <0>;
> > };
> >
>
> I think this should be ready to land in for-next now that "arm64: dts:
> qcom: pm8998: Add die temperature channel node to the ADC"
> (a789fd0bab57) has been added.
Agreed and this matches my understanding of how things are supposed to
work. FWIW:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-20 19:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 21:22 [PATCH] arm64: dts: qcom: pm8998: Use ADC temperature to temp-alarm node Matthias Kaehlcke
2018-11-20 18:21 ` Matthias Kaehlcke
2018-11-20 19:36 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).