From: Baolin Wang <baolin.wang7@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Lyra Zhang <zhang.lyra@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/3] Add new reg_update_bits() support
Date: Thu, 9 Apr 2020 17:56:25 +0800 [thread overview]
Message-ID: <CADBw62oGRPhhA4pRJXZ=1s5pt2FEYps=cSK+RG+doWE9owDqZw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a3rFKVukWk7U1abHnW4a-5TV4e57f=9Lt9Xbfytm7H09A@mail.gmail.com>
On Thu, Apr 9, 2020 at 5:52 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Apr 9, 2020 at 11:40 AM Baolin Wang <baolin.wang7@gmail.com> wrote:
>
> > > It would be nice in theory to move the sigmatel devices over to
> > > reg_update_bits() in theory, but this seems unlikely to actually happen,
> > > given that these are mostly obsolete drivers at this point.
> >
> > I checked all sigmatel devices (about 10 drivers), I think there will
> > be more work to change them to use syscon/regmap when changing to
> > reg_update_bits(). I am afraid I can not thelp to convert them without
> > a hardware, and as you said, some drivers are already dead. So I think
> > it would be nice if the driver owners can help to convert these
> > drivers, if we get a consensus about the reg_update_bits()
> > implementation at last.
>
> Thanks for taking a closer look. I didn't want to imply that you should
> fix them, just saying that it might have been nice if they had been
> done like this in the first place. Of course, when the drivers were
> written, we did not even have the regmap-mmio helpers at all.
Make sense. Thanks.
--
Baolin Wang
prev parent reply other threads:[~2020-04-09 9:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 8:57 [RFC PATCH 0/3] Add new reg_update_bits() support Baolin Wang
2020-04-09 8:57 ` [RFC PATCH 1/3] mfd: syscon: Add reg_update_bits() callback support Baolin Wang
2020-04-09 10:48 ` Mark Brown
2020-04-09 14:13 ` Baolin Wang
2020-04-09 14:27 ` Mark Brown
2020-04-10 2:15 ` Baolin Wang
2020-04-09 8:57 ` [RFC PATCH 2/3] regmap: Add reg_update_bits() support Baolin Wang
2020-04-09 10:45 ` Mark Brown
2020-04-09 14:12 ` Baolin Wang
2020-04-09 14:26 ` Mark Brown
2020-04-10 2:55 ` Baolin Wang
2020-04-09 8:57 ` [RFC PATCH 3/3] soc: sprd: Add Spreadtrum special bits updating support Baolin Wang
2020-04-09 9:15 ` [RFC PATCH 0/3] Add new reg_update_bits() support Arnd Bergmann
2020-04-09 9:40 ` Baolin Wang
2020-04-09 9:52 ` Arnd Bergmann
2020-04-09 9:56 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADBw62oGRPhhA4pRJXZ=1s5pt2FEYps=cSK+RG+doWE9owDqZw@mail.gmail.com' \
--to=baolin.wang7@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).