linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable
@ 2019-09-17  6:50 Austin Kim
  2019-09-23 13:34 ` Austin Kim
  2019-10-01  9:20 ` Kalle Valo
  0 siblings, 2 replies; 4+ messages in thread
From: Austin Kim @ 2019-09-17  6:50 UTC (permalink / raw)
  To: pkshih, kvalo, davem; +Cc: linux-wireless, netdev, linux-kernel, austindh.kim

'rtstatus' local variable is not used,
so remove it for clean-up.

Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
index 54a3aec..22441dd 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
@@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
 					    enum radio_path rfpath)
 {
 	int i;
-	bool rtstatus = true;
 	u32 *radioa_array_table;
 	u16 radioa_arraylen;
 
 	radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
 	radioa_array_table = RTL8723E_RADIOA_1TARRAY;
 
-	rtstatus = true;
-
 	switch (rfpath) {
 	case RF90_PATH_A:
 		for (i = 0; i < radioa_arraylen; i = i + 2) {
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable
  2019-09-17  6:50 [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable Austin Kim
@ 2019-09-23 13:34 ` Austin Kim
  2019-09-24  1:21   ` Pkshih
  2019-10-01  9:20 ` Kalle Valo
  1 sibling, 1 reply; 4+ messages in thread
From: Austin Kim @ 2019-09-23 13:34 UTC (permalink / raw)
  To: pkshih, kvalo, davem; +Cc: linux-wireless, netdev, linux-kernel

Hello, Maintainers...
Would you please review above patch if you are available?

Thanks,
Austin Kim

2019년 9월 17일 (화) 오후 3:50, Austin Kim <austindh.kim@gmail.com>님이 작성:
>
> 'rtstatus' local variable is not used,
> so remove it for clean-up.
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> index 54a3aec..22441dd 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
> @@ -485,15 +485,12 @@ bool rtl8723e_phy_config_rf_with_headerfile(struct ieee80211_hw *hw,
>                                             enum radio_path rfpath)
>  {
>         int i;
> -       bool rtstatus = true;
>         u32 *radioa_array_table;
>         u16 radioa_arraylen;
>
>         radioa_arraylen = RTL8723ERADIOA_1TARRAYLENGTH;
>         radioa_array_table = RTL8723E_RADIOA_1TARRAY;
>
> -       rtstatus = true;
> -
>         switch (rfpath) {
>         case RF90_PATH_A:
>                 for (i = 0; i < radioa_arraylen; i = i + 2) {
> --
> 2.6.2
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable
  2019-09-23 13:34 ` Austin Kim
@ 2019-09-24  1:21   ` Pkshih
  0 siblings, 0 replies; 4+ messages in thread
From: Pkshih @ 2019-09-24  1:21 UTC (permalink / raw)
  To: Austin Kim, kvalo, davem; +Cc: linux-wireless, netdev, linux-kernel


> -----Original Message-----
> From: Austin Kim [mailto:austindh.kim@gmail.com]
> Sent: Monday, September 23, 2019 9:35 PM
> To: Pkshih; kvalo@codeaurora.org; davem@davemloft.net
> Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable
> 
> Hello, Maintainers...
> Would you please review above patch if you are available?
> 

You can check status of your patch here
https://patchwork.kernel.org/project/linux-wireless/list/?series=174859
If your patch is existing in patchwork, maintainer doesn't forget it.

Another thing is to avoid top posting that makes maintainer hard to read mail.

---
PK


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable
  2019-09-17  6:50 [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable Austin Kim
  2019-09-23 13:34 ` Austin Kim
@ 2019-10-01  9:20 ` Kalle Valo
  1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-10-01  9:20 UTC (permalink / raw)
  To: Austin Kim
  Cc: pkshih, davem, linux-wireless, netdev, linux-kernel, austindh.kim

Austin Kim <austindh.kim@gmail.com> wrote:

> 'rtstatus' local variable is not used,
> so remove it for clean-up.
> 
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

6e7d59776311 rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable

-- 
https://patchwork.kernel.org/patch/11148141/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-01  9:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17  6:50 [PATCH] rtlwifi: rtl8723ae: Remove unused 'rtstatus' variable Austin Kim
2019-09-23 13:34 ` Austin Kim
2019-09-24  1:21   ` Pkshih
2019-10-01  9:20 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).