From: Stephen Barber <smbarber@chromium.org>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Eduardo Valentin <edubezval@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Rocky Hao <rocky.hao@rock-chips.com>,
Zhang Rui <rui.zhang@intel.com>, Heiko Stuebner <heiko@sntech.de>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period
Date: Thu, 28 Jul 2016 14:53:28 -0700 [thread overview]
Message-ID: <CADR9n4__hcQosSOM5w0PMw8ck_gPi4Sc5ixbN6CiKKGia2gd7A@mail.gmail.com> (raw)
In-Reply-To: <1469628643-29661-2-git-send-email-wxt@rock-chips.com>
On Wed, Jul 27, 2016 at 7:10 AM, Caesar Wang <wxt@rock-chips.com> wrote:
> From: Rocky Hao <rocky.hao@rock-chips.com>
>
> In less than 10 ms, the temperature of soc will arise 10 degree. 250 ms
> is too big for soc tempeture control. Setting 2.5 ms will speed up
> temperature accessing speed but introduce no more cpu's computing overhead.
> We set AUTO_PERIOD_TIME and TSADCV3_AUTO_PERIOD_HT_TIME the same value,
> because normal temperature update speed is also our consern in IPA.
>
> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-pm@vger.kernel.org
>
> ---
>
> drivers/thermal/rockchip_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index a90423d..1f165c9 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -213,8 +213,8 @@ struct rockchip_thermal_data {
> #define TSADCV2_HIGHT_TSHUT_DEBOUNCE_COUNT 4
> #define TSADCV2_AUTO_PERIOD_TIME 250 /* 250ms */
> #define TSADCV2_AUTO_PERIOD_HT_TIME 50 /* 50ms */
> -#define TSADCV3_AUTO_PERIOD_TIME 187500 /* 250ms */
> -#define TSADCV3_AUTO_PERIOD_HT_TIME 37500 /* 50ms */
> +#define TSADCV3_AUTO_PERIOD_TIME 1875 /* 2.5ms */
> +#define TSADCV3_AUTO_PERIOD_HT_TIME 1875 /* 2.5ms */
>
> #define TSADCV2_USER_INTER_PD_SOC 0x340 /* 13 clocks */
>
> --
> 1.9.1
>
Tested-by: Stephen Barber <smbarber@chromium.org>
Steve
next prev parent reply other threads:[~2016-07-28 21:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 14:10 [PATCH 1/2] thermal: rockchip: enhance the tsadc's bandgap feature for rk3399 Caesar Wang
2016-07-27 14:10 ` [PATCH 2/2] thermal: rockchip: optimize sensor auto accessing period Caesar Wang
2016-07-28 21:53 ` Stephen Barber [this message]
2016-07-28 21:53 ` [PATCH 1/2] thermal: rockchip: enhance the tsadc's bandgap feature for rk3399 Stephen Barber
2016-08-19 13:09 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADR9n4__hcQosSOM5w0PMw8ck_gPi4Sc5ixbN6CiKKGia2gd7A@mail.gmail.com \
--to=smbarber@chromium.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=edubezval@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rocky.hao@rock-chips.com \
--cc=rui.zhang@intel.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).