* [PATCH] drivers: ufs: Add missing MODULE_* information
@ 2019-03-21 12:50 Anders Roxell
2019-03-21 13:18 ` Stanley Chu
0 siblings, 1 reply; 3+ messages in thread
From: Anders Roxell @ 2019-03-21 12:50 UTC (permalink / raw)
To: jejb, martin.petersen, matthias.bgg
Cc: linux-scsi, linux-kernel, linux-arm-kernel, linux-mediatek,
Anders Roxell
When building the ufs-mediatek module the following warning shows up:
WARNING: modpost: missing MODULE_LICENSE() in
drivers/scsi/ufs/ufs-mediatek.o
Rework to add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/scsi/ufs/ufs-mediatek.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index c3b78fc83d3f..ce4767784937 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -364,4 +364,9 @@ static struct platform_driver ufs_mtk_pltform = {
},
};
+MODULE_AUTHOR("Stanley Chu <stanley.chu@mediatek.com>");
+MODULE_AUTHOR("Peter Wang <peter.wang@mediatek.com>");
+MODULE_DESCRIPTION("Mediatek UFS Driver");
+MODULE_LICENSE("GPL v2");
+
module_platform_driver(ufs_mtk_pltform);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: ufs: Add missing MODULE_* information
2019-03-21 12:50 [PATCH] drivers: ufs: Add missing MODULE_* information Anders Roxell
@ 2019-03-21 13:18 ` Stanley Chu
2019-03-21 13:21 ` Anders Roxell
0 siblings, 1 reply; 3+ messages in thread
From: Stanley Chu @ 2019-03-21 13:18 UTC (permalink / raw)
To: Anders Roxell
Cc: jejb, martin.petersen, matthias.bgg, linux-scsi, linux-kernel,
linux-arm-kernel, linux-mediatek, peter.wang
Hi Anders,
On Thu, 2019-03-21 at 13:50 +0100, Anders Roxell wrote:
> When building the ufs-mediatek module the following warning shows up:
>
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/scsi/ufs/ufs-mediatek.o
>
> Rework to add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
>
> Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index c3b78fc83d3f..ce4767784937 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -364,4 +364,9 @@ static struct platform_driver ufs_mtk_pltform = {
> },
> };
>
> +MODULE_AUTHOR("Stanley Chu <stanley.chu@mediatek.com>");
> +MODULE_AUTHOR("Peter Wang <peter.wang@mediatek.com>");
> +MODULE_DESCRIPTION("Mediatek UFS Driver");
Thanks for sending this.
Could you fix it as "MediaTek UFS Host Driver" ?
> +MODULE_LICENSE("GPL v2");
> +
> module_platform_driver(ufs_mtk_pltform);
Thanks,
Stanley
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: ufs: Add missing MODULE_* information
2019-03-21 13:18 ` Stanley Chu
@ 2019-03-21 13:21 ` Anders Roxell
0 siblings, 0 replies; 3+ messages in thread
From: Anders Roxell @ 2019-03-21 13:21 UTC (permalink / raw)
To: Stanley Chu
Cc: jejb, martin.petersen, Matthias Brugger, linux-scsi,
Linux Kernel Mailing List, Linux ARM, linux-mediatek, peter.wang
On Thu, 21 Mar 2019 at 14:18, Stanley Chu <stanley.chu@mediatek.com> wrote:
>
> Hi Anders,
>
> On Thu, 2019-03-21 at 13:50 +0100, Anders Roxell wrote:
> > When building the ufs-mediatek module the following warning shows up:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in
> > drivers/scsi/ufs/ufs-mediatek.o
> >
> > Rework to add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
> >
> > Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips")
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > drivers/scsi/ufs/ufs-mediatek.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> > index c3b78fc83d3f..ce4767784937 100644
> > --- a/drivers/scsi/ufs/ufs-mediatek.c
> > +++ b/drivers/scsi/ufs/ufs-mediatek.c
> > @@ -364,4 +364,9 @@ static struct platform_driver ufs_mtk_pltform = {
> > },
> > };
> >
> > +MODULE_AUTHOR("Stanley Chu <stanley.chu@mediatek.com>");
> > +MODULE_AUTHOR("Peter Wang <peter.wang@mediatek.com>");
> > +MODULE_DESCRIPTION("Mediatek UFS Driver");
>
> Thanks for sending this.
>
> Could you fix it as "MediaTek UFS Host Driver" ?
Yes, I'll update it and sending out a v2 shortly.
Cheers,
Anders
>
> > +MODULE_LICENSE("GPL v2");
> > +
> > module_platform_driver(ufs_mtk_pltform);
>
> Thanks,
> Stanley
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-21 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 12:50 [PATCH] drivers: ufs: Add missing MODULE_* information Anders Roxell
2019-03-21 13:18 ` Stanley Chu
2019-03-21 13:21 ` Anders Roxell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).