From: Aniroop Mathur <aniroop.mathur@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Aniroop Mathur <a.mathur@samsung.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
s.samuel@samsung.com, r.mahale@samsung.com,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Vlad Dogaru <vlad.dogaru@intel.com>
Subject: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs
Date: Sat, 3 Dec 2016 00:31:18 +0530 [thread overview]
Message-ID: <CADYu30_epk8BVEjEag+eMqsAzugY69nhh80YO-qiC9-VofQZew@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbB9AYWiaoLtr6QLZXSsyGZYkDRy2F6VKopHxx+c=FsWg@mail.gmail.com>
On Wed, Nov 30, 2016 at 5:49 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sun, Nov 27, 2016 at 11:51 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 26/11/16 03:47, Aniroop Mathur wrote:
>
> [bmp280.c]
>
>>> /* Wait to make sure we started up properly */
>>> - mdelay(data->start_up_time);
>>> + usleep_range(data->start_up_time, data->start_up_time + 100);
>>
>> As this in probe I doubt we really care. Could just set it longer to shut up the warnings.
>> Still would like some input from say Linus on this...
>
> Hm, I don't think it's a big issue... this works too it just looks overworked.
>
> On the runtime_resume() path we use msleep() instead which I guess is why
> it is not changed in this patch, but they have the same purpose.
>
I did change msleep to usleep_range in runtime_resume() in bmp280.c
as you know resume time is critical indeed.
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2016-12-02 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-26 3:47 [PATCH] IIO: Change msleep to usleep_range for small msecs Aniroop Mathur
2016-11-27 10:51 ` Jonathan Cameron
2016-11-30 12:19 ` Linus Walleij
2016-12-02 19:01 ` Aniroop Mathur [this message]
2016-11-30 13:35 ` Lars-Peter Clausen
[not found] ` <CGME20161130133557epcas2p2caca5d58770bf31614812d14b809fe8f@epcas2p2.samsung.com>
2016-11-30 14:43 ` Aniroop Mathur
2016-12-02 19:07 ` Aniroop Mathur
2016-12-03 9:00 ` Jonathan Cameron
2016-12-03 15:43 ` Aniroop Mathur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADYu30_epk8BVEjEag+eMqsAzugY69nhh80YO-qiC9-VofQZew@mail.gmail.com \
--to=aniroop.mathur@gmail.com \
--cc=a.mathur@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=r.mahale@samsung.com \
--cc=s.samuel@samsung.com \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).