From: Chen Yu <yu.chen.surf@gmail.com>
To: Abel Wu <wuyun.abel@bytedance.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>,
Vincent Guittot <vincent.guittot@linaro.org>,
Josh Don <joshdon@google.com>, Chen Yu <yu.c.chen@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] sched/fair: ignore SIS_UTIL when has idle core
Date: Wed, 10 Aug 2022 21:50:06 +0800 [thread overview]
Message-ID: <CADjb_WRdvKm=uJGe2zE+D6fHkuCX4i+WkrWqz1A3VXmtdKN_Tg@mail.gmail.com> (raw)
In-Reply-To: <20220712082036.5130-2-wuyun.abel@bytedance.com>
On Tue, Jul 12, 2022 at 4:45 PM Abel Wu <wuyun.abel@bytedance.com> wrote:
>
> When SIS_UTIL is enabled, SIS domain scan will be skipped if
> the LLC is overloaded. Since the overloaded status is checked
> in the load balancing at LLC level, the interval is llc_size
> miliseconds. The duration might be long enough to affect the
> overall system throughput if idle cores are out of reach in
> SIS domain scan.
>
> Signed-off-by: Abel Wu <wuyun.abel@bytedance.com>
> ---
>
Tested schbench and netperf on latest 5.19 vanilla, it seems that there
is latency performance improvement when the load is low in schbench,
and no performance difference on netperf.
./report.py -b 5.19.0+ -c 5.19.0-skip-sis-util+ -t schbench
schbench
========
case load baseline(std%) compare%( std%)
normal mthread-1 1.00 ( 0.00) +7.69 ( 0.00)
normal mthread-2 1.00 ( 0.00) +13.24 ( 0.00)
normal mthread-4 1.00 ( 0.00) -5.88 ( 0.00)
normal mthread-8 1.00 ( 0.00) -0.25 ( 0.00)
./report.py -b 5.19.0+ -c 5.19.0-skip-sis-util+ -t netperf
netperf
=======
case load baseline(std%) compare%( std%)
TCP_RR thread-28 1.00 ( 0.62) +0.15 ( 0.55)
TCP_RR thread-56 1.00 ( 0.42) -0.26 ( 0.40)
TCP_RR thread-84 1.00 ( 0.29) +0.39 ( 0.29)
TCP_RR thread-112 1.00 ( 0.22) +0.44 ( 0.23)
TCP_RR thread-140 1.00 ( 0.17) +0.33 ( 0.18)
TCP_RR thread-168 1.00 ( 0.17) +0.19 ( 0.16)
TCP_RR thread-196 1.00 ( 13.65) -0.62 ( 14.83)
TCP_RR thread-224 1.00 ( 9.80) -0.65 ( 9.67)
UDP_RR thread-28 1.00 ( 0.89) +0.92 ( 0.81)
UDP_RR thread-56 1.00 ( 0.78) +0.38 ( 0.73)
UDP_RR thread-84 1.00 ( 14.03) +0.78 ( 16.85)
UDP_RR thread-112 1.00 ( 12.26) -0.42 ( 11.95)
UDP_RR thread-140 1.00 ( 9.86) -0.89 ( 6.93)
UDP_RR thread-168 1.00 ( 11.62) -0.82 ( 8.80)
UDP_RR thread-196 1.00 ( 19.47) +0.42 ( 16.50)
UDP_RR thread-224 1.00 ( 18.68) +0.72 ( 18.50)
Tested-by: Chen Yu <yu.c.chen@intel.com>
--
Thanks,
Chenyu
next prev parent reply other threads:[~2022-08-10 13:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 8:20 [PATCH 0/5] sched/fair: SIS improvements and cleanups Abel Wu
2022-07-12 8:20 ` [PATCH 1/5] sched/fair: ignore SIS_UTIL when has idle core Abel Wu
2022-07-13 3:47 ` Chen Yu
2022-07-13 16:14 ` Abel Wu
2022-07-14 6:19 ` Yicong Yang
2022-07-14 6:58 ` Abel Wu
2022-07-14 7:15 ` Yicong Yang
2022-07-14 8:00 ` Abel Wu
2022-07-14 8:16 ` Yicong Yang
2022-07-14 8:34 ` Yicong Yang
2022-08-04 9:59 ` Chen Yu
2022-08-15 2:54 ` Abel Wu
2022-08-10 13:50 ` Chen Yu [this message]
2022-08-15 2:44 ` Abel Wu
2022-08-29 13:08 ` Mel Gorman
2022-08-29 14:11 ` Abel Wu
2022-08-29 14:56 ` Mel Gorman
2022-09-01 13:08 ` Abel Wu
2022-09-02 4:12 ` Abel Wu
2022-09-02 10:25 ` Mel Gorman
2022-09-05 14:40 ` Abel Wu
2022-09-06 9:57 ` Mel Gorman
2022-09-07 7:27 ` Chen Yu
2022-09-07 8:41 ` Mel Gorman
2022-09-07 7:52 ` Abel Wu
2022-07-12 8:20 ` [PATCH 2/5] sched/fair: default to false in test_idle_cores Abel Wu
2022-08-29 12:36 ` Mel Gorman
2022-07-12 8:20 ` [PATCH 3/5] sched/fair: remove redundant check in select_idle_smt Abel Wu
2022-08-29 12:36 ` Mel Gorman
2022-07-12 8:20 ` [PATCH 4/5] sched/fair: avoid double search on same cpu Abel Wu
2022-08-29 12:36 ` Mel Gorman
2022-07-12 8:20 ` [PATCH 5/5] sched/fair: remove useless check in select_idle_core Abel Wu
2022-08-29 12:37 ` Mel Gorman
2022-08-15 13:31 ` [PATCH 0/5] sched/fair: SIS improvements and cleanups Abel Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADjb_WRdvKm=uJGe2zE+D6fHkuCX4i+WkrWqz1A3VXmtdKN_Tg@mail.gmail.com' \
--to=yu.chen.surf@gmail.com \
--cc=joshdon@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=wuyun.abel@bytedance.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).