* [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg
@ 2020-11-18 2:42 Bernard Zhao
2020-11-18 8:17 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Bernard Zhao @ 2020-11-18 2:42 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Daniel Vetter,
Felix Kuehling, Joerg Roedel, Borislav Petkov, Bernard Zhao,
Fenghua Yu, amd-gfx, dri-devel, linux-kernel
Cc: opensource.kernel
Fix check_patch.pl warning:
kmalloc_array uses number as first arg, sizeof is generally wrong.
+fences = kmalloc_array(sizeof(void *), id_mgr->num_ids,
GFP_KERNEL);
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
index 6e9a9e5dbea0..f2bd4b0e06f6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
@@ -208,7 +208,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,
if (ring->vmid_wait && !dma_fence_is_signaled(ring->vmid_wait))
return amdgpu_sync_fence(sync, ring->vmid_wait);
- fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL);
+ fences = kmalloc_array(id_mgr->num_ids, sizeof(void *), GFP_KERNEL);
if (!fences)
return -ENOMEM;
--
2.29.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg
2020-11-18 2:42 [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg Bernard Zhao
@ 2020-11-18 8:17 ` Christian König
2020-11-19 21:54 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2020-11-18 8:17 UTC (permalink / raw)
To: Bernard Zhao, Alex Deucher, David Airlie, Daniel Vetter,
Felix Kuehling, Joerg Roedel, Borislav Petkov, Fenghua Yu,
amd-gfx, dri-devel, linux-kernel
Cc: opensource.kernel
Am 18.11.20 um 03:42 schrieb Bernard Zhao:
> Fix check_patch.pl warning:
> kmalloc_array uses number as first arg, sizeof is generally wrong.
> +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids,
> GFP_KERNEL);
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> index 6e9a9e5dbea0..f2bd4b0e06f6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> @@ -208,7 +208,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,
> if (ring->vmid_wait && !dma_fence_is_signaled(ring->vmid_wait))
> return amdgpu_sync_fence(sync, ring->vmid_wait);
>
> - fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL);
> + fences = kmalloc_array(id_mgr->num_ids, sizeof(void *), GFP_KERNEL);
> if (!fences)
> return -ENOMEM;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg
2020-11-18 8:17 ` Christian König
@ 2020-11-19 21:54 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2020-11-19 21:54 UTC (permalink / raw)
To: Christian König
Cc: Bernard Zhao, Alex Deucher, David Airlie, Daniel Vetter,
Felix Kuehling, Joerg Roedel, Borislav Petkov, Fenghua Yu,
amd-gfx list, Maling list - DRI developers, LKML,
opensource.kernel
Applied. Thanks!
Alex
On Wed, Nov 18, 2020 at 3:17 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 18.11.20 um 03:42 schrieb Bernard Zhao:
> > Fix check_patch.pl warning:
> > kmalloc_array uses number as first arg, sizeof is generally wrong.
> > +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids,
> > GFP_KERNEL);
> >
> > Signed-off-by: Bernard Zhao <bernard@vivo.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > index 6e9a9e5dbea0..f2bd4b0e06f6 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c
> > @@ -208,7 +208,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,
> > if (ring->vmid_wait && !dma_fence_is_signaled(ring->vmid_wait))
> > return amdgpu_sync_fence(sync, ring->vmid_wait);
> >
> > - fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL);
> > + fences = kmalloc_array(id_mgr->num_ids, sizeof(void *), GFP_KERNEL);
> > if (!fences)
> > return -ENOMEM;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-19 21:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 2:42 [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg Bernard Zhao
2020-11-18 8:17 ` Christian König
2020-11-19 21:54 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).