From: Alex Deucher <alexdeucher@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alex Deucher <alexander.deucher@amd.com>,
Rex Zhu <Rex.Zhu@amd.com>, LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] amdgpu: use NULL instead of 0 for pointer
Date: Wed, 15 Jun 2016 17:28:07 -0400 [thread overview]
Message-ID: <CADnq5_M6wFJ3agDmopWnJ-oGjQc3rywuE0W=j5frHUvWO3D4Dg@mail.gmail.com> (raw)
In-Reply-To: <5761BB7A.8080209@amd.com>
On Wed, Jun 15, 2016 at 4:32 PM, Christian König
<christian.koenig@amd.com> wrote:
> Am 15.06.2016 um 22:15 schrieb Arnd Bergmann:
>>
>> In the AMD powerplay driver, a pointer is checked for validity by
>> comparing against an integer '0', which causes a harmless warning
>> when building with "make W=1":
>>
>> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16:
>> error: ordered comparison of pointer with integer zero [-Werror=extra]
>>
>> This changes the code to the more conventional "if (pointer)" check.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>.
Applied. thanks!
Alex
>
>> ---
>> drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
>> b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
>> index 2f1a14fe05b1..b64f42d2c3ae 100644
>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c
>> @@ -1499,7 +1499,7 @@ int get_number_of_vce_state_table_entries(
>> const ATOM_PPLIB_VCE_State_Table *vce_table =
>> get_vce_state_table(hwmgr, table);
>> - if (vce_table > 0)
>> + if (vce_table)
>> return vce_table->numEntries;
>> return 0;
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-06-15 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 20:15 [PATCH] amdgpu: use NULL instead of 0 for pointer Arnd Bergmann
2016-06-15 20:32 ` Christian König
2016-06-15 21:28 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_M6wFJ3agDmopWnJ-oGjQc3rywuE0W=j5frHUvWO3D4Dg@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Rex.Zhu@amd.com \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).