* [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static
@ 2022-10-19 6:31 ruanjinjie
2022-10-19 13:27 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: ruanjinjie @ 2022-10-19 6:31 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, jiapeng.chong,
aurabindo.pillai, isabbasso, amd-gfx, dri-devel, linux-kernel
Cc: ruanjinjie
The symbol is not used outside of the file, so mark it static.
Fixes the following warning:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28:
warning: symbol 'dcn32_mmhubbub_funcs' was
not declared. Should it be static?
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
index 41b0baf8e183..c3b089ba511a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
@@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb,
REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE, params->arbitration_slice);
}
-const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
+static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
.warmup_mcif = mmhubbub32_warmup_mcif,
.enable_mcif = mmhubbub2_enable_mcif,
.disable_mcif = mmhubbub2_disable_mcif,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static
2022-10-19 6:31 [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static ruanjinjie
@ 2022-10-19 13:27 ` Harry Wentland
2022-10-20 13:11 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2022-10-19 13:27 UTC (permalink / raw)
To: ruanjinjie, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, jiapeng.chong,
aurabindo.pillai, isabbasso, amd-gfx, dri-devel, linux-kernel
On 2022-10-19 02:31, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
>
> Fixes the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28:
> warning: symbol 'dcn32_mmhubbub_funcs' was
> not declared. Should it be static?
>
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> index 41b0baf8e183..c3b089ba511a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb,
> REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE, params->arbitration_slice);
> }
>
> -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> .warmup_mcif = mmhubbub32_warmup_mcif,
> .enable_mcif = mmhubbub2_enable_mcif,
> .disable_mcif = mmhubbub2_disable_mcif,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static
2022-10-19 13:27 ` Harry Wentland
@ 2022-10-20 13:11 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2022-10-20 13:11 UTC (permalink / raw)
To: Harry Wentland
Cc: ruanjinjie, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, jiapeng.chong,
aurabindo.pillai, isabbasso, amd-gfx, dri-devel, linux-kernel
Applied. Thanks!
Alex
On Wed, Oct 19, 2022 at 9:27 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2022-10-19 02:31, ruanjinjie wrote:
> > The symbol is not used outside of the file, so mark it static.
> >
> > Fixes the following warning:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:214:28:
> > warning: symbol 'dcn32_mmhubbub_funcs' was
> > not declared. Should it be static?
> >
> > Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> > index 41b0baf8e183..c3b089ba511a 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mmhubbub.c
> > @@ -211,7 +211,7 @@ static void mmhubbub32_config_mcif_arb(struct mcif_wb *mcif_wb,
> > REG_UPDATE(MCIF_WB_ARBITRATION_CONTROL, MCIF_WB_CLIENT_ARBITRATION_SLICE, params->arbitration_slice);
> > }
> >
> > -const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> > +static const struct mcif_wb_funcs dcn32_mmhubbub_funcs = {
> > .warmup_mcif = mmhubbub32_warmup_mcif,
> > .enable_mcif = mmhubbub2_enable_mcif,
> > .disable_mcif = mmhubbub2_disable_mcif,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-20 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 6:31 [PATCH -next] drm/amd/display: make dcn32_mmhubbub_funcs static ruanjinjie
2022-10-19 13:27 ` Harry Wentland
2022-10-20 13:11 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).