* [PATCH] drm/amd: Remove null check before kfree
@ 2017-08-29 13:21 Himanshu Jha
2017-08-29 13:28 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Himanshu Jha @ 2017-08-29 13:21 UTC (permalink / raw)
To: airlied
Cc: alexander.deucher, christian.koenig, amd-gfx, dri-devel,
linux-kernel, Himanshu Jha
Kfree on NULL pointer is a no-op and therefore checking is redundant.
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 6 ++----
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
index 8d1cf2d..f51b41f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
@@ -346,10 +346,8 @@ static void amdgpu_connector_free_edid(struct drm_connector *connector)
{
struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
- if (amdgpu_connector->edid) {
- kfree(amdgpu_connector->edid);
- amdgpu_connector->edid = NULL;
- }
+ kfree(amdgpu_connector->edid);
+ amdgpu_connector->edid = NULL;
}
static int amdgpu_connector_ddc_get_modes(struct drm_connector *connector)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
index 76347ff..00075c2 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
@@ -606,10 +606,8 @@ int smu7_init(struct pp_smumgr *smumgr)
int smu7_smu_fini(struct pp_smumgr *smumgr)
{
- if (smumgr->backend) {
- kfree(smumgr->backend);
- smumgr->backend = NULL;
- }
+ kfree(smumgr->backend);
+ smumgr->backend = NULL;
cgs_rel_firmware(smumgr->device, CGS_UCODE_ID_SMU);
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd: Remove null check before kfree
2017-08-29 13:21 [PATCH] drm/amd: Remove null check before kfree Himanshu Jha
@ 2017-08-29 13:28 ` Christian König
2017-08-29 19:43 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2017-08-29 13:28 UTC (permalink / raw)
To: Himanshu Jha, airlied; +Cc: alexander.deucher, amd-gfx, dri-devel, linux-kernel
Am 29.08.2017 um 15:21 schrieb Himanshu Jha:
> Kfree on NULL pointer is a no-op and therefore checking is redundant.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 6 ++----
> drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 6 ++----
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> index 8d1cf2d..f51b41f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> @@ -346,10 +346,8 @@ static void amdgpu_connector_free_edid(struct drm_connector *connector)
> {
> struct amdgpu_connector *amdgpu_connector = to_amdgpu_connector(connector);
>
> - if (amdgpu_connector->edid) {
> - kfree(amdgpu_connector->edid);
> - amdgpu_connector->edid = NULL;
> - }
> + kfree(amdgpu_connector->edid);
> + amdgpu_connector->edid = NULL;
> }
>
> static int amdgpu_connector_ddc_get_modes(struct drm_connector *connector)
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
> index 76347ff..00075c2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
> @@ -606,10 +606,8 @@ int smu7_init(struct pp_smumgr *smumgr)
>
> int smu7_smu_fini(struct pp_smumgr *smumgr)
> {
> - if (smumgr->backend) {
> - kfree(smumgr->backend);
> - smumgr->backend = NULL;
> - }
> + kfree(smumgr->backend);
> + smumgr->backend = NULL;
> cgs_rel_firmware(smumgr->device, CGS_UCODE_ID_SMU);
> return 0;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd: Remove null check before kfree
2017-08-29 13:28 ` Christian König
@ 2017-08-29 19:43 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2017-08-29 19:43 UTC (permalink / raw)
To: Christian König
Cc: Himanshu Jha, Dave Airlie, Deucher, Alexander,
Maling list - DRI developers, amd-gfx list, LKML
On Tue, Aug 29, 2017 at 9:28 AM, Christian König
<christian.koenig@amd.com> wrote:
> Am 29.08.2017 um 15:21 schrieb Himanshu Jha:
>>
>> Kfree on NULL pointer is a no-op and therefore checking is redundant.
>>
>> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
Applied. thanks!
Alex
>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 6 ++----
>> drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 6 ++----
>> 2 files changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>> index 8d1cf2d..f51b41f 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>> @@ -346,10 +346,8 @@ static void amdgpu_connector_free_edid(struct
>> drm_connector *connector)
>> {
>> struct amdgpu_connector *amdgpu_connector =
>> to_amdgpu_connector(connector);
>> - if (amdgpu_connector->edid) {
>> - kfree(amdgpu_connector->edid);
>> - amdgpu_connector->edid = NULL;
>> - }
>> + kfree(amdgpu_connector->edid);
>> + amdgpu_connector->edid = NULL;
>> }
>> static int amdgpu_connector_ddc_get_modes(struct drm_connector
>> *connector)
>> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
>> b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
>> index 76347ff..00075c2 100644
>> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
>> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
>> @@ -606,10 +606,8 @@ int smu7_init(struct pp_smumgr *smumgr)
>> int smu7_smu_fini(struct pp_smumgr *smumgr)
>> {
>> - if (smumgr->backend) {
>> - kfree(smumgr->backend);
>> - smumgr->backend = NULL;
>> - }
>> + kfree(smumgr->backend);
>> + smumgr->backend = NULL;
>> cgs_rel_firmware(smumgr->device, CGS_UCODE_ID_SMU);
>> return 0;
>> }
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-29 19:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-29 13:21 [PATCH] drm/amd: Remove null check before kfree Himanshu Jha
2017-08-29 13:28 ` Christian König
2017-08-29 19:43 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).