* [PATCH] drm/amd/powerplay: fix struct init in renoir_print_clk_levels
@ 2019-11-05 22:58 Raul E Rangel
2019-11-06 17:20 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Raul E Rangel @ 2019-11-05 22:58 UTC (permalink / raw)
To: alexander.deucher
Cc: Raul E Rangel, David Airlie, David (ChunMing) Zhou, Rex Zhu,
linux-kernel, dri-devel, amd-gfx, Christian König,
Evan Quan, Daniel Vetter
drivers/gpu/drm/amd/powerplay/renoir_ppt.c:186:2: error: missing braces
around initializer [-Werror=missing-braces]
SmuMetrics_t metrics = {0};
^
Fixes: 8b8031703bd7 ("drm/amd/powerplay: implement sysfs for getting dpm clock")
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
---
drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
index e62bfba51562..e5283dafc414 100644
--- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
@@ -183,11 +183,13 @@ static int renoir_print_clk_levels(struct smu_context *smu,
int i, size = 0, ret = 0;
uint32_t cur_value = 0, value = 0, count = 0, min = 0, max = 0;
DpmClocks_t *clk_table = smu->smu_table.clocks_table;
- SmuMetrics_t metrics = {0};
+ SmuMetrics_t metrics;
if (!clk_table || clk_type >= SMU_CLK_COUNT)
return -EINVAL;
+ memset(&metrics, 0, sizeof(metrics));
+
ret = smu_update_table(smu, SMU_TABLE_SMU_METRICS, 0,
(void *)&metrics, false);
if (ret)
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/powerplay: fix struct init in renoir_print_clk_levels
2019-11-05 22:58 [PATCH] drm/amd/powerplay: fix struct init in renoir_print_clk_levels Raul E Rangel
@ 2019-11-06 17:20 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2019-11-06 17:20 UTC (permalink / raw)
To: Raul E Rangel
Cc: Deucher, Alexander, David (ChunMing) Zhou, David Airlie, LKML,
Maling list - DRI developers, amd-gfx list, Daniel Vetter,
Evan Quan, Rex Zhu, Christian König
On Tue, Nov 5, 2019 at 6:10 PM Raul E Rangel <rrangel@chromium.org> wrote:
>
> drivers/gpu/drm/amd/powerplay/renoir_ppt.c:186:2: error: missing braces
> around initializer [-Werror=missing-braces]
> SmuMetrics_t metrics = {0};
> ^
>
> Fixes: 8b8031703bd7 ("drm/amd/powerplay: implement sysfs for getting dpm clock")
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Applied. thanks!
Alex
> ---
>
> drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index e62bfba51562..e5283dafc414 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -183,11 +183,13 @@ static int renoir_print_clk_levels(struct smu_context *smu,
> int i, size = 0, ret = 0;
> uint32_t cur_value = 0, value = 0, count = 0, min = 0, max = 0;
> DpmClocks_t *clk_table = smu->smu_table.clocks_table;
> - SmuMetrics_t metrics = {0};
> + SmuMetrics_t metrics;
>
> if (!clk_table || clk_type >= SMU_CLK_COUNT)
> return -EINVAL;
>
> + memset(&metrics, 0, sizeof(metrics));
> +
> ret = smu_update_table(smu, SMU_TABLE_SMU_METRICS, 0,
> (void *)&metrics, false);
> if (ret)
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-06 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 22:58 [PATCH] drm/amd/powerplay: fix struct init in renoir_print_clk_levels Raul E Rangel
2019-11-06 17:20 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).