From: Alex Deucher <alexdeucher@gmail.com>
To: Harry Wentland <hwentlan@amd.com>
Cc: Chen Zhou <chenzhou10@huawei.com>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/display: remove unnecessary conversion to bool
Date: Fri, 10 Jan 2020 19:17:16 -0500 [thread overview]
Message-ID: <CADnq5_OXHwj=acC7SWg9_gBpennTU7Rqa5VKrafJAJYYFnaWzw@mail.gmail.com> (raw)
In-Reply-To: <b86d050a-634e-c99d-1302-29fd6257df1c@amd.com>
Applied. thanks!
On Fri, Jan 10, 2020 at 4:41 PM Harry Wentland <hwentlan@amd.com> wrote:
>
> On 2020-01-10 2:16 a.m., Chen Zhou wrote:
> > The conversion to bool is not needed, remove it.
> >> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > index 504055f..a004e8e 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > @@ -2792,7 +2792,7 @@ static bool retrieve_link_cap(struct dc_link *link)
> > dpcd_data[DP_TRAINING_AUX_RD_INTERVAL];
> >
> > link->dpcd_caps.ext_receiver_cap_field_present =
> > - aux_rd_interval.bits.EXT_RECEIVER_CAP_FIELD_PRESENT == 1 ? true:false;
> > + aux_rd_interval.bits.EXT_RECEIVER_CAP_FIELD_PRESENT == 1;
> >
> > if (aux_rd_interval.bits.EXT_RECEIVER_CAP_FIELD_PRESENT == 1) {
> > uint8_t ext_cap_data[16];
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-11 0:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 7:16 [PATCH] drm/amd/display: remove unnecessary conversion to bool Chen Zhou
2020-01-10 21:41 ` Harry Wentland
2020-01-11 0:17 ` Alex Deucher [this message]
2021-02-20 7:40 [PATCH] drm/amd/display: Remove " Jiapeng Chong
2021-02-23 6:13 Jiapeng Chong
2021-02-23 16:02 ` Alex Deucher
2021-02-25 9:19 [PATCH] drm/amd/display: remove " Jiapeng Chong
2021-02-25 21:30 ` Alex Deucher
2021-03-01 6:49 [PATCH] drm/amd/display: Remove " Jiapeng Chong
2021-03-02 18:21 ` Alex Deucher
2021-03-05 6:40 Jiapeng Chong
2021-03-05 19:14 ` Alex Deucher
2021-03-08 3:00 Jiapeng Chong
2021-03-08 21:56 ` Alex Deucher
2021-03-09 8:02 Jiapeng Chong
2021-03-15 8:22 Jiapeng Chong
2021-03-15 18:27 ` Alex Deucher
2021-03-16 8:08 Jiapeng Chong
2021-03-18 3:09 ` Alex Deucher
2021-03-18 2:36 Jiapeng Chong
2021-03-18 3:11 ` Alex Deucher
2021-03-22 2:22 Jiapeng Chong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_OXHwj=acC7SWg9_gBpennTU7Rqa5VKrafJAJYYFnaWzw@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chenzhou10@huawei.com \
--cc=hwentlan@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).