* [PATCH] gpu/drm/radeon: Fix spelling typo in comments
@ 2022-04-29 1:51 pengfuyuan
2022-04-29 15:21 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: pengfuyuan @ 2022-04-29 1:51 UTC (permalink / raw)
To: Alex Deucher
Cc: christian.koenig, Xinhui.Pan, David Airlie, Daniel Vetter,
amd-gfx, dri-devel, linux-kernel, pengfuyuan
Fix spelling typo in comments.
Signed-off-by: pengfuyuan <pengfuyuan@kylinos.cn>
---
drivers/gpu/drm/radeon/atombios.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/radeon/atombios.h b/drivers/gpu/drm/radeon/atombios.h
index bd5dc09e860f..da35a970fcc0 100644
--- a/drivers/gpu/drm/radeon/atombios.h
+++ b/drivers/gpu/drm/radeon/atombios.h
@@ -3599,7 +3599,7 @@ typedef struct _ATOM_LCD_RTS_RECORD
UCHAR ucRTSValue;
}ATOM_LCD_RTS_RECORD;
-//!! If the record below exits, it shoud always be the first record for easy use in command table!!!
+//!! If the record below exists, it should always be the first record for easy use in command table!!!
// The record below is only used when LVDS_Info is present. From ATOM_LVDS_INFO_V12, use ucLCDPanel_SpecialHandlingCap instead.
typedef struct _ATOM_LCD_MODE_CONTROL_CAP
{
@@ -3823,7 +3823,7 @@ typedef struct _ATOM_DPCD_INFO
// Note1: This table is filled by SetBiosReservationStartInFB in CoreCommSubs.asm
// at running time.
// note2: From RV770, the memory is more than 32bit addressable, so we will change
-// ucTableFormatRevision=1,ucTableContentRevision=4, the strcuture remains
+// ucTableFormatRevision=1,ucTableContentRevision=4, the structure remains
// exactly same as 1.1 and 1.2 (1.3 is never in use), but ulStartAddrUsedByFirmware
// (in offset to start of memory address) is KB aligned instead of byte aligend.
/***********************************************************************************/
@@ -3858,7 +3858,7 @@ typedef struct _ATOM_VRAM_USAGE_BY_FIRMWARE
ATOM_FIRMWARE_VRAM_RESERVE_INFO asFirmwareVramReserveInfo[ATOM_MAX_FIRMWARE_VRAM_USAGE_INFO];
}ATOM_VRAM_USAGE_BY_FIRMWARE;
-// change verion to 1.5, when allow driver to allocate the vram area for command table access.
+// change version to 1.5, when allow driver to allocate the vram area for command table access.
typedef struct _ATOM_FIRMWARE_VRAM_RESERVE_INFO_V1_5
{
ULONG ulStartAddrUsedByFirmware;
@@ -5973,7 +5973,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3
#define CLEAR_ATOM_S7_DOS_8BIT_DAC_EN ((ATOM_DOS_MODE_INFO_DEF << 8 )|ATOM_S7_DOS_8BIT_DAC_EN_SHIFT | ATOM_FLAG_CLEAR )
/****************************************************************************/
-//Portion II: Definitinos only used in Driver
+//Portion II: Definitions only used in Driver
/****************************************************************************/
// Macros used by driver
@@ -7162,7 +7162,7 @@ typedef struct _DP_ENCODER_SERVICE_PARAMETERS
// ucAction
#define ATOM_DP_ACTION_GET_SINK_TYPE 0x01
-/* obselete */
+/* obsolete */
#define ATOM_DP_ACTION_TRAINING_START 0x02
#define ATOM_DP_ACTION_TRAINING_COMPLETE 0x03
#define ATOM_DP_ACTION_TRAINING_PATTERN_SEL 0x04
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gpu/drm/radeon: Fix spelling typo in comments
2022-04-29 1:51 [PATCH] gpu/drm/radeon: Fix spelling typo in comments pengfuyuan
@ 2022-04-29 15:21 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2022-04-29 15:21 UTC (permalink / raw)
To: pengfuyuan
Cc: Alex Deucher, David Airlie, xinhui pan, LKML,
Maling list - DRI developers, amd-gfx list, Daniel Vetter,
Christian Koenig
Applied. Thanks!
On Fri, Apr 29, 2022 at 9:04 AM pengfuyuan <pengfuyuan@kylinos.cn> wrote:
>
> Fix spelling typo in comments.
>
> Signed-off-by: pengfuyuan <pengfuyuan@kylinos.cn>
> ---
> drivers/gpu/drm/radeon/atombios.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios.h b/drivers/gpu/drm/radeon/atombios.h
> index bd5dc09e860f..da35a970fcc0 100644
> --- a/drivers/gpu/drm/radeon/atombios.h
> +++ b/drivers/gpu/drm/radeon/atombios.h
> @@ -3599,7 +3599,7 @@ typedef struct _ATOM_LCD_RTS_RECORD
> UCHAR ucRTSValue;
> }ATOM_LCD_RTS_RECORD;
>
> -//!! If the record below exits, it shoud always be the first record for easy use in command table!!!
> +//!! If the record below exists, it should always be the first record for easy use in command table!!!
> // The record below is only used when LVDS_Info is present. From ATOM_LVDS_INFO_V12, use ucLCDPanel_SpecialHandlingCap instead.
> typedef struct _ATOM_LCD_MODE_CONTROL_CAP
> {
> @@ -3823,7 +3823,7 @@ typedef struct _ATOM_DPCD_INFO
> // Note1: This table is filled by SetBiosReservationStartInFB in CoreCommSubs.asm
> // at running time.
> // note2: From RV770, the memory is more than 32bit addressable, so we will change
> -// ucTableFormatRevision=1,ucTableContentRevision=4, the strcuture remains
> +// ucTableFormatRevision=1,ucTableContentRevision=4, the structure remains
> // exactly same as 1.1 and 1.2 (1.3 is never in use), but ulStartAddrUsedByFirmware
> // (in offset to start of memory address) is KB aligned instead of byte aligend.
> /***********************************************************************************/
> @@ -3858,7 +3858,7 @@ typedef struct _ATOM_VRAM_USAGE_BY_FIRMWARE
> ATOM_FIRMWARE_VRAM_RESERVE_INFO asFirmwareVramReserveInfo[ATOM_MAX_FIRMWARE_VRAM_USAGE_INFO];
> }ATOM_VRAM_USAGE_BY_FIRMWARE;
>
> -// change verion to 1.5, when allow driver to allocate the vram area for command table access.
> +// change version to 1.5, when allow driver to allocate the vram area for command table access.
> typedef struct _ATOM_FIRMWARE_VRAM_RESERVE_INFO_V1_5
> {
> ULONG ulStartAddrUsedByFirmware;
> @@ -5973,7 +5973,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3
> #define CLEAR_ATOM_S7_DOS_8BIT_DAC_EN ((ATOM_DOS_MODE_INFO_DEF << 8 )|ATOM_S7_DOS_8BIT_DAC_EN_SHIFT | ATOM_FLAG_CLEAR )
>
> /****************************************************************************/
> -//Portion II: Definitinos only used in Driver
> +//Portion II: Definitions only used in Driver
> /****************************************************************************/
>
> // Macros used by driver
> @@ -7162,7 +7162,7 @@ typedef struct _DP_ENCODER_SERVICE_PARAMETERS
>
> // ucAction
> #define ATOM_DP_ACTION_GET_SINK_TYPE 0x01
> -/* obselete */
> +/* obsolete */
> #define ATOM_DP_ACTION_TRAINING_START 0x02
> #define ATOM_DP_ACTION_TRAINING_COMPLETE 0x03
> #define ATOM_DP_ACTION_TRAINING_PATTERN_SEL 0x04
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpu/drm/radeon: Fix spelling typo in comments
2022-04-28 7:20 pengfuyuan
@ 2022-04-28 18:19 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2022-04-28 18:19 UTC (permalink / raw)
To: pengfuyuan
Cc: Alex Deucher, David Airlie, xinhui pan, LKML,
Maling list - DRI developers, amd-gfx list, Christian Koenig
On Thu, Apr 28, 2022 at 3:37 AM pengfuyuan <pengfuyuan@kylinos.cn> wrote:
>
> Fix spelling typo in comments.
>
> Signed-off-by: pengfuyuan <pengfuyuan@kylinos.cn>
> ---
> drivers/gpu/drm/radeon/atombios.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios.h b/drivers/gpu/drm/radeon/atombios.h
> index bd5dc09e860f..e00d6adf7262 100644
> --- a/drivers/gpu/drm/radeon/atombios.h
> +++ b/drivers/gpu/drm/radeon/atombios.h
> @@ -3599,7 +3599,7 @@ typedef struct _ATOM_LCD_RTS_RECORD
> UCHAR ucRTSValue;
> }ATOM_LCD_RTS_RECORD;
>
> -//!! If the record below exits, it shoud always be the first record for easy use in command table!!!
> +//!! If the record below exits, it should always be the first record for easy use in command table!!!
s/exits/exists/
Other than that, it looks good to me.
Alex
> // The record below is only used when LVDS_Info is present. From ATOM_LVDS_INFO_V12, use ucLCDPanel_SpecialHandlingCap instead.
> typedef struct _ATOM_LCD_MODE_CONTROL_CAP
> {
> @@ -3823,7 +3823,7 @@ typedef struct _ATOM_DPCD_INFO
> // Note1: This table is filled by SetBiosReservationStartInFB in CoreCommSubs.asm
> // at running time.
> // note2: From RV770, the memory is more than 32bit addressable, so we will change
> -// ucTableFormatRevision=1,ucTableContentRevision=4, the strcuture remains
> +// ucTableFormatRevision=1,ucTableContentRevision=4, the structure remains
> // exactly same as 1.1 and 1.2 (1.3 is never in use), but ulStartAddrUsedByFirmware
> // (in offset to start of memory address) is KB aligned instead of byte aligend.
> /***********************************************************************************/
> @@ -3858,7 +3858,7 @@ typedef struct _ATOM_VRAM_USAGE_BY_FIRMWARE
> ATOM_FIRMWARE_VRAM_RESERVE_INFO asFirmwareVramReserveInfo[ATOM_MAX_FIRMWARE_VRAM_USAGE_INFO];
> }ATOM_VRAM_USAGE_BY_FIRMWARE;
>
> -// change verion to 1.5, when allow driver to allocate the vram area for command table access.
> +// change version to 1.5, when allow driver to allocate the vram area for command table access.
> typedef struct _ATOM_FIRMWARE_VRAM_RESERVE_INFO_V1_5
> {
> ULONG ulStartAddrUsedByFirmware;
> @@ -5973,7 +5973,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3
> #define CLEAR_ATOM_S7_DOS_8BIT_DAC_EN ((ATOM_DOS_MODE_INFO_DEF << 8 )|ATOM_S7_DOS_8BIT_DAC_EN_SHIFT | ATOM_FLAG_CLEAR )
>
> /****************************************************************************/
> -//Portion II: Definitinos only used in Driver
> +//Portion II: Definitions only used in Driver
> /****************************************************************************/
>
> // Macros used by driver
> @@ -7162,7 +7162,7 @@ typedef struct _DP_ENCODER_SERVICE_PARAMETERS
>
> // ucAction
> #define ATOM_DP_ACTION_GET_SINK_TYPE 0x01
> -/* obselete */
> +/* obsolete */
> #define ATOM_DP_ACTION_TRAINING_START 0x02
> #define ATOM_DP_ACTION_TRAINING_COMPLETE 0x03
> #define ATOM_DP_ACTION_TRAINING_PATTERN_SEL 0x04
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] gpu/drm/radeon: Fix spelling typo in comments
@ 2022-04-28 7:20 pengfuyuan
2022-04-28 18:19 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: pengfuyuan @ 2022-04-28 7:20 UTC (permalink / raw)
To: Alex Deucher
Cc: christian.koenig, Xinhui.Pan, David Airlie, Daniel Vetter,
amd-gfx, dri-devel, linux-kernel, pengfuyuan
Fix spelling typo in comments.
Signed-off-by: pengfuyuan <pengfuyuan@kylinos.cn>
---
drivers/gpu/drm/radeon/atombios.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/radeon/atombios.h b/drivers/gpu/drm/radeon/atombios.h
index bd5dc09e860f..e00d6adf7262 100644
--- a/drivers/gpu/drm/radeon/atombios.h
+++ b/drivers/gpu/drm/radeon/atombios.h
@@ -3599,7 +3599,7 @@ typedef struct _ATOM_LCD_RTS_RECORD
UCHAR ucRTSValue;
}ATOM_LCD_RTS_RECORD;
-//!! If the record below exits, it shoud always be the first record for easy use in command table!!!
+//!! If the record below exits, it should always be the first record for easy use in command table!!!
// The record below is only used when LVDS_Info is present. From ATOM_LVDS_INFO_V12, use ucLCDPanel_SpecialHandlingCap instead.
typedef struct _ATOM_LCD_MODE_CONTROL_CAP
{
@@ -3823,7 +3823,7 @@ typedef struct _ATOM_DPCD_INFO
// Note1: This table is filled by SetBiosReservationStartInFB in CoreCommSubs.asm
// at running time.
// note2: From RV770, the memory is more than 32bit addressable, so we will change
-// ucTableFormatRevision=1,ucTableContentRevision=4, the strcuture remains
+// ucTableFormatRevision=1,ucTableContentRevision=4, the structure remains
// exactly same as 1.1 and 1.2 (1.3 is never in use), but ulStartAddrUsedByFirmware
// (in offset to start of memory address) is KB aligned instead of byte aligend.
/***********************************************************************************/
@@ -3858,7 +3858,7 @@ typedef struct _ATOM_VRAM_USAGE_BY_FIRMWARE
ATOM_FIRMWARE_VRAM_RESERVE_INFO asFirmwareVramReserveInfo[ATOM_MAX_FIRMWARE_VRAM_USAGE_INFO];
}ATOM_VRAM_USAGE_BY_FIRMWARE;
-// change verion to 1.5, when allow driver to allocate the vram area for command table access.
+// change version to 1.5, when allow driver to allocate the vram area for command table access.
typedef struct _ATOM_FIRMWARE_VRAM_RESERVE_INFO_V1_5
{
ULONG ulStartAddrUsedByFirmware;
@@ -5973,7 +5973,7 @@ typedef struct _ATOM_ASIC_INTERNAL_SS_INFO_V3
#define CLEAR_ATOM_S7_DOS_8BIT_DAC_EN ((ATOM_DOS_MODE_INFO_DEF << 8 )|ATOM_S7_DOS_8BIT_DAC_EN_SHIFT | ATOM_FLAG_CLEAR )
/****************************************************************************/
-//Portion II: Definitinos only used in Driver
+//Portion II: Definitions only used in Driver
/****************************************************************************/
// Macros used by driver
@@ -7162,7 +7162,7 @@ typedef struct _DP_ENCODER_SERVICE_PARAMETERS
// ucAction
#define ATOM_DP_ACTION_GET_SINK_TYPE 0x01
-/* obselete */
+/* obsolete */
#define ATOM_DP_ACTION_TRAINING_START 0x02
#define ATOM_DP_ACTION_TRAINING_COMPLETE 0x03
#define ATOM_DP_ACTION_TRAINING_PATTERN_SEL 0x04
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-29 15:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 1:51 [PATCH] gpu/drm/radeon: Fix spelling typo in comments pengfuyuan
2022-04-29 15:21 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2022-04-28 7:20 pengfuyuan
2022-04-28 18:19 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).