* [PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages
@ 2017-02-22 21:34 Lyude
2017-02-23 14:34 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Lyude @ 2017-02-22 21:34 UTC (permalink / raw)
To: xorg-driver-ati
Cc: Lyude, Alex Deucher, Christian König, David Airlie, amd-gfx,
dri-devel, linux-kernel
Aux transfers always fail with non-zero status flags when there's
nothing connected on the port, so we don't usually need to see all of
the debugging information from it. Also, we try reprobing a -lot-, so
without ratelimiting most of the kernel log is filled up with messages
from radeon_dp_aux_transfer_native.
Signed-off-by: Lyude <lyude@redhat.com>
---
drivers/gpu/drm/radeon/radeon_dp_auxch.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
index 474a8a18..12eac4e 100644
--- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c
+++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
@@ -168,7 +168,8 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
goto done;
}
if (tmp & AUX_RX_ERROR_FLAGS) {
- DRM_DEBUG_KMS("dp_aux_ch flags not zero: %08x\n", tmp);
+ DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n",
+ tmp);
ret = -EIO;
goto done;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages
2017-02-22 21:34 [PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages Lyude
@ 2017-02-23 14:34 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2017-02-23 14:34 UTC (permalink / raw)
To: Lyude
Cc: xorg-driver-ati, David Airlie, LKML,
Maling list - DRI developers, amd-gfx list, Alex Deucher,
Christian König
On Wed, Feb 22, 2017 at 4:34 PM, Lyude <lyude@redhat.com> wrote:
> Aux transfers always fail with non-zero status flags when there's
> nothing connected on the port, so we don't usually need to see all of
> the debugging information from it. Also, we try reprobing a -lot-, so
> without ratelimiting most of the kernel log is filled up with messages
> from radeon_dp_aux_transfer_native.
>
> Signed-off-by: Lyude <lyude@redhat.com>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/radeon/radeon_dp_auxch.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> index 474a8a18..12eac4e 100644
> --- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> +++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> @@ -168,7 +168,8 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
> goto done;
> }
> if (tmp & AUX_RX_ERROR_FLAGS) {
> - DRM_DEBUG_KMS("dp_aux_ch flags not zero: %08x\n", tmp);
> + DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n",
> + tmp);
> ret = -EIO;
> goto done;
> }
> --
> 2.9.3
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-23 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22 21:34 [PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages Lyude
2017-02-23 14:34 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).