linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs
       [not found] <DB5PR08MB096711F1A243B7E14ADFB1349C2C0@DB5PR08MB0967.eurprd08.prod.outlook.com>
@ 2017-03-16  2:07 ` Alex Deucher
  0 siblings, 0 replies; only message in thread
From: Alex Deucher @ 2017-03-16  2:07 UTC (permalink / raw)
  To: David Binderman
  Cc: alexander.deucher, christian.koenig, airlied, amd-gfx, dri-devel,
	linux-kernel

On Mon, Mar 6, 2017 at 4:40 AM, David Binderman <dcb314@hotmail.com> wrote:
>
> Hello there,
> 1
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1041] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1037]: (style) Same expression on both sides of '|'.
>
> Maybe the macro AMD_CG_SUPPORT_GFX_MGLS is used twice ?
>
> 2.
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1070] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1066]: (style) Same expression on both sides of '|'.
>
> Duplicate.
>
> In the same file:
>
> linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:792]: (style) Variable 'r' is assigned a value that is never used.
>
> Source code is
>
>     r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
>
>     return 0;

Thanks, patches sent.

Alex

>
> Regards
>
> David Binderman
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-16  2:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <DB5PR08MB096711F1A243B7E14ADFB1349C2C0@DB5PR08MB0967.eurprd08.prod.outlook.com>
2017-03-16  2:07 ` linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).