* [PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create
@ 2022-04-21 9:03 Miaoqian Lin
2022-04-21 14:22 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-04-21 9:03 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Laktyushkin Dmytro, Solomon Chiu, Stylon Wang, Victor Lu,
Ilya Bakoulin, Melissa Wen, Angus Wang, Fangzhi Zuo,
Isabella Basso, Bhawanpreet Lakha, amd-gfx, dri-devel,
linux-kernel
Cc: linmq006
When dcn20_clk_src_construct() fails, we need to release clk_src.
Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
index 3fe4bfbb98a0..faab59508d82 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
@@ -997,6 +997,7 @@ static struct clock_source *dcn21_clock_source_create(
return &clk_src->base;
}
+ kfree(clk_src);
BREAK_TO_DEBUGGER();
return NULL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create
2022-04-21 9:03 [PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create Miaoqian Lin
@ 2022-04-21 14:22 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2022-04-21 14:22 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Laktyushkin Dmytro, Solomon Chiu, Stylon Wang, Victor Lu,
Ilya Bakoulin, Melissa Wen, Angus Wang, Fangzhi Zuo,
Isabella Basso, Bhawanpreet Lakha, amd-gfx list,
Maling list - DRI developers, LKML
Applied. Thanks!
Alex
On Thu, Apr 21, 2022 at 5:03 AM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> When dcn20_clk_src_construct() fails, we need to release clk_src.
>
> Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index 3fe4bfbb98a0..faab59508d82 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -997,6 +997,7 @@ static struct clock_source *dcn21_clock_source_create(
> return &clk_src->base;
> }
>
> + kfree(clk_src);
> BREAK_TO_DEBUGGER();
> return NULL;
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-21 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 9:03 [PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create Miaoqian Lin
2022-04-21 14:22 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).