* [PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM
@ 2021-09-23 9:02 yipeng.chen
2021-09-23 12:56 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: yipeng.chen @ 2021-09-23 9:02 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
airlied, daniel, qingqing.zhuo, Aric.Cyr, Anson.Jacob, bindu.r,
martin.tsai, bing.guo, roy.chan, george.shen, joshua.aberback,
Ashley.Thomas2, Jing.Zhou, dale.zhao
Cc: amd-gfx, dri-devel, linux-kernel, Yipeng Chen (Jasber), Roman Li
From: "Yipeng Chen (Jasber)" <yipeng.chen@amd.com>
[Why]
Enabled ABM (level != 0) would raise short pluse irq DC_IRQ_SOURCE_HPD1RX
randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging
on EDP panel. After correcting CRC error, there is no need to send drm
hotplug event.
[How]
Returning false would skip doing hot-plug when handle_hpd_irq_psr_sink()
handled irq. Hot-plug process causes visible flicking on overlay.
Signed-off-by: Yipeng Chen (Jasber) <yipeng.chen@amd.com>
Reviewed-by: Roman Li <Roman.Li@amd.com>
Anthony Koo <Anthony.Koo@amd.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 1e4794e2825c..9b9fbe5e9bd4 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -3007,7 +3007,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
if (handle_hpd_irq_psr_sink(link))
/* PSR-related error was detected and handled */
- return true;
+ return false;
/* If PSR-related error handled, Main link may be off,
* so do not handle as a normal sink status change interrupt.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM
2021-09-23 9:02 [PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM yipeng.chen
@ 2021-09-23 12:56 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2021-09-23 12:56 UTC (permalink / raw)
To: yipeng.chen
Cc: Wentland, Harry, Leo (Sunpeng) Li, Deucher, Alexander,
Christian Koenig, Dave Airlie, Daniel Vetter, Qingqing Zhuo, Cyr,
Aric, Anson Jacob, Bindu Ramamurthy, Martin Tsai, bing.guo,
roy.chan, George Shen, Joshua Aberback, Ashley Thomas, Jing.Zhou,
dale.zhao, amd-gfx list, Maling list - DRI developers, LKML,
Roman Li
On Thu, Sep 23, 2021 at 5:03 AM <yipeng.chen@amd.com> wrote:
>
> From: "Yipeng Chen (Jasber)" <yipeng.chen@amd.com>
>
> [Why]
> Enabled ABM (level != 0) would raise short pluse irq DC_IRQ_SOURCE_HPD1RX
> randomly with PSR error LINK_CRC_ERROR. Actually there is no hot plugging
> on EDP panel. After correcting CRC error, there is no need to send drm
> hotplug event.
>
> [How]
> Returning false would skip doing hot-plug when handle_hpd_irq_psr_sink()
> handled irq. Hot-plug process causes visible flicking on overlay.
>
> Signed-off-by: Yipeng Chen (Jasber) <yipeng.chen@amd.com>
> Reviewed-by: Roman Li <Roman.Li@amd.com>
> Anthony Koo <Anthony.Koo@amd.com>
Each reviewer should be called out on a separate line E.g.,
Reviewed-by: Roman Li <Roman.Li@amd.com>
Reviewed-by: Anthony Koo <Anthony.Koo@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 1e4794e2825c..9b9fbe5e9bd4 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -3007,7 +3007,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd
>
> if (handle_hpd_irq_psr_sink(link))
> /* PSR-related error was detected and handled */
> - return true;
> + return false;
>
> /* If PSR-related error handled, Main link may be off,
> * so do not handle as a normal sink status change interrupt.
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-23 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 9:02 [PATCH] drm/amd/display: Fix randomly flicking on overlay with enabled ABM yipeng.chen
2021-09-23 12:56 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).