From: Gene Chen <gene.chen.richtek@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
cy_huang@richtek.com, Rob Herring <robh+dt@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Gene Chen <gene_chen@richtek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>, Dan Murphy <dmurphy@ti.com>,
Wilma.Wu@mediatek.com, benjamin.chao@mediatek.com,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
shufan_lee@richtek.com
Subject: Re: [PATCH v7 4/5] dt-bindings: leds: Add bindings for MT6360 LED
Date: Thu, 19 Nov 2020 09:41:48 +0800 [thread overview]
Message-ID: <CAE+NS34JXTtoHtapxLAHF35Ybxe=m41Sg4PEfQSpxzA1Hg091g@mail.gmail.com> (raw)
In-Reply-To: <20201118212502.GA1839537@bogus>
Rob Herring <robh@kernel.org> 於 2020年11月19日 週四 上午5:25寫道:
>
> On Wed, 18 Nov 2020 18:47:41 +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add bindings document for LED support on MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> > .../devicetree/bindings/leds/leds-mt6360.yaml | 164 +++++++++++++++++++++
> > 1 file changed, 164 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> >
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/leds/leds-mt6360.yaml:57:2: [warning] wrong indentation: expected 2 but found 1 (indentation)
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml: led-controller: led@3:color:0:0: 10 is greater than the maximum of 9
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.example.dt.yaml: led-controller: led@3:color:0:0: 10 is greater than the maximum of 9
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
>
>
ACK, I will add description to this patch by
“this patch depends on patch [PATCH v7 3/5] dt-bindings: leds: common:
Increase LED_COLOR_ID_* maximum size"
> See https://patchwork.ozlabs.org/patch/1402193
>
> The base for the patch is generally the last rc1. Any dependencies
> should be noted.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
next prev parent reply other threads:[~2020-11-19 1:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 10:47 [PATCH v7 0/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-11-18 10:47 ` [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Gene Chen
2020-11-18 13:32 ` kernel test robot
2020-11-19 22:29 ` Jacek Anaszewski
2020-11-23 3:20 ` Gene Chen
2020-11-23 21:06 ` Jacek Anaszewski
2020-11-24 6:08 ` Gene Chen
2020-11-24 21:15 ` Jacek Anaszewski
2020-11-18 10:47 ` [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions Gene Chen
2020-11-18 21:37 ` Pavel Machek
2020-11-19 2:20 ` Gene Chen
2020-11-19 7:44 ` Pavel Machek
2020-11-19 7:55 ` Gene Chen
2020-11-19 8:38 ` Pavel Machek
2020-11-19 21:03 ` Jacek Anaszewski
2020-11-19 21:57 ` Pavel Machek
2020-11-19 22:26 ` Jacek Anaszewski
2020-11-23 3:00 ` Gene Chen
2020-11-23 20:52 ` Jacek Anaszewski
2020-11-24 7:33 ` Gene Chen
2020-11-24 8:32 ` Gene Chen
2020-11-24 21:38 ` Jacek Anaszewski
2020-11-18 10:47 ` [PATCH v7 3/5] dt-bindings: leds: common: Increase LED_COLOR_ID_* maximum size Gene Chen
2020-11-18 10:47 ` [PATCH v7 4/5] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-11-18 21:25 ` Rob Herring
2020-11-19 1:41 ` Gene Chen [this message]
2020-11-18 10:47 ` [PATCH v7 5/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-11-19 22:55 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE+NS34JXTtoHtapxLAHF35Ybxe=m41Sg4PEfQSpxzA1Hg091g@mail.gmail.com' \
--to=gene.chen.richtek@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).