From: Pavel Machek <pavel@ucw.cz>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: jacek.anaszewski@gmail.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, dmurphy@ti.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, Wilma.Wu@mediatek.com,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions
Date: Wed, 18 Nov 2020 22:37:12 +0100 [thread overview]
Message-ID: <20201118213712.GA22371@amd> (raw)
In-Reply-To: <1605696462-391-3-git-send-email-gene.chen.richtek@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
Hi!
> From: Gene Chen <gene_chen@richtek.com>
>
> Add LED_COLOR_ID_MOONLIGHT definitions
Why is moonlight a color? Camera flashes are usually white, no?
At least it needs a comment...
Best regards,
Pavel
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> include/dt-bindings/leds/common.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index 52b619d..1409e9a 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -33,7 +33,8 @@
> #define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
> #define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color,
> so this would include RGBW and similar */
> -#define LED_COLOR_ID_MAX 10
> +#define LED_COLOR_ID_MOONLIGHT 10
> +#define LED_COLOR_ID_MAX 11
>
> /* Standard LED functions */
> /* Keyboard LEDs, usually it would be input4::capslock etc. */
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-11-18 21:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 10:47 [PATCH v7 0/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-11-18 10:47 ` [PATCH v7 1/5] leds: flash: Add flash registration with undefined CONFIG_LEDS_CLASS_FLASH Gene Chen
2020-11-18 13:32 ` kernel test robot
2020-11-19 22:29 ` Jacek Anaszewski
2020-11-23 3:20 ` Gene Chen
2020-11-23 21:06 ` Jacek Anaszewski
2020-11-24 6:08 ` Gene Chen
2020-11-24 21:15 ` Jacek Anaszewski
2020-11-18 10:47 ` [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions Gene Chen
2020-11-18 21:37 ` Pavel Machek [this message]
2020-11-19 2:20 ` Gene Chen
2020-11-19 7:44 ` Pavel Machek
2020-11-19 7:55 ` Gene Chen
2020-11-19 8:38 ` Pavel Machek
2020-11-19 21:03 ` Jacek Anaszewski
2020-11-19 21:57 ` Pavel Machek
2020-11-19 22:26 ` Jacek Anaszewski
2020-11-23 3:00 ` Gene Chen
2020-11-23 20:52 ` Jacek Anaszewski
2020-11-24 7:33 ` Gene Chen
2020-11-24 8:32 ` Gene Chen
2020-11-24 21:38 ` Jacek Anaszewski
2020-11-18 10:47 ` [PATCH v7 3/5] dt-bindings: leds: common: Increase LED_COLOR_ID_* maximum size Gene Chen
2020-11-18 10:47 ` [PATCH v7 4/5] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-11-18 21:25 ` Rob Herring
2020-11-19 1:41 ` Gene Chen
2020-11-18 10:47 ` [PATCH v7 5/5] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-11-19 22:55 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118213712.GA22371@amd \
--to=pavel@ucw.cz \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).