From: Yinghai Lu <yinghai@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"Ronciak, John" <john.ronciak@intel.com>,
"Penner, Miles J" <miles.j.penner@intel.com>,
Bruce Allan <bruce.w.allan@intel.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges
Date: Thu, 27 Jun 2013 10:27:59 -0700 [thread overview]
Message-ID: <CAE9FiQXBtWESyVREYL67r9F5wK6xLBzHG30aAaif-SscdXi9yQ@mail.gmail.com> (raw)
In-Reply-To: <CAErSpo4BCdgnUs8RzjugVWE4P7cTNGFOCdijjmUUb5suqw_-6A@mail.gmail.com>
On Thu, Jun 27, 2013 at 9:00 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Wed, Jun 26, 2013 at 5:56 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>> On Wed, Jun 26, 2013 at 3:55 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>> On Wed, Jun 26, 2013 at 4:31 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>>>> On Wed, Jun 26, 2013 at 3:26 PM, Yinghai Lu <yinghai@kernel.org> wrote:
>>>>> On Wed, Jun 26, 2013 at 3:18 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>>>>> On Tue, Jun 25, 2013 at 10:22 AM, Mika Westerberg
>>>>>> <mika.westerberg@linux.intel.com> wrote:
>>>>>>> Thunderbolt PCI-to-PCI bridges typically use BIOS "assisted" enumeration.
>>>>>>> This means that the BIOS will allocate bridge resources based on some
>>>>>>> assumptions of a maximum Thunderbolt chain. It also disables native PCIe
>>>>>>> hotplug of the root port where the Thunderbolt host router is connected.
>>>> ...
>>>> During acpi hotplug, firmare could do extra help for us like assign
>>>> some resources to pci device bars, so it is NOT "boot-time".
>>>
>>> Really? How can firmware assign BARs at hotplug-time? I mean,
>>> obviously firmware *can* write things to the BARs before giving the
>>> device to the OS, but how would it know what to write?
>>
>> should be acpi code, or SMI code or even BMC firmware via sideband.
>
> How would that code (ACPI code (by which I assume you mean AML), SMI
> code, BMC firmware) know what values to write to BARs? Is it reading
> the windows of upstream bridges from config space? Is it assuming the
> OS never changes the windows of bridges upstream from the Thunderbolt
> controller?
Kernel only try to change upstream bridge for pciehp during hot-add.
for acpiphp, because could have other devices already there before hot-add,
kernel does not try to expand the upstream bridge. size and assign only
to the new added devices.
>
>>> I assume the
>>> OS owns the address space, and it can change the upstream bridge
>>> windows or the BARs of another device on the bus at any time, subject
>>> to the OS's own issues as far as quiescing or unbinding drivers, etc.,
>>> but without coordinating with the BIOS.
>>
>> for thunderbolt or dock with acpiphp, then all children devices/bridges should
>> not have drivers loaded yet.
>
> I said "upstream bridge windows or ... another device on the bus,"
> i.e., I'm referring to devices other than the Thunderbolt controller.
> I assume the OS is free to change resource assignments for those
> non-Thunderbolt devices, and obviously those assignments affect what
> is available for Thunderbolt.
ok. that upstream one can not be touched from firmware.
next prev parent reply other threads:[~2013-06-27 17:28 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 16:22 [PATCH 0/6] Thunderbolt workarounds take 2 Mika Westerberg
2013-06-25 16:22 ` [PATCH 1/6] PCI: acpiphp: do not check for SLOT_ENABLED in enable_device() Mika Westerberg
2013-06-26 23:28 ` Bjorn Helgaas
2013-06-27 13:25 ` Kirill A. Shutemov
2013-06-28 9:51 ` Kirill A. Shutemov
2013-06-28 17:00 ` Bjorn Helgaas
2013-06-28 18:54 ` Rafael J. Wysocki
2013-07-01 9:32 ` Mika Westerberg
2013-07-01 14:01 ` Rafael J. Wysocki
2013-07-01 18:36 ` Mika Westerberg
2013-07-02 1:29 ` Rafael J. Wysocki
2013-07-02 16:40 ` Bjorn Helgaas
2013-07-02 20:29 ` Rafael J. Wysocki
2013-07-02 20:31 ` Mika Westerberg
2013-07-02 20:49 ` Rafael J. Wysocki
2013-06-25 16:22 ` [PATCH 2/6] PCI: acpiphp: enable_device(): rescan even if no new devices on slot Mika Westerberg
2013-06-26 23:37 ` Bjorn Helgaas
2013-06-27 13:02 ` Mika Westerberg
2013-06-27 16:32 ` Mika Westerberg
2013-06-27 16:50 ` Bjorn Helgaas
2013-06-27 16:54 ` Bjorn Helgaas
2013-06-27 1:20 ` Yinghai Lu
2013-06-27 13:04 ` Mika Westerberg
2013-06-25 16:22 ` [PATCH 3/6] PCI: introduce pci_trim_stale_devices() Mika Westerberg
2013-06-25 17:47 ` Andy Shevchenko
2013-06-25 17:56 ` Kirill A. Shutemov
2013-06-28 19:59 ` Rafael J. Wysocki
2013-06-25 16:22 ` [PATCH 4/6] PCI: acpiphp: check for new devices on enabled host Mika Westerberg
2013-06-25 18:04 ` Andy Shevchenko
2013-06-26 9:39 ` Kirill A. Shutemov
2013-06-27 19:05 ` Yinghai Lu
2013-06-28 9:33 ` Kirill A. Shutemov
2013-06-28 16:22 ` Yinghai Lu
2013-06-28 20:04 ` Rafael J. Wysocki
2013-06-25 16:22 ` [PATCH 5/6] PCI: acpiphp: look _RMV method a bit deeper in the hierarhcy Mika Westerberg
2013-06-25 18:15 ` Andy Shevchenko
2013-06-25 18:31 ` Mika Westerberg
2013-06-25 18:31 ` Andy Shevchenko
2013-06-25 18:51 ` Mika Westerberg
2013-06-25 19:30 ` Andy Shevchenko
2013-07-02 10:44 ` Kirill A. Shutemov
2013-07-02 17:09 ` Bjorn Helgaas
2013-07-02 17:45 ` Kirill A. Shutemov
2013-07-02 20:48 ` Rafael J. Wysocki
2013-07-02 20:40 ` Rafael J. Wysocki
2013-06-25 16:22 ` [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges Mika Westerberg
2013-06-25 21:15 ` Jesse Barnes
2013-06-26 12:17 ` Mika Westerberg
2013-06-26 15:04 ` Greg Kroah-Hartman
2013-06-26 20:59 ` Bjorn Helgaas
2013-06-26 22:15 ` Alex Williamson
2013-06-27 13:09 ` Mika Westerberg
2013-06-26 22:18 ` Bjorn Helgaas
2013-06-26 22:26 ` Yinghai Lu
2013-06-26 22:31 ` Yinghai Lu
2013-06-26 22:44 ` Rafael J. Wysocki
2013-06-26 22:38 ` Yinghai Lu
2013-06-26 22:55 ` Bjorn Helgaas
2013-06-26 23:56 ` Yinghai Lu
2013-06-27 16:00 ` Bjorn Helgaas
2013-06-27 17:27 ` Yinghai Lu [this message]
2013-06-27 13:58 ` Mika Westerberg
2013-06-27 13:54 ` Mika Westerberg
2013-06-27 16:27 ` Mika Westerberg
2013-06-27 17:18 ` Yinghai Lu
2013-06-25 23:24 ` [PATCH 0/6] Thunderbolt workarounds take 2 Rafael J. Wysocki
2013-06-26 7:25 ` Mika Westerberg
2013-06-26 12:45 ` Rafael J. Wysocki
2013-06-26 19:48 ` Bjorn Helgaas
2013-06-26 20:01 ` Rafael J. Wysocki
2013-06-26 19:55 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQXBtWESyVREYL67r9F5wK6xLBzHG30aAaif-SscdXi9yQ@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=bruce.w.allan@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=john.ronciak@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=miles.j.penner@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).