From: Evan Green <evgreen@chromium.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Joerg Roedel <joro@8bytes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@google.com>, Will Deacon <will.deacon@arm.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, Arnd Bergmann <arnd@arndb.de>,
yingjoe.chen@mediatek.com, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>
Subject: Re: [PATCH 11/13] iommu/mediatek: Use builtin_platform_driver
Date: Mon, 25 Feb 2019 15:56:29 -0800 [thread overview]
Message-ID: <CAE=gft4Z_C0NRmP0A_rnDzvB3txt3cGV=rvZhJOQZk_1qahiQQ@mail.gmail.com> (raw)
In-Reply-To: <1546318276-18993-12-git-send-email-yong.wu@mediatek.com>
On Mon, Dec 31, 2018 at 8:53 PM Yong Wu <yong.wu@mediatek.com> wrote:
>
> MediaTek IOMMU should wait for smi larb which need wait for the
> power domain(mtk-scpsys.c) and the multimedia ccf who both are
> module init. Thus, subsys_initcall for MediaTek IOMMU is not helpful.
> Switch to builtin_platform_driver.
>
> Meanwhile, the ".remove" can be removed. Move its content to
> ".shutdown".
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/iommu/mtk_iommu.c | 23 ++---------------------
> drivers/iommu/mtk_iommu_v1.c | 16 ++--------------
> 2 files changed, 4 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 735ae8d..2798b12 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -690,7 +690,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> return component_master_add_with_match(dev, &mtk_iommu_com_ops, match);
> }
>
> -static int mtk_iommu_remove(struct platform_device *pdev)
> +static void mtk_iommu_shutdown(struct platform_device *pdev)
> {
> struct mtk_iommu_data *data = platform_get_drvdata(pdev);
>
> @@ -703,12 +703,6 @@ static int mtk_iommu_remove(struct platform_device *pdev)
> clk_disable_unprepare(data->bclk);
> devm_free_irq(&pdev->dev, data->irq, data);
> component_master_del(&pdev->dev, &mtk_iommu_com_ops);
> - return 0;
> -}
> -
> -static void mtk_iommu_shutdown(struct platform_device *pdev)
> -{
> - mtk_iommu_remove(pdev);
Is there a reason all these things are happening in shutdown()? Don't
we normally just not clean things up and let the machine turn off?
Normally I'm a big advocate of proper symmetric teardown, so it hurts
a little to ask.
next prev parent reply other threads:[~2019-02-26 0:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 4:51 [PATCH 00/13] Clean up "mediatek,larb" after adding device_link Yong Wu
2019-01-01 4:51 ` [PATCH 01/13] dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW Yong Wu
2019-01-11 14:58 ` Rob Herring
2019-02-25 23:54 ` Evan Green
2019-01-01 4:51 ` [PATCH 02/13] driver core: Remove the link if there is no driver with AUTO flag Yong Wu
2019-02-25 23:53 ` Evan Green
2019-02-27 14:33 ` Yong Wu
2019-03-05 19:03 ` Evan Green
2019-03-12 14:21 ` Matthias Brugger
2019-03-12 23:17 ` Evan Green
2019-03-13 9:08 ` Yong Wu
2019-01-01 4:51 ` [PATCH 03/13] iommu/mediatek: Add probe_defer for smi-larb Yong Wu
2019-02-25 23:54 ` Evan Green
2019-02-27 14:33 ` Yong Wu
2019-03-05 19:02 ` Evan Green
2019-01-01 4:51 ` [PATCH 04/13] iommu/mediatek: Add device_link between the consumer and the larb devices Yong Wu
2019-02-25 23:54 ` Evan Green
2019-02-27 14:34 ` Yong Wu
2019-02-27 19:30 ` Robin Murphy
2019-03-13 9:11 ` Yong Wu
2019-01-01 4:51 ` [PATCH 05/13] memory: mtk-smi: Add device-link between smi-larb and smi-common Yong Wu
2019-02-25 23:54 ` Evan Green
2019-02-27 14:33 ` Yong Wu
2019-03-05 19:02 ` Evan Green
2019-01-01 4:51 ` [PATCH 06/13] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put Yong Wu
2019-02-25 23:55 ` Evan Green
2019-01-01 4:51 ` [PATCH 07/13] media: mtk-mdp: " Yong Wu
2019-02-25 23:55 ` Evan Green
2019-01-01 4:51 ` [PATCH 08/13] media: mtk-vcodec: " Yong Wu
2019-02-25 23:55 ` Evan Green
2019-01-01 4:51 ` [PATCH 09/13] drm/mediatek: " Yong Wu
2019-02-25 23:55 ` Evan Green
2019-01-01 4:51 ` [PATCH 10/13] memory: mtk-smi: " Yong Wu
2019-02-25 23:56 ` Evan Green
2019-01-01 4:51 ` [PATCH 11/13] iommu/mediatek: Use builtin_platform_driver Yong Wu
2019-02-25 23:56 ` Evan Green [this message]
2019-02-27 14:33 ` Yong Wu
2019-03-05 19:03 ` Evan Green
2019-01-01 4:51 ` [PATCH 12/13] arm: dts: mediatek: Get rid of mediatek,larb for MM nodes Yong Wu
2019-02-25 23:56 ` Evan Green
2019-01-01 4:51 ` [PATCH 13/13] arm64: " Yong Wu
2019-02-25 23:56 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft4Z_C0NRmP0A_rnDzvB3txt3cGV=rvZhJOQZk_1qahiQQ@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will.deacon@arm.com \
--cc=yingjoe.chen@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).