linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks
@ 2022-04-12  2:59 Surong Pang
  2022-04-12  5:14 ` Greg KH
  2022-04-21 16:41 ` Greg KH
  0 siblings, 2 replies; 4+ messages in thread
From: Surong Pang @ 2022-04-12  2:59 UTC (permalink / raw)
  To: mathias.nyman, gregkh; +Cc: linux-usb, linux-kernel

From: Surong Pang <surong.pang@unisoc.com>

To set xhci->quirks value according to "usb3-slow-suspend" property

Signed-off-by: Surong Pang <surong.pang@unisoc.com>
---
 drivers/usb/host/xhci-plat.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 649ffd861b44..6bc456bc6468 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
 		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
 			xhci->quirks |= XHCI_LPM_SUPPORT;
 
+		if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
+			xhci->quirks |= XHCI_SLOW_SUSPEND;
+
 		if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
 			xhci->quirks |= XHCI_BROKEN_PORT_PED;
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks
  2022-04-12  2:59 [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks Surong Pang
@ 2022-04-12  5:14 ` Greg KH
  2022-04-21 16:41 ` Greg KH
  1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2022-04-12  5:14 UTC (permalink / raw)
  To: Surong Pang; +Cc: mathias.nyman, linux-usb, linux-kernel

On Tue, Apr 12, 2022 at 10:59:52AM +0800, Surong Pang wrote:
> From: Surong Pang <surong.pang@unisoc.com>
> 
> To set xhci->quirks value according to "usb3-slow-suspend" property
> 
> Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> ---
>  drivers/usb/host/xhci-plat.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 649ffd861b44..6bc456bc6468 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
>  			xhci->quirks |= XHCI_LPM_SUPPORT;
>  
> +		if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
> +			xhci->quirks |= XHCI_SLOW_SUSPEND;

Where is that property documented?


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks
  2022-04-12  2:59 [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks Surong Pang
  2022-04-12  5:14 ` Greg KH
@ 2022-04-21 16:41 ` Greg KH
  2022-04-22  2:40   ` surong pang
  1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2022-04-21 16:41 UTC (permalink / raw)
  To: Surong Pang; +Cc: mathias.nyman, linux-usb, linux-kernel

On Tue, Apr 12, 2022 at 10:59:52AM +0800, Surong Pang wrote:
> From: Surong Pang <surong.pang@unisoc.com>
> 
> To set xhci->quirks value according to "usb3-slow-suspend" property
> 
> Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> ---
>  drivers/usb/host/xhci-plat.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 649ffd861b44..6bc456bc6468 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
>  		if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
>  			xhci->quirks |= XHCI_LPM_SUPPORT;
>  
> +		if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
> +			xhci->quirks |= XHCI_SLOW_SUSPEND;

Device properties need to be documented somewhere.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks
  2022-04-21 16:41 ` Greg KH
@ 2022-04-22  2:40   ` surong pang
  0 siblings, 0 replies; 4+ messages in thread
From: surong pang @ 2022-04-22  2:40 UTC (permalink / raw)
  To: Greg KH; +Cc: mathias.nyman, linux-usb, linux-kernel, Orson.Zhai, yunguo.wu

We need to abandon this patch.

Greg KH <gregkh@linuxfoundation.org> 于2022年4月22日周五 00:41写道:
>
> On Tue, Apr 12, 2022 at 10:59:52AM +0800, Surong Pang wrote:
> > From: Surong Pang <surong.pang@unisoc.com>
> >
> > To set xhci->quirks value according to "usb3-slow-suspend" property
> >
> > Signed-off-by: Surong Pang <surong.pang@unisoc.com>
> > ---
> >  drivers/usb/host/xhci-plat.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > index 649ffd861b44..6bc456bc6468 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> >               if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
> >                       xhci->quirks |= XHCI_LPM_SUPPORT;
> >
> > +             if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
> > +                     xhci->quirks |= XHCI_SLOW_SUSPEND;
>
> Device properties need to be documented somewhere.
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-04-22  2:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-12  2:59 [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks Surong Pang
2022-04-12  5:14 ` Greg KH
2022-04-21 16:41 ` Greg KH
2022-04-22  2:40   ` surong pang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).