From: Frank Lee <tiny.windzz@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] audit: remove some duplicated includes
Date: Tue, 27 Nov 2018 09:03:39 +0800 [thread overview]
Message-ID: <CAEExFWtbJaCJba7+ttOVw0V6Y7wSJ=8zVzNHKQJHuGuTgqQPYg@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhSjBTVXAXKiNsgPDJUCsxPnd3DJVA1pjSQqN0ct=RaxJg@mail.gmail.com>
On Tue, Nov 27, 2018 at 7:36 AM Paul Moore <paul@paul-moore.com> wrote:
>
> On Mon, Nov 26, 2018 at 9:51 AM Yangtao Li <tiny.windzz@gmail.com> wrote:
> >
> > audit.h and skbuff.h are included twice.It's unnecessary.
> > hence just remove them.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > kernel/audit.c | 3 ---
> > 1 file changed, 3 deletions(-)
>
> While there are two header files named audit.h, they are different
> files as one lives in include/linux/audit.h, the other in
> kernel/audit.h. Granted, kernel/audit.h does include the
> include/linux/audit.h file but it should be protected from multiple
> inclusion by the _LINUX_AUDIT_H_ definition.
>
> I currently prefer to keep both <linux/audit.h> and "audit.h" in
> audit.c to help make the dependencies explicit in audit.c itself.
Hi Paul:
How about fs.h and others?
MBR,
Yangtao
>
> > diff --git a/kernel/audit.c b/kernel/audit.c
> > index 2a8058764aa6..a677715891d0 100644
> > --- a/kernel/audit.c
> > +++ b/kernel/audit.c
> > @@ -62,11 +62,8 @@
> > #include <linux/pid.h>
> > #include <linux/slab.h>
> >
> > -#include <linux/audit.h>
> > -
> > #include <net/sock.h>
> > #include <net/netlink.h>
> > -#include <linux/skbuff.h>
> > #ifdef CONFIG_SECURITY
> > #include <linux/security.h>
> > #endif
> > --
> > 2.17.0
>
> --
> paul moore
> www.paul-moore.com
next prev parent reply other threads:[~2018-11-27 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 14:51 [PATCH] audit: remove some duplicated includes Yangtao Li
2018-11-26 23:35 ` Paul Moore
2018-11-27 1:03 ` Frank Lee [this message]
2018-11-27 22:19 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEExFWtbJaCJba7+ttOVw0V6Y7wSJ=8zVzNHKQJHuGuTgqQPYg@mail.gmail.com' \
--to=tiny.windzz@gmail.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).