* [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h
@ 2023-12-23 5:11 Dipendra Khadka
2023-12-23 5:18 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Dipendra Khadka @ 2023-12-23 5:11 UTC (permalink / raw)
To: hdegoede, mchehab, sakari.ailus, gregkh, hpa
Cc: Dipendra Khadka, linux-media, linux-staging, linux-kernel,
linux-kernel-mentees
codespell reported spelling mistakes in
ia_css_acc_types.h as below:
'''
ia_css_acc_types.h:87: cummulative ==> cumulative
ia_css_acc_types.h:411: descibes ==> describes
'''
This patch fixes these spelling mistakes.
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
---
v2:
- Previously only corrected spelling mistake reported by checkpatch.pl.
- All spelling mistakes reported by codespell are fixed.
v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
index d6e52b4971d6..1dc2085ecd61 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
+++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
@@ -84,7 +84,7 @@ struct ia_css_blob_info {
memory_offsets; /** offset wrt hdr in bytes */
u32 prog_name_offset; /** offset wrt hdr in bytes */
u32 size; /** Size of blob */
- u32 padding_size; /** total cummulative of bytes added due to section alignment */
+ u32 padding_size; /** total cumulative of bytes added due to section alignment */
u32 icache_source; /** Position of icache in blob */
u32 icache_size; /** Size of icache section */
u32 icache_padding;/** bytes added due to icache section alignment */
@@ -408,7 +408,7 @@ struct ia_css_acc_sp {
};
/* Acceleration firmware descriptor.
- * This descriptor descibes either SP code (stand-alone), or
+ * This descriptor describes either SP code (stand-alone), or
* ISP code (a separate pipeline stage).
*/
struct ia_css_acc_fw_hdr {
--
2.39.2 (Apple Git-143)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h
2023-12-23 5:11 [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h Dipendra Khadka
@ 2023-12-23 5:18 ` Randy Dunlap
2023-12-23 5:29 ` Dipendra Khadka
2023-12-23 10:25 ` Hans de Goede
0 siblings, 2 replies; 6+ messages in thread
From: Randy Dunlap @ 2023-12-23 5:18 UTC (permalink / raw)
To: Dipendra Khadka, hdegoede, mchehab, sakari.ailus, gregkh, hpa
Cc: linux-media, linux-staging, linux-kernel, linux-kernel-mentees
Hi Dipendra,
On 12/22/23 21:11, Dipendra Khadka wrote:
> codespell reported spelling mistakes in
> ia_css_acc_types.h as below:
>
> '''
> ia_css_acc_types.h:87: cummulative ==> cumulative
> ia_css_acc_types.h:411: descibes ==> describes
> '''
>
> This patch fixes these spelling mistakes.
>
> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
This patch is an improvement so it could be merged as is IMO.
But...
> ---
> v2:
> - Previously only corrected spelling mistake reported by checkpatch.pl.
> - All spelling mistakes reported by codespell are fixed.
> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
>
> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> index d6e52b4971d6..1dc2085ecd61 100644
> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> @@ -84,7 +84,7 @@ struct ia_css_blob_info {
> memory_offsets; /** offset wrt hdr in bytes */
> u32 prog_name_offset; /** offset wrt hdr in bytes */
> u32 size; /** Size of blob */
> - u32 padding_size; /** total cummulative of bytes added due to section alignment */
> + u32 padding_size; /** total cumulative of bytes added due to section alignment */
I apologize for not looking at your v1 patch carefully.
The comment above would be much better as
/** total accumulation of bytes added due to section alignment */
And if the maintainer(s) want to take it as is:
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> u32 icache_source; /** Position of icache in blob */
> u32 icache_size; /** Size of icache section */
> u32 icache_padding;/** bytes added due to icache section alignment */
> @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
> };
>
> /* Acceleration firmware descriptor.
> - * This descriptor descibes either SP code (stand-alone), or
> + * This descriptor describes either SP code (stand-alone), or
> * ISP code (a separate pipeline stage).
> */
> struct ia_css_acc_fw_hdr {
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h
2023-12-23 5:18 ` Randy Dunlap
@ 2023-12-23 5:29 ` Dipendra Khadka
2023-12-23 5:32 ` Randy Dunlap
2023-12-23 10:25 ` Hans de Goede
1 sibling, 1 reply; 6+ messages in thread
From: Dipendra Khadka @ 2023-12-23 5:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: hdegoede, mchehab, sakari.ailus, gregkh, hpa, linux-media,
linux-staging, linux-kernel, linux-kernel-mentees
Hi Randy,
On Sat, 23 Dec 2023 at 11:03, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi Dipendra,
>
> On 12/22/23 21:11, Dipendra Khadka wrote:
> > codespell reported spelling mistakes in
> > ia_css_acc_types.h as below:
> >
> > '''
> > ia_css_acc_types.h:87: cummulative ==> cumulative
> > ia_css_acc_types.h:411: descibes ==> describes
> > '''
> >
> > This patch fixes these spelling mistakes.
> >
> > Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
>
> This patch is an improvement so it could be merged as is IMO.
> But...
>
> > ---
> > v2:
> > - Previously only corrected spelling mistake reported by checkpatch.pl.
> > - All spelling mistakes reported by codespell are fixed.
> > v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
> >
> > drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> > index d6e52b4971d6..1dc2085ecd61 100644
> > --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> > +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> > @@ -84,7 +84,7 @@ struct ia_css_blob_info {
> > memory_offsets; /** offset wrt hdr in bytes */
> > u32 prog_name_offset; /** offset wrt hdr in bytes */
> > u32 size; /** Size of blob */
> > - u32 padding_size; /** total cummulative of bytes added due to section alignment */
> > + u32 padding_size; /** total cumulative of bytes added due to section alignment */
>
> I apologize for not looking at your v1 patch carefully.
> The comment above would be much better as
>
> /** total accumulation of bytes added due to section alignment */
>
So, would you like me to change "cummulative" to accumulation or
should I wait what other maintainer(s) would say?
Thanks.
> And if the maintainer(s) want to take it as is:
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
>
> > u32 icache_source; /** Position of icache in blob */
> > u32 icache_size; /** Size of icache section */
> > u32 icache_padding;/** bytes added due to icache section alignment */
> > @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
> > };
> >
> > /* Acceleration firmware descriptor.
> > - * This descriptor descibes either SP code (stand-alone), or
> > + * This descriptor describes either SP code (stand-alone), or
> > * ISP code (a separate pipeline stage).
> > */
> > struct ia_css_acc_fw_hdr {
>
> --
> #Randy
> https://people.kernel.org/tglx/notes-about-netiquette
> https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h
2023-12-23 5:29 ` Dipendra Khadka
@ 2023-12-23 5:32 ` Randy Dunlap
0 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2023-12-23 5:32 UTC (permalink / raw)
To: Dipendra Khadka
Cc: hdegoede, mchehab, sakari.ailus, gregkh, hpa, linux-media,
linux-staging, linux-kernel, linux-kernel-mentees
On 12/22/23 21:29, Dipendra Khadka wrote:
> Hi Randy,
>
> On Sat, 23 Dec 2023 at 11:03, Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Hi Dipendra,
>>
>> On 12/22/23 21:11, Dipendra Khadka wrote:
>>> codespell reported spelling mistakes in
>>> ia_css_acc_types.h as below:
>>>
>>> '''
>>> ia_css_acc_types.h:87: cummulative ==> cumulative
>>> ia_css_acc_types.h:411: descibes ==> describes
>>> '''
>>>
>>> This patch fixes these spelling mistakes.
>>>
>>> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
>>
>> This patch is an improvement so it could be merged as is IMO.
>> But...
>>
>>> ---
>>> v2:
>>> - Previously only corrected spelling mistake reported by checkpatch.pl.
>>> - All spelling mistakes reported by codespell are fixed.
>>> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
>>>
>>> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>>> index d6e52b4971d6..1dc2085ecd61 100644
>>> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>>> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>>> @@ -84,7 +84,7 @@ struct ia_css_blob_info {
>>> memory_offsets; /** offset wrt hdr in bytes */
>>> u32 prog_name_offset; /** offset wrt hdr in bytes */
>>> u32 size; /** Size of blob */
>>> - u32 padding_size; /** total cummulative of bytes added due to section alignment */
>>> + u32 padding_size; /** total cumulative of bytes added due to section alignment */
>>
>> I apologize for not looking at your v1 patch carefully.
>> The comment above would be much better as
>>
>> /** total accumulation of bytes added due to section alignment */
>>
>
> So, would you like me to change "cummulative" to accumulation or
> should I wait what other maintainer(s) would say?
>
I think just wait for a few days to see what other review comments there are.
>
>> And if the maintainer(s) want to take it as is:
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>
>> Thanks.
>>
>>
>>> u32 icache_source; /** Position of icache in blob */
>>> u32 icache_size; /** Size of icache section */
>>> u32 icache_padding;/** bytes added due to icache section alignment */
>>> @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
>>> };
>>>
>>> /* Acceleration firmware descriptor.
>>> - * This descriptor descibes either SP code (stand-alone), or
>>> + * This descriptor describes either SP code (stand-alone), or
>>> * ISP code (a separate pipeline stage).
>>> */
>>> struct ia_css_acc_fw_hdr {
>>
>> --
>> #Randy
>> https://people.kernel.org/tglx/notes-about-netiquette
>> https://subspace.kernel.org/etiquette.html
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h
2023-12-23 5:18 ` Randy Dunlap
2023-12-23 5:29 ` Dipendra Khadka
@ 2023-12-23 10:25 ` Hans de Goede
2023-12-23 13:59 ` Dipendra Khadka
1 sibling, 1 reply; 6+ messages in thread
From: Hans de Goede @ 2023-12-23 10:25 UTC (permalink / raw)
To: Randy Dunlap, Dipendra Khadka, mchehab, sakari.ailus, gregkh, hpa
Cc: linux-media, linux-staging, linux-kernel, linux-kernel-mentees
Hi,
On 12/23/23 06:18, Randy Dunlap wrote:
> Hi Dipendra,
>
> On 12/22/23 21:11, Dipendra Khadka wrote:
>> codespell reported spelling mistakes in
>> ia_css_acc_types.h as below:
>>
>> '''
>> ia_css_acc_types.h:87: cummulative ==> cumulative
>> ia_css_acc_types.h:411: descibes ==> describes
>> '''
>>
>> This patch fixes these spelling mistakes.
>>
>> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
>
> This patch is an improvement so it could be merged as is IMO.
> But...
>
>> ---
>> v2:
>> - Previously only corrected spelling mistake reported by checkpatch.pl.
>> - All spelling mistakes reported by codespell are fixed.
>> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
>>
>> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>> index d6e52b4971d6..1dc2085ecd61 100644
>> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
>> @@ -84,7 +84,7 @@ struct ia_css_blob_info {
>> memory_offsets; /** offset wrt hdr in bytes */
>> u32 prog_name_offset; /** offset wrt hdr in bytes */
>> u32 size; /** Size of blob */
>> - u32 padding_size; /** total cummulative of bytes added due to section alignment */
>> + u32 padding_size; /** total cumulative of bytes added due to section alignment */
>
> I apologize for not looking at your v1 patch carefully.
> The comment above would be much better as
>
> /** total accumulation of bytes added due to section alignment */
I agree that that is better. Dipendra can you please send a v3
using the new text suggested by Randy ?
Regards,
Hans
>> u32 icache_source; /** Position of icache in blob */
>> u32 icache_size; /** Size of icache section */
>> u32 icache_padding;/** bytes added due to icache section alignment */
>> @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
>> };
>>
>> /* Acceleration firmware descriptor.
>> - * This descriptor descibes either SP code (stand-alone), or
>> + * This descriptor describes either SP code (stand-alone), or
>> * ISP code (a separate pipeline stage).
>> */
>> struct ia_css_acc_fw_hdr {
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h
2023-12-23 10:25 ` Hans de Goede
@ 2023-12-23 13:59 ` Dipendra Khadka
0 siblings, 0 replies; 6+ messages in thread
From: Dipendra Khadka @ 2023-12-23 13:59 UTC (permalink / raw)
To: Hans de Goede
Cc: Randy Dunlap, mchehab, sakari.ailus, gregkh, hpa, linux-media,
linux-staging, linux-kernel, linux-kernel-mentees
Hi,
On Sat, 23 Dec 2023 at 16:10, Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 12/23/23 06:18, Randy Dunlap wrote:
> > Hi Dipendra,
> >
> > On 12/22/23 21:11, Dipendra Khadka wrote:
> >> codespell reported spelling mistakes in
> >> ia_css_acc_types.h as below:
> >>
> >> '''
> >> ia_css_acc_types.h:87: cummulative ==> cumulative
> >> ia_css_acc_types.h:411: descibes ==> describes
> >> '''
> >>
> >> This patch fixes these spelling mistakes.
> >>
> >> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
> >
> > This patch is an improvement so it could be merged as is IMO.
> > But...
> >
> >> ---
> >> v2:
> >> - Previously only corrected spelling mistake reported by checkpatch.pl.
> >> - All spelling mistakes reported by codespell are fixed.
> >> v1: https://lore.kernel.org/lkml/20231222200350.2024-1-kdipendra88@gmail.com/
> >>
> >> drivers/staging/media/atomisp/pci/ia_css_acc_types.h | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> index d6e52b4971d6..1dc2085ecd61 100644
> >> --- a/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> +++ b/drivers/staging/media/atomisp/pci/ia_css_acc_types.h
> >> @@ -84,7 +84,7 @@ struct ia_css_blob_info {
> >> memory_offsets; /** offset wrt hdr in bytes */
> >> u32 prog_name_offset; /** offset wrt hdr in bytes */
> >> u32 size; /** Size of blob */
> >> - u32 padding_size; /** total cummulative of bytes added due to section alignment */
> >> + u32 padding_size; /** total cumulative of bytes added due to section alignment */
> >
> > I apologize for not looking at your v1 patch carefully.
> > The comment above would be much better as
> >
> > /** total accumulation of bytes added due to section alignment */
>
> I agree that that is better. Dipendra can you please send a v3
> using the new text suggested by Randy ?
Sure,let me send a v3 with the new text suggested by Randy.
Regards,
Dipendra
>
> Regards,
>
> Hans
>
>
>
> >> u32 icache_source; /** Position of icache in blob */
> >> u32 icache_size; /** Size of icache section */
> >> u32 icache_padding;/** bytes added due to icache section alignment */
> >> @@ -408,7 +408,7 @@ struct ia_css_acc_sp {
> >> };
> >>
> >> /* Acceleration firmware descriptor.
> >> - * This descriptor descibes either SP code (stand-alone), or
> >> + * This descriptor describes either SP code (stand-alone), or
> >> * ISP code (a separate pipeline stage).
> >> */
> >> struct ia_css_acc_fw_hdr {
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-23 13:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-23 5:11 [PATCH v2] staging: media: atomisp: pci: Fix spelling mistake in ia_css_acc_types.h Dipendra Khadka
2023-12-23 5:18 ` Randy Dunlap
2023-12-23 5:29 ` Dipendra Khadka
2023-12-23 5:32 ` Randy Dunlap
2023-12-23 10:25 ` Hans de Goede
2023-12-23 13:59 ` Dipendra Khadka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).