From: Joel Fernandes <joel@joelfernandes.org>
To: Christian Brauner <christian@brauner.io>
Cc: Jann Horn <jannh@google.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Andy Lutomirski <luto@kernel.org>,
David Howells <dhowells@redhat.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linux API <linux-api@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Glexiner <tglx@linutronix.de>,
Michael Kerrisk-manpages <mtk.manpages@gmail.com>,
Jonathan Kowalski <bl0pbl33p@gmail.com>,
"Dmitry V. Levin" <ldv@altlinux.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Nagarathnam Muthusamy <nagarathnam.muthusamy@oracle.com>,
Aleksa Sarai <cyphar@cyphar.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Daniel Colascione <dancol@google.com>
Subject: Re: [PATCH v1 2/4] pid: add pidctl()
Date: Tue, 26 Mar 2019 13:18:53 -0400 [thread overview]
Message-ID: <CAEXW_YRXDeJSJaSZBaCk=o+4Dhbq-WWzG=6OW4hDx5ynu7fgwg@mail.gmail.com> (raw)
In-Reply-To: <20190326171702.smehtebw4e656ehl@brauner.io>
On Tue, Mar 26, 2019 at 1:17 PM Christian Brauner <christian@brauner.io> wrote:
>
> On Tue, Mar 26, 2019 at 01:15:25PM -0400, Joel Fernandes wrote:
> > On Tue, Mar 26, 2019 at 06:08:28PM +0100, Christian Brauner wrote:
> > [snip]
> > > >
> > > > > +
> > > > > + if (!result)
> > > > > + result = -ENOENT;
> > > > > +
> > > > > + put_pid(struct_pid);
> > > >
> > > > so on error you would put_pid twice which seems odd.. I would suggest, don't
> > > > release the pid ref from within pidfd_create_fd, release the ref from the
> > > > caller. Speaking of which, I added to my list to convert the pid->count to
> > > > refcount_t at some point :)
> > >
> > > as i said, pidfd_create_fd takes its own reference
> >
> > Oh. That was easy to miss. Fair enough. I take that comment back.
> >
> > Please also reply to the other comments I posted, thanks. Generally on LKML,
> > I have seen there is an expectation to reply to all reviewer's review
> > comments even if you agree with them. This helps keep the review going
> > smoothly. Just my 2 cents.
>
> I tend to do it in multiple mails depending on whether or not I need to
> think about a comment or not.
Ok, that's also fine with me. thanks,
- Joel
next prev parent reply other threads:[~2019-03-26 17:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:55 [PATCH v1 0/4] pid: add pidctl() Christian Brauner
2019-03-26 15:55 ` [PATCH v1 1/4] Make anon_inodes unconditional Christian Brauner
2019-03-26 15:55 ` [PATCH v1 2/4] pid: add pidctl() Christian Brauner
2019-03-26 16:17 ` Daniel Colascione
2019-03-26 16:23 ` Christian Brauner
2019-03-26 16:31 ` Christian Brauner
2019-03-26 16:34 ` Christian Brauner
2019-03-26 16:38 ` Daniel Colascione
2019-03-26 16:43 ` Christian Brauner
2019-03-26 16:50 ` Daniel Colascione
2019-03-26 17:05 ` Christian Brauner
2019-03-26 16:42 ` Andy Lutomirski
2019-03-26 16:46 ` Christian Brauner
2019-03-26 17:00 ` Daniel Colascione
2019-03-26 16:33 ` Daniel Colascione
2019-03-26 17:06 ` Joel Fernandes
2019-03-26 17:08 ` Christian Brauner
2019-03-26 17:15 ` Joel Fernandes
2019-03-26 17:17 ` Christian Brauner
2019-03-26 17:18 ` Joel Fernandes [this message]
2019-03-26 17:22 ` Christian Brauner
2019-03-26 18:10 ` Joel Fernandes
2019-03-26 18:19 ` Christian Brauner
2019-03-26 18:47 ` Joel Fernandes
2019-03-26 19:19 ` Christian Brauner
2019-03-26 19:51 ` Joel Fernandes
2019-03-26 19:57 ` Christian Brauner
2019-03-26 15:55 ` [PATCH v1 3/4] signal: support pidctl() with pidfd_send_signal() Christian Brauner
2019-03-26 15:55 ` [PATCH v1 4/4] tests: add pidctl() tests Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEXW_YRXDeJSJaSZBaCk=o+4Dhbq-WWzG=6OW4hDx5ynu7fgwg@mail.gmail.com' \
--to=joel@joelfernandes.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bl0pbl33p@gmail.com \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dancol@google.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=ldv@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=nagarathnam.muthusamy@oracle.com \
--cc=oleg@redhat.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).