* [PATCH] net: ethernet: faraday: To support device tree usage.
@ 2016-11-16 8:43 Greentime Hu
2016-11-16 11:53 ` Jiri Pirko
2016-11-16 13:47 ` Andrew Lunn
0 siblings, 2 replies; 6+ messages in thread
From: Greentime Hu @ 2016-11-16 8:43 UTC (permalink / raw)
To: netdev, linux-kernel; +Cc: Greentime Hu
To support device tree usage for ftmac100.
Signed-off-by: Greentime Hu <green.hu@gmail.com>
---
drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
index dce5f7b..81dd9e1 100644
--- a/drivers/net/ethernet/faraday/ftmac100.c
+++ b/drivers/net/ethernet/faraday/ftmac100.c
@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
return 0;
}
+static const struct of_device_id mac_of_ids[] = {
+ { .compatible = "andestech,atmac100" },
+ { }
+};
+
static struct platform_driver ftmac100_driver = {
.probe = ftmac100_probe,
.remove = __exit_p(ftmac100_remove),
.driver = {
.name = DRV_NAME,
+ .of_match_table = mac_of_ids
},
};
@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
MODULE_AUTHOR("Po-Yu Chuang <ratbert@faraday-tech.com>");
MODULE_DESCRIPTION("FTMAC100 driver");
MODULE_LICENSE("GPL");
+MODULE_DEVICE_TABLE(of, mac_of_ids);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] net: ethernet: faraday: To support device tree usage.
2016-11-16 8:43 [PATCH] net: ethernet: faraday: To support device tree usage Greentime Hu
@ 2016-11-16 11:53 ` Jiri Pirko
2016-11-16 12:08 ` Greentime Hu
2016-11-16 13:47 ` Andrew Lunn
1 sibling, 1 reply; 6+ messages in thread
From: Jiri Pirko @ 2016-11-16 11:53 UTC (permalink / raw)
To: Greentime Hu; +Cc: netdev, linux-kernel
Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@gmail.com wrote:
>To support device tree usage for ftmac100.
>
>Signed-off-by: Greentime Hu <green.hu@gmail.com>
>---
> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
>index dce5f7b..81dd9e1 100644
>--- a/drivers/net/ethernet/faraday/ftmac100.c
>+++ b/drivers/net/ethernet/faraday/ftmac100.c
>@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
> return 0;
> }
>
>+static const struct of_device_id mac_of_ids[] = {
Prefix of everything in this file is "ftmac100", yet here, you use
"mac". I wonder why?!?
>+ { .compatible = "andestech,atmac100" },
>+ { }
>+};
>+
> static struct platform_driver ftmac100_driver = {
> .probe = ftmac100_probe,
> .remove = __exit_p(ftmac100_remove),
> .driver = {
> .name = DRV_NAME,
>+ .of_match_table = mac_of_ids
> },
> };
>
>@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
> MODULE_AUTHOR("Po-Yu Chuang <ratbert@faraday-tech.com>");
> MODULE_DESCRIPTION("FTMAC100 driver");
> MODULE_LICENSE("GPL");
>+MODULE_DEVICE_TABLE(of, mac_of_ids);
>--
>1.7.9.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: ethernet: faraday: To support device tree usage.
2016-11-16 11:53 ` Jiri Pirko
@ 2016-11-16 12:08 ` Greentime Hu
2016-11-16 12:16 ` Jiri Pirko
0 siblings, 1 reply; 6+ messages in thread
From: Greentime Hu @ 2016-11-16 12:08 UTC (permalink / raw)
To: Jiri Pirko; +Cc: netdev, linux-kernel
You are right. I didn't notice that. I should use ftmac100.
On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko <jiri@resnulli.us> wrote:
> Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@gmail.com wrote:
>>To support device tree usage for ftmac100.
>>
>>Signed-off-by: Greentime Hu <green.hu@gmail.com>
>>---
>> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>>diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
>>index dce5f7b..81dd9e1 100644
>>--- a/drivers/net/ethernet/faraday/ftmac100.c
>>+++ b/drivers/net/ethernet/faraday/ftmac100.c
>>@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>>+static const struct of_device_id mac_of_ids[] = {
>
> Prefix of everything in this file is "ftmac100", yet here, you use
> "mac". I wonder why?!?
>
>
>
>>+ { .compatible = "andestech,atmac100" },
>>+ { }
>>+};
>>+
>> static struct platform_driver ftmac100_driver = {
>> .probe = ftmac100_probe,
>> .remove = __exit_p(ftmac100_remove),
>> .driver = {
>> .name = DRV_NAME,
>>+ .of_match_table = mac_of_ids
>> },
>> };
>>
>>@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
>> MODULE_AUTHOR("Po-Yu Chuang <ratbert@faraday-tech.com>");
>> MODULE_DESCRIPTION("FTMAC100 driver");
>> MODULE_LICENSE("GPL");
>>+MODULE_DEVICE_TABLE(of, mac_of_ids);
>>--
>>1.7.9.5
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: ethernet: faraday: To support device tree usage.
2016-11-16 12:08 ` Greentime Hu
@ 2016-11-16 12:16 ` Jiri Pirko
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2016-11-16 12:16 UTC (permalink / raw)
To: Greentime Hu; +Cc: netdev, linux-kernel
Wed, Nov 16, 2016 at 01:08:57PM CET, green.hu@gmail.com wrote:
>You are right. I didn't notice that. I should use ftmac100.
Don't top-post please.
>
>On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@gmail.com wrote:
>>>To support device tree usage for ftmac100.
>>>
>>>Signed-off-by: Greentime Hu <green.hu@gmail.com>
>>>---
>>> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>>diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
>>>index dce5f7b..81dd9e1 100644
>>>--- a/drivers/net/ethernet/faraday/ftmac100.c
>>>+++ b/drivers/net/ethernet/faraday/ftmac100.c
>>>@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
>>> return 0;
>>> }
>>>
>>>+static const struct of_device_id mac_of_ids[] = {
>>
>> Prefix of everything in this file is "ftmac100", yet here, you use
>> "mac". I wonder why?!?
>>
>>
>>
>>>+ { .compatible = "andestech,atmac100" },
>>>+ { }
>>>+};
>>>+
>>> static struct platform_driver ftmac100_driver = {
>>> .probe = ftmac100_probe,
>>> .remove = __exit_p(ftmac100_remove),
>>> .driver = {
>>> .name = DRV_NAME,
>>>+ .of_match_table = mac_of_ids
>>> },
>>> };
>>>
>>>@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
>>> MODULE_AUTHOR("Po-Yu Chuang <ratbert@faraday-tech.com>");
>>> MODULE_DESCRIPTION("FTMAC100 driver");
>>> MODULE_LICENSE("GPL");
>>>+MODULE_DEVICE_TABLE(of, mac_of_ids);
>>>--
>>>1.7.9.5
>>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: ethernet: faraday: To support device tree usage.
2016-11-16 8:43 [PATCH] net: ethernet: faraday: To support device tree usage Greentime Hu
2016-11-16 11:53 ` Jiri Pirko
@ 2016-11-16 13:47 ` Andrew Lunn
2016-11-16 14:26 ` Greentime Hu
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2016-11-16 13:47 UTC (permalink / raw)
To: Greentime Hu; +Cc: netdev, linux-kernel
On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote:
> To support device tree usage for ftmac100.
>
> Signed-off-by: Greentime Hu <green.hu@gmail.com>
> ---
> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
> index dce5f7b..81dd9e1 100644
> --- a/drivers/net/ethernet/faraday/ftmac100.c
> +++ b/drivers/net/ethernet/faraday/ftmac100.c
> @@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id mac_of_ids[] = {
> + { .compatible = "andestech,atmac100" },
> + { }
andestech is not in
Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a
separate patch adding it.
Humm, why andestech? Why not something based around faraday
technology?
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: ethernet: faraday: To support device tree usage.
2016-11-16 13:47 ` Andrew Lunn
@ 2016-11-16 14:26 ` Greentime Hu
0 siblings, 0 replies; 6+ messages in thread
From: Greentime Hu @ 2016-11-16 14:26 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, linux-kernel
On Wed, Nov 16, 2016 at 9:47 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> On Wed, Nov 16, 2016 at 04:43:15PM +0800, Greentime Hu wrote:
>> To support device tree usage for ftmac100.
>>
>> Signed-off-by: Greentime Hu <green.hu@gmail.com>
>> ---
>> drivers/net/ethernet/faraday/ftmac100.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
>> index dce5f7b..81dd9e1 100644
>> --- a/drivers/net/ethernet/faraday/ftmac100.c
>> +++ b/drivers/net/ethernet/faraday/ftmac100.c
>> @@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
>> return 0;
>> }
>>
>> +static const struct of_device_id mac_of_ids[] = {
>> + { .compatible = "andestech,atmac100" },
>> + { }
>
> andestech is not in
> Documentation/devicetree/bindings/vendor-prefixes.txt Please provide a
> separate patch adding it.
OK. I will provide another patch to add andestech.
> Humm, why andestech? Why not something based around faraday
> technology?
It is because we use the same ftmac100 IP provided from faraday
technology but I am now using it in andestech SoC.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-16 14:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-16 8:43 [PATCH] net: ethernet: faraday: To support device tree usage Greentime Hu
2016-11-16 11:53 ` Jiri Pirko
2016-11-16 12:08 ` Greentime Hu
2016-11-16 12:16 ` Jiri Pirko
2016-11-16 13:47 ` Andrew Lunn
2016-11-16 14:26 ` Greentime Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).