linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Turner <mattst88@gmail.com>
To: Tom Li <biergaizi2009@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	linux-mips@vger.kernel.org, Paul Burton <paul.burton@mips.com>,
	LKML <linux-kernel@vger.kernel.org>, Yifeng Li <tomli@tomli.me>
Subject: Re: [PATCH 1/1] mfd: yeeloong_kb3310b: support KB3310B EC for Lemote Yeeloong laptops.
Date: Wed, 22 Jan 2020 16:22:53 -0800	[thread overview]
Message-ID: <CAEdQ38H-qRwcbcDVD_pEv9pGL33h=51kV3GYO87zSe9keZwT7A@mail.gmail.com> (raw)
In-Reply-To: <20190330081836.26942-2-biergaizi2009@gmail.com>

On Sat, Mar 30, 2019 at 1:19 AM Tom Li <biergaizi2009@gmail.com> wrote:
>
> From: Yifeng Li <tomli@tomli.me>
>
> Lemote Yeeloong is a laptop powered by Loongson 2F MIPS processor,
> primarily a demo platform for hobbyists and developers. It uses an
> ENE KB3310B Embedded Controller with customized firmware to implement
> hardware and power management.
>
> A monolithic platform driver code for those functionality has existed
> out-of-tree for many years. This commit creates a MFD driver for the EC
> chip on Yeeloong laptop to isolate EC-related code from core MIPS code,
> and serves as the foundation of various subdrivers.
>
> NOTE: A regmap could be the reasonable abstraction for I/O, but (1)
> it requires some additional refactoring to convert the shutdown/wakeup
> routines in board files to subdrivers, and (2) we're only using simple
> reads/writes, repmap only adds boilerplates to the existing files without
> additional benefits. We simply export the EC-related functions for now,
> until we come back to refactor the board files.
>
> Signed-off-by: Yifeng Li <tomli@tomli.me>

Did you give up on upstreaming this code? That would be a shame, and
somewhat ironic given that you were frustrated about lack of review,
etc, and then never responded to the review given :(

      parent reply	other threads:[~2020-01-23  0:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30  8:18 [PATCH 0/1] KB3310B MFD Driver for Lemote Yeeloong laptops Tom Li
2019-03-30  8:18 ` [PATCH 1/1] mfd: yeeloong_kb3310b: support KB3310B EC " Tom Li
2019-04-03  8:36   ` Lee Jones
2020-01-23  0:22   ` Matt Turner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEdQ38H-qRwcbcDVD_pEv9pGL33h=51kV3GYO87zSe9keZwT7A@mail.gmail.com' \
    --to=mattst88@gmail.com \
    --cc=biergaizi2009@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paul.burton@mips.com \
    --cc=tomli@tomli.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).