From: Djalal Harouni <tixxdz@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Lafcadio Wluiki <wluikil@gmail.com>
Subject: Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values
Date: Wed, 15 Feb 2017 09:56:06 +0100 [thread overview]
Message-ID: <CAEiveUd6Y0KLaS_kUBkX7c0q094AGxjcrVm_DDSoQJBuBJH+dw@mail.gmail.com> (raw)
In-Reply-To: <20170214163406.1ed8e7d707510d14137f1dd6@linux-foundation.org>
On Wed, Feb 15, 2017 at 1:34 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Mon, 13 Feb 2017 14:16:30 -0800 Kees Cook <keescook@chromium.org> wrote:
>
>> On Mon, Jan 16, 2017 at 5:23 AM, Djalal Harouni <tixxdz@gmail.com> wrote:
>> > From: Lafcadio Wluiki <wluikil@gmail.com>
>> >
>> > Previously, the hidepid parameter was checked by comparing literal
>> > integers 0, 1, 2. Let's add a proper enum for this, to make the checking
>> > more expressive:
>> >
>> > 0 ___ HIDEPID_OFF
>> > 1 ___ HIDEPID_NO_ACCESS
>> > 2 ___ HIDEPID_INVISIBLE
>> >
>> > This changes the internal labelling only, the userspace-facing interface
>> > remains unmodified, and still works with literal integers 0, 1, 2.
>> >
>> > No functional changes.
>> >
>> > Acked-by: Kees Cook <keescook@chromium.org>
>> > Acked-by: Djalal Harouni <tixxdz@gmail.com>
>> > Signed-off-by: Lafcadio Wluiki <wluikil@gmail.com>
>>
>> Andrew, can you take this? It's a sensible cleanup to drop literals in
>> favor of defines.
>
> Sure.
>
> Djalal, I converted your acked-by into a signed-off-by, as described in
> Documentation/SubmittingPatches (soon to become
> Documentation/process/submitting-patches.rst).
Thank you Andrew!
--
tixxdz
next prev parent reply other threads:[~2017-02-15 8:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:23 [PATCH v4 0/2] procfs/tasks: introduce per-task procfs hidepid= field Djalal Harouni
2017-01-16 13:23 ` [PATCH v4 1/2] procfs: use an enum for possible hidepid values Djalal Harouni
2017-02-13 22:16 ` Kees Cook
2017-02-15 0:34 ` Andrew Morton
2017-02-15 8:56 ` Djalal Harouni [this message]
2017-01-16 13:23 ` [PATCH v4 2/2] procfs/tasks: add a simple per-task procfs hidepid= field Djalal Harouni
2017-01-16 18:24 ` [kernel-hardening] " Daniel Micay
2017-01-17 9:54 ` Lafcadio Wluiki
[not found] ` <CAEiveUfDvSoW9Hy2Y_uxU2YQ+vR8OvXMqRhxAANTGG7QaQbJeg@mail.gmail.com>
[not found] ` <CALCETrWEGLhEHO_6sTXreVyWFVsEeYmZSrLNNXx-ma5gd+nTQQ@mail.gmail.com>
2017-01-18 22:50 ` Djalal Harouni
2017-01-18 23:35 ` Andy Lutomirski
2017-01-19 13:53 ` Djalal Harouni
2017-01-19 19:52 ` Andy Lutomirski
2017-01-20 15:56 ` Lafcadio Wluiki
2017-01-20 16:33 ` Djalal Harouni
2017-01-21 0:53 ` Andy Lutomirski
2017-01-23 11:46 ` Djalal Harouni
2017-01-23 20:07 ` Andy Lutomirski
2017-01-26 13:20 ` Djalal Harouni
2017-02-10 14:40 ` Lafcadio Wluiki
2017-02-10 16:18 ` Andy Lutomirski
2017-01-20 15:44 ` Lafcadio Wluiki
2017-02-10 23:44 ` Kees Cook
2017-02-13 19:01 ` Andy Lutomirski
2017-02-13 19:15 ` Kees Cook
2017-02-14 4:11 ` Christian Kujau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEiveUd6Y0KLaS_kUBkX7c0q094AGxjcrVm_DDSoQJBuBJH+dw@mail.gmail.com \
--to=tixxdz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wluikil@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).