* [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag
@ 2017-03-15 13:19 SeongJae Park
2017-03-23 1:09 ` SeongJae Park
0 siblings, 1 reply; 5+ messages in thread
From: SeongJae Park @ 2017-03-15 13:19 UTC (permalink / raw)
To: shuah; +Cc: wei.guo.simon, akpm, linux-kselftest, linux-kernel, SeongJae Park
Man page of mmap() says that portable applications should ensure fd
argument to be -1 if MAP_ANONYMOUS flag is set as below:
```
The mapping is not backed by any file; its contents are initialized to
zero. The fd and offset arguments are ignored; however, some
implementations require fd to be -1 if MAP_ANONYMOUS (or
MAP_ANON) is specified, and portable applications
should ensure this.
```
However, few mmap() calls under selftests/vm/ uses 0 as fd though they
use MAP_ANONYMOUS flag. This commit changes the argument to be -1 as
recommended.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/vm/map_hugetlb.c | 2 +-
tools/testing/selftests/vm/mlock2-tests.c | 12 ++++++------
tools/testing/selftests/vm/on-fault-limit.c | 2 +-
tools/testing/selftests/vm/thuge-gen.c | 2 +-
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/tools/testing/selftests/vm/map_hugetlb.c b/tools/testing/selftests/vm/map_hugetlb.c
index addcd6fc1ecc..77687ab59f77 100644
--- a/tools/testing/selftests/vm/map_hugetlb.c
+++ b/tools/testing/selftests/vm/map_hugetlb.c
@@ -62,7 +62,7 @@ int main(void)
void *addr;
int ret;
- addr = mmap(ADDR, LENGTH, PROTECTION, FLAGS, 0, 0);
+ addr = mmap(ADDR, LENGTH, PROTECTION, FLAGS, -1, 0);
if (addr == MAP_FAILED) {
perror("mmap");
exit(1);
diff --git a/tools/testing/selftests/vm/mlock2-tests.c b/tools/testing/selftests/vm/mlock2-tests.c
index ff0cda2b19c9..e5dbc87b4297 100644
--- a/tools/testing/selftests/vm/mlock2-tests.c
+++ b/tools/testing/selftests/vm/mlock2-tests.c
@@ -293,7 +293,7 @@ static int test_mlock_lock()
unsigned long page_size = getpagesize();
map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
- MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
+ MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
if (map == MAP_FAILED) {
perror("test_mlock_locked mmap");
goto out;
@@ -402,7 +402,7 @@ static int test_mlock_onfault()
unsigned long page_size = getpagesize();
map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
- MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
+ MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
if (map == MAP_FAILED) {
perror("test_mlock_locked mmap");
goto out;
@@ -445,7 +445,7 @@ static int test_lock_onfault_of_present()
uint64_t page1_flags, page2_flags;
map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
- MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
+ MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
if (map == MAP_FAILED) {
perror("test_mlock_locked mmap");
goto out;
@@ -492,7 +492,7 @@ static int test_munlockall()
unsigned long page_size = getpagesize();
map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
- MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
+ MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
if (map == MAP_FAILED) {
perror("test_munlockall mmap");
@@ -518,7 +518,7 @@ static int test_munlockall()
munmap(map, 2 * page_size);
map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
- MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
+ MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
if (map == MAP_FAILED) {
perror("test_munlockall second mmap");
@@ -573,7 +573,7 @@ static int test_vma_management(bool call_mlock)
struct vm_boundaries page3;
map = mmap(NULL, 3 * page_size, PROT_READ | PROT_WRITE,
- MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
+ MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
if (map == MAP_FAILED) {
perror("mmap()");
return ret;
diff --git a/tools/testing/selftests/vm/on-fault-limit.c b/tools/testing/selftests/vm/on-fault-limit.c
index 0ae458f32fdb..7f96a5c2e292 100644
--- a/tools/testing/selftests/vm/on-fault-limit.c
+++ b/tools/testing/selftests/vm/on-fault-limit.c
@@ -26,7 +26,7 @@ static int test_limit(void)
}
map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE,
- MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, 0, 0);
+ MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);
if (map != MAP_FAILED)
printf("mmap should have failed, but didn't\n");
else {
diff --git a/tools/testing/selftests/vm/thuge-gen.c b/tools/testing/selftests/vm/thuge-gen.c
index 0bc737a75150..88a2ab535e01 100644
--- a/tools/testing/selftests/vm/thuge-gen.c
+++ b/tools/testing/selftests/vm/thuge-gen.c
@@ -146,7 +146,7 @@ void test_mmap(unsigned long size, unsigned flags)
before = read_free(size);
map = mmap(NULL, size*NUM_PAGES, PROT_READ|PROT_WRITE,
- MAP_PRIVATE|MAP_ANONYMOUS|MAP_HUGETLB|flags, 0, 0);
+ MAP_PRIVATE|MAP_ANONYMOUS|MAP_HUGETLB|flags, -1, 0);
if (map == (char *)-1) err("mmap");
memset(map, 0xff, size*NUM_PAGES);
--
2.10.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag
2017-03-15 13:19 [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag SeongJae Park
@ 2017-03-23 1:09 ` SeongJae Park
2017-03-24 16:47 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: SeongJae Park @ 2017-03-23 1:09 UTC (permalink / raw)
To: shuah
Cc: Simon Guo, Andrew Morton, linux-kselftest, linux-kernel, SeongJae Park
Hello Shuah,
May I ask some comments?
Thanks,
SeongJae Park
On Wed, Mar 15, 2017 at 10:19 PM, SeongJae Park <sj38.park@gmail.com> wrote:
> Man page of mmap() says that portable applications should ensure fd
> argument to be -1 if MAP_ANONYMOUS flag is set as below:
> ```
> The mapping is not backed by any file; its contents are initialized to
> zero. The fd and offset arguments are ignored; however, some
> implementations require fd to be -1 if MAP_ANONYMOUS (or
> MAP_ANON) is specified, and portable applications
> should ensure this.
> ```
>
> However, few mmap() calls under selftests/vm/ uses 0 as fd though they
> use MAP_ANONYMOUS flag. This commit changes the argument to be -1 as
> recommended.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> ---
> tools/testing/selftests/vm/map_hugetlb.c | 2 +-
> tools/testing/selftests/vm/mlock2-tests.c | 12 ++++++------
> tools/testing/selftests/vm/on-fault-limit.c | 2 +-
> tools/testing/selftests/vm/thuge-gen.c | 2 +-
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/tools/testing/selftests/vm/map_hugetlb.c b/tools/testing/selftests/vm/map_hugetlb.c
> index addcd6fc1ecc..77687ab59f77 100644
> --- a/tools/testing/selftests/vm/map_hugetlb.c
> +++ b/tools/testing/selftests/vm/map_hugetlb.c
> @@ -62,7 +62,7 @@ int main(void)
> void *addr;
> int ret;
>
> - addr = mmap(ADDR, LENGTH, PROTECTION, FLAGS, 0, 0);
> + addr = mmap(ADDR, LENGTH, PROTECTION, FLAGS, -1, 0);
> if (addr == MAP_FAILED) {
> perror("mmap");
> exit(1);
> diff --git a/tools/testing/selftests/vm/mlock2-tests.c b/tools/testing/selftests/vm/mlock2-tests.c
> index ff0cda2b19c9..e5dbc87b4297 100644
> --- a/tools/testing/selftests/vm/mlock2-tests.c
> +++ b/tools/testing/selftests/vm/mlock2-tests.c
> @@ -293,7 +293,7 @@ static int test_mlock_lock()
> unsigned long page_size = getpagesize();
>
> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> if (map == MAP_FAILED) {
> perror("test_mlock_locked mmap");
> goto out;
> @@ -402,7 +402,7 @@ static int test_mlock_onfault()
> unsigned long page_size = getpagesize();
>
> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> if (map == MAP_FAILED) {
> perror("test_mlock_locked mmap");
> goto out;
> @@ -445,7 +445,7 @@ static int test_lock_onfault_of_present()
> uint64_t page1_flags, page2_flags;
>
> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> if (map == MAP_FAILED) {
> perror("test_mlock_locked mmap");
> goto out;
> @@ -492,7 +492,7 @@ static int test_munlockall()
> unsigned long page_size = getpagesize();
>
> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>
> if (map == MAP_FAILED) {
> perror("test_munlockall mmap");
> @@ -518,7 +518,7 @@ static int test_munlockall()
> munmap(map, 2 * page_size);
>
> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>
> if (map == MAP_FAILED) {
> perror("test_munlockall second mmap");
> @@ -573,7 +573,7 @@ static int test_vma_management(bool call_mlock)
> struct vm_boundaries page3;
>
> map = mmap(NULL, 3 * page_size, PROT_READ | PROT_WRITE,
> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
> if (map == MAP_FAILED) {
> perror("mmap()");
> return ret;
> diff --git a/tools/testing/selftests/vm/on-fault-limit.c b/tools/testing/selftests/vm/on-fault-limit.c
> index 0ae458f32fdb..7f96a5c2e292 100644
> --- a/tools/testing/selftests/vm/on-fault-limit.c
> +++ b/tools/testing/selftests/vm/on-fault-limit.c
> @@ -26,7 +26,7 @@ static int test_limit(void)
> }
>
> map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE,
> - MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, 0, 0);
> + MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);
> if (map != MAP_FAILED)
> printf("mmap should have failed, but didn't\n");
> else {
> diff --git a/tools/testing/selftests/vm/thuge-gen.c b/tools/testing/selftests/vm/thuge-gen.c
> index 0bc737a75150..88a2ab535e01 100644
> --- a/tools/testing/selftests/vm/thuge-gen.c
> +++ b/tools/testing/selftests/vm/thuge-gen.c
> @@ -146,7 +146,7 @@ void test_mmap(unsigned long size, unsigned flags)
>
> before = read_free(size);
> map = mmap(NULL, size*NUM_PAGES, PROT_READ|PROT_WRITE,
> - MAP_PRIVATE|MAP_ANONYMOUS|MAP_HUGETLB|flags, 0, 0);
> + MAP_PRIVATE|MAP_ANONYMOUS|MAP_HUGETLB|flags, -1, 0);
>
> if (map == (char *)-1) err("mmap");
> memset(map, 0xff, size*NUM_PAGES);
> --
> 2.10.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag
2017-03-23 1:09 ` SeongJae Park
@ 2017-03-24 16:47 ` Shuah Khan
2017-03-28 23:42 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2017-03-24 16:47 UTC (permalink / raw)
To: SeongJae Park, Andrew Morton
Cc: Simon Guo, linux-kselftest, linux-kernel, Shuah Khan, Shuah Khan
On 03/22/2017 07:09 PM, SeongJae Park wrote:
> Hello Shuah,
>
>
> May I ask some comments?
>
>
> Thanks,
> SeongJae Park
>
> On Wed, Mar 15, 2017 at 10:19 PM, SeongJae Park <sj38.park@gmail.com> wrote:
>> Man page of mmap() says that portable applications should ensure fd
>> argument to be -1 if MAP_ANONYMOUS flag is set as below:
>> ```
>> The mapping is not backed by any file; its contents are initialized to
>> zero. The fd and offset arguments are ignored; however, some
>> implementations require fd to be -1 if MAP_ANONYMOUS (or
>> MAP_ANON) is specified, and portable applications
>> should ensure this.
>> ```
>>
>> However, few mmap() calls under selftests/vm/ uses 0 as fd though they
>> use MAP_ANONYMOUS flag. This commit changes the argument to be -1 as
>> recommended.
Hi Andrew,
Do you have comments on this patch? Please Ack it if you would
like me to take it thorugh ksefltest tree.
thanks,
-- Shuah
>>
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>> ---
>> tools/testing/selftests/vm/map_hugetlb.c | 2 +-
>> tools/testing/selftests/vm/mlock2-tests.c | 12 ++++++------
>> tools/testing/selftests/vm/on-fault-limit.c | 2 +-
>> tools/testing/selftests/vm/thuge-gen.c | 2 +-
>> 4 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/testing/selftests/vm/map_hugetlb.c b/tools/testing/selftests/vm/map_hugetlb.c
>> index addcd6fc1ecc..77687ab59f77 100644
>> --- a/tools/testing/selftests/vm/map_hugetlb.c
>> +++ b/tools/testing/selftests/vm/map_hugetlb.c
>> @@ -62,7 +62,7 @@ int main(void)
>> void *addr;
>> int ret;
>>
>> - addr = mmap(ADDR, LENGTH, PROTECTION, FLAGS, 0, 0);
>> + addr = mmap(ADDR, LENGTH, PROTECTION, FLAGS, -1, 0);
>> if (addr == MAP_FAILED) {
>> perror("mmap");
>> exit(1);
>> diff --git a/tools/testing/selftests/vm/mlock2-tests.c b/tools/testing/selftests/vm/mlock2-tests.c
>> index ff0cda2b19c9..e5dbc87b4297 100644
>> --- a/tools/testing/selftests/vm/mlock2-tests.c
>> +++ b/tools/testing/selftests/vm/mlock2-tests.c
>> @@ -293,7 +293,7 @@ static int test_mlock_lock()
>> unsigned long page_size = getpagesize();
>>
>> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
>> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
>> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>> if (map == MAP_FAILED) {
>> perror("test_mlock_locked mmap");
>> goto out;
>> @@ -402,7 +402,7 @@ static int test_mlock_onfault()
>> unsigned long page_size = getpagesize();
>>
>> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
>> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
>> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>> if (map == MAP_FAILED) {
>> perror("test_mlock_locked mmap");
>> goto out;
>> @@ -445,7 +445,7 @@ static int test_lock_onfault_of_present()
>> uint64_t page1_flags, page2_flags;
>>
>> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
>> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
>> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>> if (map == MAP_FAILED) {
>> perror("test_mlock_locked mmap");
>> goto out;
>> @@ -492,7 +492,7 @@ static int test_munlockall()
>> unsigned long page_size = getpagesize();
>>
>> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
>> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
>> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>>
>> if (map == MAP_FAILED) {
>> perror("test_munlockall mmap");
>> @@ -518,7 +518,7 @@ static int test_munlockall()
>> munmap(map, 2 * page_size);
>>
>> map = mmap(NULL, 2 * page_size, PROT_READ | PROT_WRITE,
>> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
>> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>>
>> if (map == MAP_FAILED) {
>> perror("test_munlockall second mmap");
>> @@ -573,7 +573,7 @@ static int test_vma_management(bool call_mlock)
>> struct vm_boundaries page3;
>>
>> map = mmap(NULL, 3 * page_size, PROT_READ | PROT_WRITE,
>> - MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
>> + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
>> if (map == MAP_FAILED) {
>> perror("mmap()");
>> return ret;
>> diff --git a/tools/testing/selftests/vm/on-fault-limit.c b/tools/testing/selftests/vm/on-fault-limit.c
>> index 0ae458f32fdb..7f96a5c2e292 100644
>> --- a/tools/testing/selftests/vm/on-fault-limit.c
>> +++ b/tools/testing/selftests/vm/on-fault-limit.c
>> @@ -26,7 +26,7 @@ static int test_limit(void)
>> }
>>
>> map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE,
>> - MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, 0, 0);
>> + MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);
>> if (map != MAP_FAILED)
>> printf("mmap should have failed, but didn't\n");
>> else {
>> diff --git a/tools/testing/selftests/vm/thuge-gen.c b/tools/testing/selftests/vm/thuge-gen.c
>> index 0bc737a75150..88a2ab535e01 100644
>> --- a/tools/testing/selftests/vm/thuge-gen.c
>> +++ b/tools/testing/selftests/vm/thuge-gen.c
>> @@ -146,7 +146,7 @@ void test_mmap(unsigned long size, unsigned flags)
>>
>> before = read_free(size);
>> map = mmap(NULL, size*NUM_PAGES, PROT_READ|PROT_WRITE,
>> - MAP_PRIVATE|MAP_ANONYMOUS|MAP_HUGETLB|flags, 0, 0);
>> + MAP_PRIVATE|MAP_ANONYMOUS|MAP_HUGETLB|flags, -1, 0);
>>
>> if (map == (char *)-1) err("mmap");
>> memset(map, 0xff, size*NUM_PAGES);
>> --
>> 2.10.0
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag
2017-03-24 16:47 ` Shuah Khan
@ 2017-03-28 23:42 ` Andrew Morton
2017-04-13 17:37 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2017-03-28 23:42 UTC (permalink / raw)
To: shuah; +Cc: SeongJae Park, Simon Guo, linux-kselftest, linux-kernel, Shuah Khan
On Fri, 24 Mar 2017 10:47:55 -0600 Shuah Khan <shuah@kernel.org> wrote:
> > On Wed, Mar 15, 2017 at 10:19 PM, SeongJae Park <sj38.park@gmail.com> wrote:
> >> Man page of mmap() says that portable applications should ensure fd
> >> argument to be -1 if MAP_ANONYMOUS flag is set as below:
> >> ```
> >> The mapping is not backed by any file; its contents are initialized to
> >> zero. The fd and offset arguments are ignored; however, some
> >> implementations require fd to be -1 if MAP_ANONYMOUS (or
> >> MAP_ANON) is specified, and portable applications
> >> should ensure this.
> >> ```
> >>
> >> However, few mmap() calls under selftests/vm/ uses 0 as fd though they
> >> use MAP_ANONYMOUS flag. This commit changes the argument to be -1 as
> >> recommended.
>
> Hi Andrew,
>
> Do you have comments on this patch? Please Ack it if you would
> like me to take it thorugh ksefltest tree.
Acked-by: Andrew Morton <akpm@linux-foundation.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag
2017-03-28 23:42 ` Andrew Morton
@ 2017-04-13 17:37 ` Shuah Khan
0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2017-04-13 17:37 UTC (permalink / raw)
To: SeongJae Park
Cc: Andrew Morton, Simon Guo, linux-kselftest, linux-kernel, Shuah Khan
On 03/28/2017 05:42 PM, Andrew Morton wrote:
> On Fri, 24 Mar 2017 10:47:55 -0600 Shuah Khan <shuah@kernel.org> wrote:
>
>>> On Wed, Mar 15, 2017 at 10:19 PM, SeongJae Park <sj38.park@gmail.com> wrote:
>>>> Man page of mmap() says that portable applications should ensure fd
>>>> argument to be -1 if MAP_ANONYMOUS flag is set as below:
>>>> ```
>>>> The mapping is not backed by any file; its contents are initialized to
>>>> zero. The fd and offset arguments are ignored; however, some
>>>> implementations require fd to be -1 if MAP_ANONYMOUS (or
>>>> MAP_ANON) is specified, and portable applications
>>>> should ensure this.
>>>> ```
>>>>
>>>> However, few mmap() calls under selftests/vm/ uses 0 as fd though they
>>>> use MAP_ANONYMOUS flag. This commit changes the argument to be -1 as
>>>> recommended.
>>
>> Hi Andrew,
>>
>> Do you have comments on this patch? Please Ack it if you would
>> like me to take it thorugh ksefltest tree.
>
> Acked-by: Andrew Morton <akpm@linux-foundation.org>
>
>
Thanks. Applied to linux-kselftest next
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-13 17:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-15 13:19 [PATCH] selftests/vm: Set mmap()'s fd as -1 for MAP_ANONYMOUS flag SeongJae Park
2017-03-23 1:09 ` SeongJae Park
2017-03-24 16:47 ` Shuah Khan
2017-03-28 23:42 ` Andrew Morton
2017-04-13 17:37 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).