From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: peter enderborg <peter.enderborg@sony.com>
Cc: "Thiébaud Weksteen" <tweek@google.com>,
"Paul Moore" <paul@paul-moore.com>,
"Nick Kralevich" <nnk@google.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Eric Paris" <eparis@parisplace.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Rob Herring" <robh@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"SElinux list" <selinux@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] selinux: add permission names to trace event
Date: Tue, 18 Aug 2020 08:13:53 -0400 [thread overview]
Message-ID: <CAEjxPJ7k648nQxCDzcHc0h1vEfNhAJShG5iKmD52nuO5s9phsQ@mail.gmail.com> (raw)
In-Reply-To: <6730ec4a-d11b-5c05-b64f-380104a86dab@sony.com>
On Tue, Aug 18, 2020 at 4:11 AM peter enderborg
<peter.enderborg@sony.com> wrote:
>
> On 8/17/20 10:16 PM, Stephen Smalley wrote:
> > On 8/17/20 1:07 PM, Thiébaud Weksteen wrote:
> >
> >> From: Peter Enderborg <peter.enderborg@sony.com>
> >>
> >> In the print out add permissions, it will look like:
> >> <...>-1042 [007] .... 201.965142: selinux_audited:
> >> requested=0x4000000 denied=0x4000000 audited=0x4000000
> >> result=-13
> >> scontext=system_u:system_r:cupsd_t:s0-s0:c0.c1023
> >> tcontext=system_u:object_r:bin_t:s0
> >> tclass=file permissions={ !entrypoint }
> >>
> >> This patch is adding the "permissions={ !entrypoint }".
> >> The permissions preceded by "!" have been denied and the permissions
> >> without have been accepted.
> >>
> >> Note that permission filtering is done on the audited, denied or
> >> requested attributes.
> >>
> >> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> >> Suggested-by: Stephen Smalley <stephen.smalley.work@gmail.com>
> >> Reviewed-by: Thiébaud Weksteen <tweek@google.com>
> >> Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
> >> ---
> >> include/trace/events/avc.h | 11 +++++++++--
> >> security/selinux/avc.c | 36 ++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 45 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> >> index 7de5cc5169af..d585b68c2a50 100644
> >> --- a/security/selinux/avc.c
> >> +++ b/security/selinux/avc.c
> >> @@ -695,6 +695,7 @@ static void avc_audit_pre_callback(struct audit_buffer *ab, void *a)
> >> audit_log_format(ab, " } for ");
> >> }
> >> +
> >> /**
> >> * avc_audit_post_callback - SELinux specific information
> >> * will be called by generic audit code
> >
> > Also, drop the spurious whitespace change above.
> >
> >
> Is there any other things we need to fix? A part 1&2 now OK?
They looked ok to me, but Paul should review them.
next prev parent reply other threads:[~2020-08-18 12:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 17:07 [PATCH v3 0/3] selinux: add detailed tracepoint on audited events Thiébaud Weksteen
2020-08-17 17:07 ` [PATCH v3 1/3] selinux: add " Thiébaud Weksteen
2020-08-18 14:31 ` Stephen Smalley
2020-08-17 17:07 ` [PATCH v3 2/3] selinux: add basic filtering for audit trace events Thiébaud Weksteen
2020-08-18 14:36 ` Stephen Smalley
2020-08-17 17:07 ` [PATCH v3 3/3] selinux: add permission names to trace event Thiébaud Weksteen
2020-08-17 20:13 ` Stephen Smalley
2020-08-17 20:29 ` Steven Rostedt
2020-08-18 16:09 ` Steven Rostedt
2020-08-19 13:11 ` Stephen Smalley
2020-08-21 2:31 ` Steven Rostedt
2020-08-21 12:29 ` Stephen Smalley
2020-08-21 13:19 ` Paul Moore
2020-08-21 13:39 ` peter enderborg
[not found] ` <CA+zpnLfNjDwxgoG2p3W8YfXxYVQDum4Eh_MJQvKP4rGLqsqACA@mail.gmail.com>
2020-08-21 13:46 ` Paul Moore
2020-08-17 20:16 ` Stephen Smalley
2020-08-18 8:11 ` peter enderborg
2020-08-18 12:13 ` Stephen Smalley [this message]
2020-08-21 2:22 ` Paul Moore
2020-08-21 5:53 ` peter enderborg
2020-08-21 12:14 ` Stephen Smalley
2020-08-21 13:10 ` Paul Moore
[not found] ` <20200824132252.31261-1-peter.enderborg@sony.com>
2020-08-24 13:22 ` [RFC PATCH] selinux: Add denied trace with permssion filter Peter Enderborg
2020-08-26 13:42 ` Paul Moore
2020-08-26 14:34 ` peter enderborg
2020-08-26 14:45 ` Paul Moore
2020-08-26 15:06 ` peter enderborg
2020-08-27 13:30 ` Paul Moore
2020-08-27 14:04 ` peter enderborg
2020-08-31 14:16 ` Paul Moore
2020-08-31 14:19 ` Robert Judy
2020-08-31 14:24 ` Paul Moore
2020-08-31 15:34 ` peter enderborg
2020-09-01 15:31 ` Paul Moore
2020-09-01 17:18 ` peter enderborg
2020-09-18 1:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEjxPJ7k648nQxCDzcHc0h1vEfNhAJShG5iKmD52nuO5s9phsQ@mail.gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=davem@davemloft.net \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mingo@redhat.com \
--cc=nnk@google.com \
--cc=paul@paul-moore.com \
--cc=peter.enderborg@sony.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=selinux@vger.kernel.org \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).