From: Daniel Baluta <daniel.baluta@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Daniel Baluta <daniel.baluta@intel.com>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
irina.tirdea@intel.com
Subject: Re: [RFC PATCH 1/8] iio: dummy: Introduce virtual registers for dummy device
Date: Mon, 6 Oct 2014 14:17:11 +0300 [thread overview]
Message-ID: <CAEnQRZA2xbKFuftjtHib6cUkc+2G4KDaRfPfYXt9fwsV90xCEA@mail.gmail.com> (raw)
In-Reply-To: <542FECB4.5010001@kernel.org>
On Sat, Oct 4, 2014 at 3:48 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 02/10/14 14:43, Daniel Baluta wrote:
>> We need a way to store events generated by iio_dummy_evgen module,
>> in order to correctly process IRQs in iio_simple_dummy_events.
>>
>> For the moment, we add two registers:
>>
>> * id_reg - ID register, stores the source of the event
>> * id_data - DATA register, stores the type of the event
>>
>> e.g echo 4 > /sys/bus/iio/devices/iio_evgen/poke2
>>
>> id_reg 0x02, id_data 0x04
>>
>> This means, event of type 4 was generated by fake device 2.
>>
>> We currently use a hardcoded mapping of virtual events to IIO events.
>>
>> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
>> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Does the job and will look enough like a normal interrupt that
> it allows the dummy driver to act as example code.
Hi Jonathan,
Thanks for the reviews.
This patch is self contained and it could be merged
separately if you think it's stable enough.
We are going over your reviews for the other patches and will send v2
as soon as possible.
Daniel.
next prev parent reply other threads:[~2014-10-06 11:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 13:43 [RFC PATCH] iio: Introduce activity channel Daniel Baluta
2014-10-02 13:43 ` [RFC PATCH 1/8] iio: dummy: Introduce virtual registers for dummy device Daniel Baluta
2014-10-04 12:48 ` Jonathan Cameron
2014-10-06 11:17 ` Daniel Baluta [this message]
2014-10-09 19:28 ` Jonathan Cameron
2014-10-19 20:30 ` Hartmut Knaack
2014-10-19 20:39 ` Daniel Baluta
2014-10-02 13:43 ` [RFC PATCH 2/8] iio: core: Introduce IIO_ACTIVITY channel Daniel Baluta
2014-10-04 13:00 ` Jonathan Cameron
2014-10-02 13:43 ` [RFC PATCH 3/8] iio: core: Introduce new MOTION event Daniel Baluta
2014-10-04 13:12 ` Jonathan Cameron
2014-10-06 14:17 ` Daniel Baluta
2014-10-09 19:31 ` Jonathan Cameron
2014-10-11 9:47 ` Daniel Baluta
2014-10-13 9:46 ` Karol Wrona
2014-10-07 10:48 ` Daniel Baluta
2014-10-09 19:37 ` Jonathan Cameron
2014-10-02 13:43 ` [RFC PATCH 4/8] iio: core: Introduce pedometer STEP counter modifier Daniel Baluta
2014-10-04 12:53 ` Jonathan Cameron
2014-10-06 13:50 ` Tirdea, Irina
2014-10-06 16:31 ` Jonathan Cameron
2014-10-07 13:54 ` Tirdea, Irina
2014-10-02 13:43 ` [RFC PATCH 5/8] iio: core: Introduce ENABLE channel info mask Daniel Baluta
2014-10-02 13:43 ` [RFC PATCH 6/8] iio: core: Introduce new STEP_DETECT event Daniel Baluta
2014-10-04 12:56 ` Jonathan Cameron
2014-10-02 13:43 ` [RFC PATCH 7/8] iio: dummy: Demonstrate the usage of activity channel Daniel Baluta
2014-10-02 13:43 ` [RFC PATCH 8/8] iio: event_monitor: Add support for " Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEnQRZA2xbKFuftjtHib6cUkc+2G4KDaRfPfYXt9fwsV90xCEA@mail.gmail.com \
--to=daniel.baluta@intel.com \
--cc=irina.tirdea@intel.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).