linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: faraday: use %pap format string for printing resources
@ 2017-04-19 17:54 Arnd Bergmann
  2017-04-19 18:42 ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-04-19 17:54 UTC (permalink / raw)
  To: Bjorn Helgaas, Linus Walleij; +Cc: Arnd Bergmann, linux-pci, linux-kernel

resource_size_t may be either 32-bit or 64-bit wide, so we have to use
the special %pap format string to avoid warnings like:

drivers/pci/host/pci-ftpci100.c: In function 'faraday_res_to_memcfg':
drivers/pci/host/pci-ftpci100.c:174:586: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
drivers/pci/host/pci-ftpci100.c:174:586: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]

This relies on resource_size_t and phys_addr_t being the same width,
as other code already does.

Fixes: 5c18f2b240bd ("PCI: faraday: Add Faraday Technology FTPCI100 PCI Host Bridge driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pci/host/pci-ftpci100.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/host/pci-ftpci100.c b/drivers/pci/host/pci-ftpci100.c
index 4ae5418a1aad..c0f29d1de341 100644
--- a/drivers/pci/host/pci-ftpci100.c
+++ b/drivers/pci/host/pci-ftpci100.c
@@ -171,8 +171,8 @@ static int faraday_res_to_memcfg(resource_size_t mem_base,
 		pr_warn("truncated PCI memory base\n");
 	/* Translate to bridge side address space */
 	outval |= (mem_base & FARADAY_PCI_MEMBASE_MASK);
-	pr_debug("Translated pci base @%08x, size %08x to config %08x\n",
-		 mem_base, mem_size, outval);
+	pr_debug("Translated pci base @%pap, size %pap to config %08x\n",
+		 &mem_base, &mem_size, outval);
 
 	*val = outval;
 	return 0;
-- 
2.9.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: faraday: use %pap format string for printing resources
  2017-04-19 17:54 [PATCH] PCI: faraday: use %pap format string for printing resources Arnd Bergmann
@ 2017-04-19 18:42 ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2017-04-19 18:42 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Linus Walleij, linux-pci, linux-kernel

On Wed, Apr 19, 2017 at 12:54 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> resource_size_t may be either 32-bit or 64-bit wide, so we have to use
> the special %pap format string to avoid warnings like:
>
> drivers/pci/host/pci-ftpci100.c: In function 'faraday_res_to_memcfg':
> drivers/pci/host/pci-ftpci100.c:174:586: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> drivers/pci/host/pci-ftpci100.c:174:586: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>
> This relies on resource_size_t and phys_addr_t being the same width,
> as other code already does.
>
> Fixes: 5c18f2b240bd ("PCI: faraday: Add Faraday Technology FTPCI100 PCI Host Bridge driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, folded into the initial commit.

> ---
>  drivers/pci/host/pci-ftpci100.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-ftpci100.c b/drivers/pci/host/pci-ftpci100.c
> index 4ae5418a1aad..c0f29d1de341 100644
> --- a/drivers/pci/host/pci-ftpci100.c
> +++ b/drivers/pci/host/pci-ftpci100.c
> @@ -171,8 +171,8 @@ static int faraday_res_to_memcfg(resource_size_t mem_base,
>                 pr_warn("truncated PCI memory base\n");
>         /* Translate to bridge side address space */
>         outval |= (mem_base & FARADAY_PCI_MEMBASE_MASK);
> -       pr_debug("Translated pci base @%08x, size %08x to config %08x\n",
> -                mem_base, mem_size, outval);
> +       pr_debug("Translated pci base @%pap, size %pap to config %08x\n",
> +                &mem_base, &mem_size, outval);
>
>         *val = outval;
>         return 0;
> --
> 2.9.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-19 18:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 17:54 [PATCH] PCI: faraday: use %pap format string for printing resources Arnd Bergmann
2017-04-19 18:42 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).