* [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp_debug declaration
@ 2013-11-19 14:15 Mika Westerberg
2013-11-19 17:23 ` Bjorn Helgaas
0 siblings, 1 reply; 3+ messages in thread
From: Mika Westerberg @ 2013-11-19 14:15 UTC (permalink / raw)
To: linux-acpi
Cc: Rafael J. Wysocki, Bjorn Helgaas, linux-kernel, Mika Westerberg
Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users
of acpiphp_debug variable and the variable itself but the declaration was
left in the header file. Drop this unused declaration.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/pci/hotplug/acpiphp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
index 26100f510b10..1592dbe4f904 100644
--- a/drivers/pci/hotplug/acpiphp.h
+++ b/drivers/pci/hotplug/acpiphp.h
@@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot);
u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot);
/* variables */
-extern bool acpiphp_debug;
extern bool acpiphp_disabled;
#endif /* _ACPIPHP_H */
--
1.8.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp_debug declaration
2013-11-19 14:15 [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp_debug declaration Mika Westerberg
@ 2013-11-19 17:23 ` Bjorn Helgaas
2013-11-19 20:52 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2013-11-19 17:23 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-acpi, Rafael J. Wysocki, linux-kernel
On Tue, Nov 19, 2013 at 7:15 AM, Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users
> of acpiphp_debug variable and the variable itself but the declaration was
> left in the header file. Drop this unused declaration.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Rafael, if it makes sense for you to apply this, you can add my:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Otherwise I can pick it up.
> ---
> drivers/pci/hotplug/acpiphp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> index 26100f510b10..1592dbe4f904 100644
> --- a/drivers/pci/hotplug/acpiphp.h
> +++ b/drivers/pci/hotplug/acpiphp.h
> @@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot);
> u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot);
>
> /* variables */
> -extern bool acpiphp_debug;
> extern bool acpiphp_disabled;
>
> #endif /* _ACPIPHP_H */
> --
> 1.8.4.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp_debug declaration
2013-11-19 17:23 ` Bjorn Helgaas
@ 2013-11-19 20:52 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2013-11-19 20:52 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Mika Westerberg, linux-acpi, linux-kernel
On Tuesday, November 19, 2013 10:23:57 AM Bjorn Helgaas wrote:
> On Tue, Nov 19, 2013 at 7:15 AM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > Commit bd950799d951 (PCI: acpiphp: Convert to dynamic debug) removed users
> > of acpiphp_debug variable and the variable itself but the declaration was
> > left in the header file. Drop this unused declaration.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Rafael, if it makes sense for you to apply this, you can add my:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Otherwise I can pick it up.
Applied, thanks!
I'm going to send my next pull request tomorrow.
> > ---
> > drivers/pci/hotplug/acpiphp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> > index 26100f510b10..1592dbe4f904 100644
> > --- a/drivers/pci/hotplug/acpiphp.h
> > +++ b/drivers/pci/hotplug/acpiphp.h
> > @@ -176,7 +176,6 @@ u8 acpiphp_get_latch_status(struct acpiphp_slot *slot);
> > u8 acpiphp_get_adapter_status(struct acpiphp_slot *slot);
> >
> > /* variables */
> > -extern bool acpiphp_debug;
> > extern bool acpiphp_disabled;
> >
> > #endif /* _ACPIPHP_H */
> > --
> > 1.8.4.3
> >
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-19 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-19 14:15 [PATCH] PCI / hotplug / ACPI: Drop unused acpiphp_debug declaration Mika Westerberg
2013-11-19 17:23 ` Bjorn Helgaas
2013-11-19 20:52 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).