* [PATCH] pci: Fix pcie access for PCI_EXP_FLAGS
@ 2013-02-14 18:35 Alex Williamson
2013-02-15 18:53 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Alex Williamson @ 2013-02-14 18:35 UTC (permalink / raw)
To: bhelgaas, linux-pci; +Cc: linux-kernel, jiang.liu
PCI_EXP_FLAGS_TYPE is a mask, not an offset. Fix it.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
drivers/pci/access.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/access.c b/drivers/pci/access.c
index 3af0478..32046c5 100644
--- a/drivers/pci/access.c
+++ b/drivers/pci/access.c
@@ -515,7 +515,7 @@ static bool pcie_capability_reg_implemented(struct pci_dev *dev, int pos)
return false;
switch (pos) {
- case PCI_EXP_FLAGS_TYPE:
+ case PCI_EXP_FLAGS:
return true;
case PCI_EXP_DEVCAP:
case PCI_EXP_DEVCTL:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: Fix pcie access for PCI_EXP_FLAGS
2013-02-14 18:35 [PATCH] pci: Fix pcie access for PCI_EXP_FLAGS Alex Williamson
@ 2013-02-15 18:53 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2013-02-15 18:53 UTC (permalink / raw)
To: Alex Williamson; +Cc: linux-pci, linux-kernel, jiang.liu
On Thu, Feb 14, 2013 at 11:35 AM, Alex Williamson
<alex.williamson@redhat.com> wrote:
> PCI_EXP_FLAGS_TYPE is a mask, not an offset. Fix it.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
I applied this to pci/misc so it will appear in v3.9 and marked it for
stable for v3.7+.
Thanks!
> ---
> drivers/pci/access.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/access.c b/drivers/pci/access.c
> index 3af0478..32046c5 100644
> --- a/drivers/pci/access.c
> +++ b/drivers/pci/access.c
> @@ -515,7 +515,7 @@ static bool pcie_capability_reg_implemented(struct pci_dev *dev, int pos)
> return false;
>
> switch (pos) {
> - case PCI_EXP_FLAGS_TYPE:
> + case PCI_EXP_FLAGS:
> return true;
> case PCI_EXP_DEVCAP:
> case PCI_EXP_DEVCTL:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-15 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-14 18:35 [PATCH] pci: Fix pcie access for PCI_EXP_FLAGS Alex Williamson
2013-02-15 18:53 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).