From: Ahbong Chang <cwahbong@google.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Todd Poynor <toddpoynor@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>
Subject: Re: [PATCH] trace: add missing forward declaration
Date: Tue, 17 Apr 2018 02:18:47 +0000 [thread overview]
Message-ID: <CAEvWiR--DLM2Tp8-OaZSh4LV9o8x2K47c9=-+VZFoDhedy=nZQ@mail.gmail.com> (raw)
In-Reply-To: <20180416092444.05ec6434@gandalf.local.home>
It does not fail with any config without this fix. This is for new work.
-- Ahbong
On Mon, Apr 16, 2018 at 9:24 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 16 Apr 2018 10:36:25 +0800
> Ahbong Chang <cwahbong@google.com> wrote:
> > Without this forward declaration compile may fail if this header is
> > included only for registering other probe event without struct
> > pool_workqueue.
> >
> Is this for new work or is there a config which this fails with today?
> -- Steve
> > Signed-off-by: Ahbong Chang <cwahbong@google.com>
> > Reviewed-by: Todd Poynor <toddpoynor@google.com>
> > ---
> > include/trace/events/workqueue.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/trace/events/workqueue.h
b/include/trace/events/workqueue.h
> > index 2f057a494d93..9a761bc6a251 100644
> > --- a/include/trace/events/workqueue.h
> > +++ b/include/trace/events/workqueue.h
> > @@ -25,6 +25,8 @@ DECLARE_EVENT_CLASS(workqueue_work,
> > TP_printk("work struct %p", __entry->work)
> > );
> >
> > +struct pool_workqueue;
> > +
> > /**
> > * workqueue_queue_work - called when a work gets queued
> > * @req_cpu: the requested cpu
next prev parent reply other threads:[~2018-04-17 2:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 2:36 [PATCH] trace: add missing forward declaration Ahbong Chang
2018-04-16 13:24 ` Steven Rostedt
2018-04-17 2:18 ` Ahbong Chang [this message]
2018-04-17 10:29 ` Greg Kroah-Hartman
2018-04-17 11:10 ` Ahbong Chang
2018-04-18 14:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEvWiR--DLM2Tp8-OaZSh4LV9o8x2K47c9=-+VZFoDhedy=nZQ@mail.gmail.com' \
--to=cwahbong@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pombredanne@nexb.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).