[PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

[PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

[Douglas Anderson]

If the rate in our table is _equal_ to the rate we want then it's OK
to pick it.  It doesn't need to be greater than the one we want.

Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
index 6ad688b320ae..be000b0ca56b 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
@@ -475,7 +475,7 @@ static int ti_sn_bridge_calc_min_dp_rate_idx(struct ti_sn_bridge *pdata)
 				   1000 * pdata->dp_lanes * DP_CLK_FUDGE_DEN);
 
 	for (i = 1; i < ARRAY_SIZE(ti_sn_bridge_dp_rate_lut) - 1; i++)
-		if (ti_sn_bridge_dp_rate_lut[i] > dp_rate_mhz)
+		if (ti_sn_bridge_dp_rate_lut[i] >= dp_rate_mhz)
 			break;
 
 	return i;
-- 
2.26.2.526.g744177e7f7-goog

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

[Stephen Boyd]

Quoting Douglas Anderson (2020-05-04 21:32:29)
> If the rate in our table is _equal_ to the rate we want then it's OK
> to pick it.  It doesn't need to be greater than the one we want.
> 
> Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

[Rob Clark]

On Mon, May 4, 2020 at 9:32 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> If the rate in our table is _equal_ to the rate we want then it's OK
> to pick it.  It doesn't need to be greater than the one we want.
>
> Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
>
>  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 6ad688b320ae..be000b0ca56b 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -475,7 +475,7 @@ static int ti_sn_bridge_calc_min_dp_rate_idx(struct ti_sn_bridge *pdata)
>                                    1000 * pdata->dp_lanes * DP_CLK_FUDGE_DEN);
>
>         for (i = 1; i < ARRAY_SIZE(ti_sn_bridge_dp_rate_lut) - 1; i++)
> -               if (ti_sn_bridge_dp_rate_lut[i] > dp_rate_mhz)
> +               if (ti_sn_bridge_dp_rate_lut[i] >= dp_rate_mhz)
>                         break;
>
>         return i;
> --
> 2.26.2.526.g744177e7f7-goog
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

[Doug Anderson]

Sam,

On Fri, May 15, 2020 at 2:49 PM Rob Clark <robdclark@gmail.com> wrote:
>
> On Mon, May 4, 2020 at 9:32 PM Douglas Anderson <dianders@chromium.org> wrote:
> >
> > If the rate in our table is _equal_ to the rate we want then it's OK
> > to pick it.  It doesn't need to be greater than the one we want.
> >
> > Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> Reviewed-by: Rob Clark <robdclark@gmail.com>

...and I think this is the last of the patches I stupidly didn't CC
you on that's ready to go.

-Doug

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix off-by-one error in clock choice

[Sam Ravnborg]

Hi Douglas.

On Mon, May 18, 2020 at 11:23:44AM -0700, Doug Anderson wrote:
> Sam,
> 
> On Fri, May 15, 2020 at 2:49 PM Rob Clark <robdclark@gmail.com> wrote:
> >
> > On Mon, May 4, 2020 at 9:32 PM Douglas Anderson <dianders@chromium.org> wrote:
> > >
> > > If the rate in our table is _equal_ to the rate we want then it's OK
> > > to pick it.  It doesn't need to be greater than the one we want.
> > >
> > > Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
> > > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> >
> > Reviewed-by: Rob Clark <robdclark@gmail.com>
> 
> ...and I think this is the last of the patches I stupidly didn't CC
> you on that's ready to go.

I'm not a bridge maintainer so mostly I am just overstepping
what I in reality have authority to do.
But so far no loud complains...

	Sam