* [PATCH] drm/ci: Default to UART for logging
@ 2023-10-06 17:32 Rob Clark
2023-10-09 11:19 ` Helen Koike
2023-10-13 16:28 ` Daniel Stone
0 siblings, 2 replies; 4+ messages in thread
From: Rob Clark @ 2023-10-06 17:32 UTC (permalink / raw)
To: dri-devel
Cc: Emma Anholt, Helen Koike, Rob Clark, David Airlie, Daniel Vetter,
open list
From: Rob Clark <robdclark@chromium.org>
ssh logging is the default for mesa, as it is generally more reliable.
But if there are kernel issues, especially at boot, UART logging is
infinitely more useful.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/ci/gitlab-ci.yml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
index 2c4df53f5dfe..7c55f02f7313 100644
--- a/drivers/gpu/drm/ci/gitlab-ci.yml
+++ b/drivers/gpu/drm/ci/gitlab-ci.yml
@@ -27,6 +27,12 @@ variables:
LAVA_JOB_PRIORITY: 30
+ # Default to UART logging. Mesa uses ssh by default, as that is more
+ # reliable if you have a stable kernel. But kernel CI is more likely
+ # to encounter unstable kernels (and has lower volume of CI jobs so is
+ # less likely to be troubled by occasional UART flakes)
+ LAVA_FORCE_UART: 1
+
default:
before_script:
- export SCRIPTS_DIR=$(mktemp -d)
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/ci: Default to UART for logging
2023-10-06 17:32 [PATCH] drm/ci: Default to UART for logging Rob Clark
@ 2023-10-09 11:19 ` Helen Koike
2023-10-13 16:28 ` Daniel Stone
1 sibling, 0 replies; 4+ messages in thread
From: Helen Koike @ 2023-10-09 11:19 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: Emma Anholt, Rob Clark, David Airlie, Daniel Vetter, open list,
Guilherme Alcarde Gallo
cc +guilherme
On 06/10/2023 14:32, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> ssh logging is the default for mesa, as it is generally more reliable.
> But if there are kernel issues, especially at boot, UART logging is
> infinitely more useful.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/ci/gitlab-ci.yml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
> index 2c4df53f5dfe..7c55f02f7313 100644
> --- a/drivers/gpu/drm/ci/gitlab-ci.yml
> +++ b/drivers/gpu/drm/ci/gitlab-ci.yml
> @@ -27,6 +27,12 @@ variables:
>
> LAVA_JOB_PRIORITY: 30
>
> + # Default to UART logging. Mesa uses ssh by default, as that is more
> + # reliable if you have a stable kernel. But kernel CI is more likely
> + # to encounter unstable kernels (and has lower volume of CI jobs so is
> + # less likely to be troubled by occasional UART flakes)
> + LAVA_FORCE_UART: 1
> +
> default:
> before_script:
> - export SCRIPTS_DIR=$(mktemp -d)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/ci: Default to UART for logging
2023-10-06 17:32 [PATCH] drm/ci: Default to UART for logging Rob Clark
2023-10-09 11:19 ` Helen Koike
@ 2023-10-13 16:28 ` Daniel Stone
2023-10-13 18:14 ` Rob Clark
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Stone @ 2023-10-13 16:28 UTC (permalink / raw)
To: Rob Clark; +Cc: dri-devel, Rob Clark, Emma Anholt, open list, Helen Koike
On Fri, 6 Oct 2023 at 18:32, Rob Clark <robdclark@gmail.com> wrote:
> ssh logging is the default for mesa, as it is generally more reliable.
> But if there are kernel issues, especially at boot, UART logging is
> infinitely more useful.
Hmm, we should still be capturing the UART boot logs regardless. Those
go into a collapsed 'LAVA boot' section but they don't just disappear
... ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/ci: Default to UART for logging
2023-10-13 16:28 ` Daniel Stone
@ 2023-10-13 18:14 ` Rob Clark
0 siblings, 0 replies; 4+ messages in thread
From: Rob Clark @ 2023-10-13 18:14 UTC (permalink / raw)
To: Daniel Stone; +Cc: dri-devel, Rob Clark, Emma Anholt, open list, Helen Koike
On Fri, Oct 13, 2023 at 9:28 AM Daniel Stone <daniel@fooishbar.org> wrote:
>
> On Fri, 6 Oct 2023 at 18:32, Rob Clark <robdclark@gmail.com> wrote:
> > ssh logging is the default for mesa, as it is generally more reliable.
> > But if there are kernel issues, especially at boot, UART logging is
> > infinitely more useful.
>
> Hmm, we should still be capturing the UART boot logs regardless. Those
> go into a collapsed 'LAVA boot' section but they don't just disappear
> ... ?
Hmm, I wasn't seeing anything in the raw log, which doesn't collapse sections..
That said, I still think uart is preferable to ssh for kernel CI.. we
aren't running jobs at the scale of mesa CI jobs so even if we get
UART flakes 1/1000 (or even 1/100) times, that is an acceptable
trade-off for the fact that uart can still work when things are too
fubar for ssh.
BR,
-R
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-13 18:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-06 17:32 [PATCH] drm/ci: Default to UART for logging Rob Clark
2023-10-09 11:19 ` Helen Koike
2023-10-13 16:28 ` Daniel Stone
2023-10-13 18:14 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).