* [PATCH] drm: msm: Fix add_gpu_components
@ 2019-06-26 18:00 Jeffrey Hugo
2019-06-26 22:15 ` Rob Clark
0 siblings, 1 reply; 2+ messages in thread
From: Jeffrey Hugo @ 2019-06-26 18:00 UTC (permalink / raw)
To: robdclark, sean, airlied, daniel
Cc: bjorn.andersson, linux-arm-msm, dri-devel, freedreno,
linux-kernel, Jeffrey Hugo
add_gpu_components() adds found GPU nodes from the DT to the match list,
regardless of the status of the nodes. This is a problem, because if the
nodes are disabled, they should not be on the match list because they will
not be matched. This prevents display from initing if a GPU node is
defined, but it's status is disabled.
Fix this by checking the node's status before adding it to the match list.
Fixes: dc3ea265b856 ("drm/msm: Drop the gpu binding")
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
---
drivers/gpu/drm/msm/msm_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index ab64ab470de7..4aeb84f1d874 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -1279,7 +1279,8 @@ static int add_gpu_components(struct device *dev,
if (!np)
return 0;
- drm_of_component_match_add(dev, matchptr, compare_of, np);
+ if (of_device_is_available(np))
+ drm_of_component_match_add(dev, matchptr, compare_of, np);
of_node_put(np);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: msm: Fix add_gpu_components
2019-06-26 18:00 [PATCH] drm: msm: Fix add_gpu_components Jeffrey Hugo
@ 2019-06-26 22:15 ` Rob Clark
0 siblings, 0 replies; 2+ messages in thread
From: Rob Clark @ 2019-06-26 22:15 UTC (permalink / raw)
To: Jeffrey Hugo
Cc: Sean Paul, David Airlie, Daniel Vetter, Bjorn Andersson,
linux-arm-msm, dri-devel, freedreno, Linux Kernel Mailing List
On Wed, Jun 26, 2019 at 11:00 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote:
>
> add_gpu_components() adds found GPU nodes from the DT to the match list,
> regardless of the status of the nodes. This is a problem, because if the
> nodes are disabled, they should not be on the match list because they will
> not be matched. This prevents display from initing if a GPU node is
> defined, but it's status is disabled.
>
> Fix this by checking the node's status before adding it to the match list.
hmm, I guess a case I had certainly never tested ;-)
I wonder if it really makes sense for gpu to ever be disabled (since
it isn't depending on external non-SoC-specific wiring up of things..
but I guess that might still be useful for bring-up.. either way,
Reviewed-by: Rob Clark <robdclark@gmail.com>
Sean, want to pick this up in drm-misc-fixes?
BR,
-R
>
> Fixes: dc3ea265b856 ("drm/msm: Drop the gpu binding")
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> ---
> drivers/gpu/drm/msm/msm_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index ab64ab470de7..4aeb84f1d874 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -1279,7 +1279,8 @@ static int add_gpu_components(struct device *dev,
> if (!np)
> return 0;
>
> - drm_of_component_match_add(dev, matchptr, compare_of, np);
> + if (of_device_is_available(np))
> + drm_of_component_match_add(dev, matchptr, compare_of, np);
>
> of_node_put(np);
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-26 22:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-26 18:00 [PATCH] drm: msm: Fix add_gpu_components Jeffrey Hugo
2019-06-26 22:15 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).