From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: khilman@baylibre.com
Cc: sudeep.holla@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
tglx@linutronix.de
Subject: Re: [PATCH 1/2] Revert "tick: Prefer a lower rating device only if it's CPU local device"
Date: Mon, 9 Jul 2018 23:46:20 +0200 [thread overview]
Message-ID: <CAFBinCA6gZ9fw0yGvs_FWuGoZG-d2CL2R5qYp3_u1T=Atn8tgA@mail.gmail.com> (raw)
In-Reply-To: <CAOi56cWaeh+c9+OgpxdjTarnRdaKrNFC=ddBPT2j9v1rHT8EOg@mail.gmail.com>
On Mon, Jul 9, 2018 at 8:24 PM Kevin Hilman <khilman@baylibre.com> wrote:
>
> On Mon, Jul 9, 2018 at 8:45 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > This reverts commit 1332a90558013ae4242e3dd7934bdcdeafb06c0d.
> >
> > The original issue was not because of incorrect checking of cpumask for
> > both new and old tick device. It was incorrectly analysed was due to the
> > misunderstanding of the comment and misinterpretation of the return
> > value from tick_check_preferred. The main issue is with the clockevent
> > driver that sets the cpumask to cpu_all_mask instead of cpu_possible_mask.
> >
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> And verified to fix a regression on the 32-bit ARM platform mesion8b-odroidc1.
I also tested it on Meson8b as well as Meson8m2
Regards
Martin
next prev parent reply other threads:[~2018-07-09 21:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:45 [PATCH 1/2] Revert "tick: Prefer a lower rating device only if it's CPU local device" Sudeep Holla
2018-07-09 15:45 ` [PATCH 2/2] clocksource: arm_arch_timer: set arch_mem_timer cpumask to cpu_possible_mask Sudeep Holla
2018-07-09 22:09 ` Thomas Gleixner
2018-07-10 10:29 ` Sudeep Holla
2018-07-10 12:21 ` Thomas Gleixner
2018-07-10 13:25 ` Sudeep Holla
2018-07-10 20:21 ` Thomas Gleixner
2018-07-10 20:16 ` [tip:timers/urgent] clocksource: arm_arch_timer: Set " tip-bot for Sudeep Holla
2018-07-09 18:24 ` [PATCH 1/2] Revert "tick: Prefer a lower rating device only if it's CPU local device" Kevin Hilman
2018-07-09 21:46 ` Martin Blumenstingl [this message]
2018-07-10 20:15 ` [tip:timers/urgent] " tip-bot for Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCA6gZ9fw0yGvs_FWuGoZG-d2CL2R5qYp3_u1T=Atn8tgA@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).