linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tip-bot for Sudeep Holla <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: marc.zyngier@arm.com, mingo@kernel.org, sudeep.holla@arm.com,
	martin.blumenstingl@googlemail.com, linux-kernel@vger.kernel.org,
	khilman@baylibre.com, tglx@linutronix.de, hpa@zytor.com
Subject: [tip:timers/urgent] Revert "tick: Prefer a lower rating device only if it's CPU local device"
Date: Tue, 10 Jul 2018 13:15:56 -0700	[thread overview]
Message-ID: <tip-5b5ccbc2b041f98f26b984e013d303b7f9e6fb8e@git.kernel.org> (raw)
In-Reply-To: <1531151136-18297-1-git-send-email-sudeep.holla@arm.com>

Commit-ID:  5b5ccbc2b041f98f26b984e013d303b7f9e6fb8e
Gitweb:     https://git.kernel.org/tip/5b5ccbc2b041f98f26b984e013d303b7f9e6fb8e
Author:     Sudeep Holla <sudeep.holla@arm.com>
AuthorDate: Mon, 9 Jul 2018 16:45:35 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 10 Jul 2018 22:12:47 +0200

Revert "tick: Prefer a lower rating device only if it's CPU local device"

This reverts commit 1332a90558013ae4242e3dd7934bdcdeafb06c0d.

The original issue was not because of incorrect checking of cpumask for
both new and old tick device. It was incorrectly analysed was due to the
misunderstanding of the comment and misinterpretation of the return value
from tick_check_preferred. The main issue is with the clockevent driver
that sets the cpumask to cpu_all_mask instead of cpu_possible_mask.

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/1531151136-18297-1-git-send-email-sudeep.holla@arm.com

---
 kernel/time/tick-common.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index b7005dd21ec1..14de3727b18e 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -277,8 +277,7 @@ static bool tick_check_preferred(struct clock_event_device *curdev,
 	 */
 	return !curdev ||
 		newdev->rating > curdev->rating ||
-	       (!cpumask_equal(curdev->cpumask, newdev->cpumask) &&
-	        !tick_check_percpu(curdev, newdev, smp_processor_id()));
+	       !cpumask_equal(curdev->cpumask, newdev->cpumask);
 }
 
 /*

      parent reply	other threads:[~2018-07-10 20:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 15:45 [PATCH 1/2] Revert "tick: Prefer a lower rating device only if it's CPU local device" Sudeep Holla
2018-07-09 15:45 ` [PATCH 2/2] clocksource: arm_arch_timer: set arch_mem_timer cpumask to cpu_possible_mask Sudeep Holla
2018-07-09 22:09   ` Thomas Gleixner
2018-07-10 10:29     ` Sudeep Holla
2018-07-10 12:21       ` Thomas Gleixner
2018-07-10 13:25         ` Sudeep Holla
2018-07-10 20:21           ` Thomas Gleixner
2018-07-10 20:16   ` [tip:timers/urgent] clocksource: arm_arch_timer: Set " tip-bot for Sudeep Holla
2018-07-09 18:24 ` [PATCH 1/2] Revert "tick: Prefer a lower rating device only if it's CPU local device" Kevin Hilman
2018-07-09 21:46   ` Martin Blumenstingl
2018-07-10 20:15 ` tip-bot for Sudeep Holla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-5b5ccbc2b041f98f26b984e013d303b7f9e6fb8e@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=hpa@zytor.com \
    --cc=khilman@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mingo@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).