* [PATCH 1/2] mmc: meson-mx-sdhc: Fix error check for dma_map_sg
[not found] <20220825074008.33349-1-jinpu.wang@ionos.com>
@ 2022-08-25 7:40 ` Jack Wang
2022-08-27 20:40 ` Martin Blumenstingl
2022-08-25 7:40 ` [PATCH 2/2] mmc: jz4740_mmc: " Jack Wang
1 sibling, 1 reply; 4+ messages in thread
From: Jack Wang @ 2022-08-25 7:40 UTC (permalink / raw)
To: ulf.hansson, linux-mmc
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-arm-kernel, linux-amlogic, linux-kernel
dma_map_sg return 0 on error, also change the type for dma_len
from int to unsigned int.
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-mmc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-amlogic@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/mmc/host/meson-mx-sdhc-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/meson-mx-sdhc-mmc.c b/drivers/mmc/host/meson-mx-sdhc-mmc.c
index e92e63cb5641..da85c2f2acb8 100644
--- a/drivers/mmc/host/meson-mx-sdhc-mmc.c
+++ b/drivers/mmc/host/meson-mx-sdhc-mmc.c
@@ -381,14 +381,14 @@ static void meson_mx_sdhc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
static int meson_mx_sdhc_map_dma(struct mmc_host *mmc, struct mmc_request *mrq)
{
struct mmc_data *data = mrq->data;
- int dma_len;
+ unsigned int dma_len;
if (!data)
return 0;
dma_len = dma_map_sg(mmc_dev(mmc), data->sg, data->sg_len,
mmc_get_dma_dir(data));
- if (dma_len <= 0) {
+ if (!dma_len) {
dev_err(mmc_dev(mmc), "dma_map_sg failed\n");
return -ENOMEM;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] mmc: jz4740_mmc: Fix error check for dma_map_sg
[not found] <20220825074008.33349-1-jinpu.wang@ionos.com>
2022-08-25 7:40 ` [PATCH 1/2] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
@ 2022-08-25 7:40 ` Jack Wang
2022-08-25 22:38 ` Paul Cercueil
1 sibling, 1 reply; 4+ messages in thread
From: Jack Wang @ 2022-08-25 7:40 UTC (permalink / raw)
To: ulf.hansson, linux-mmc; +Cc: Paul Cercueil, linux-mips, linux-kernel
dma_map_sg return 0 on error.
Cc: Paul Cercueil <paul@crapouillou.net>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/mmc/host/jz4740_mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c
index b1d563b2ed1b..dc2db9c185ea 100644
--- a/drivers/mmc/host/jz4740_mmc.c
+++ b/drivers/mmc/host/jz4740_mmc.c
@@ -298,7 +298,7 @@ static int jz4740_mmc_prepare_dma_data(struct jz4740_mmc_host *host,
{
struct dma_chan *chan = jz4740_mmc_get_dma_chan(host, data);
enum dma_data_direction dir = mmc_get_dma_dir(data);
- int sg_count;
+ unsigned int sg_count;
if (data->host_cookie == COOKIE_PREMAPPED)
return data->sg_count;
@@ -308,7 +308,7 @@ static int jz4740_mmc_prepare_dma_data(struct jz4740_mmc_host *host,
data->sg_len,
dir);
- if (sg_count <= 0) {
+ if (!sg_count) {
dev_err(mmc_dev(host->mmc),
"Failed to map scatterlist for DMA operation\n");
return -EINVAL;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] mmc: jz4740_mmc: Fix error check for dma_map_sg
2022-08-25 7:40 ` [PATCH 2/2] mmc: jz4740_mmc: " Jack Wang
@ 2022-08-25 22:38 ` Paul Cercueil
0 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2022-08-25 22:38 UTC (permalink / raw)
To: Jack Wang; +Cc: ulf.hansson, linux-mmc, linux-mips, linux-kernel
Hi Jack,
Le jeu., août 25 2022 at 09:40:08 +0200, Jack Wang
<jinpu.wang@ionos.com> a écrit :
> dma_map_sg return 0 on error.
>
> Cc: Paul Cercueil <paul@crapouillou.net>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: linux-mips@vger.kernel.org
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> drivers/mmc/host/jz4740_mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/jz4740_mmc.c
> b/drivers/mmc/host/jz4740_mmc.c
> index b1d563b2ed1b..dc2db9c185ea 100644
> --- a/drivers/mmc/host/jz4740_mmc.c
> +++ b/drivers/mmc/host/jz4740_mmc.c
> @@ -298,7 +298,7 @@ static int jz4740_mmc_prepare_dma_data(struct
> jz4740_mmc_host *host,
> {
> struct dma_chan *chan = jz4740_mmc_get_dma_chan(host, data);
> enum dma_data_direction dir = mmc_get_dma_dir(data);
> - int sg_count;
> + unsigned int sg_count;
>
> if (data->host_cookie == COOKIE_PREMAPPED)
> return data->sg_count;
> @@ -308,7 +308,7 @@ static int jz4740_mmc_prepare_dma_data(struct
> jz4740_mmc_host *host,
> data->sg_len,
> dir);
>
> - if (sg_count <= 0) {
> + if (!sg_count) {
> dev_err(mmc_dev(host->mmc),
> "Failed to map scatterlist for DMA operation\n");
> return -EINVAL;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] mmc: meson-mx-sdhc: Fix error check for dma_map_sg
2022-08-25 7:40 ` [PATCH 1/2] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
@ 2022-08-27 20:40 ` Martin Blumenstingl
0 siblings, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2022-08-27 20:40 UTC (permalink / raw)
To: Jack Wang
Cc: ulf.hansson, linux-mmc, Neil Armstrong, Kevin Hilman,
Jerome Brunet, linux-arm-kernel, linux-amlogic, linux-kernel
On Thu, Aug 25, 2022 at 9:40 AM Jack Wang <jinpu.wang@ionos.com> wrote:
>
> dma_map_sg return 0 on error, also change the type for dma_len
> from int to unsigned int.
>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: linux-mmc@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-amlogic@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
>
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Thank you for this patch! It's:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Best regards,
Martin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-27 20:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220825074008.33349-1-jinpu.wang@ionos.com>
2022-08-25 7:40 ` [PATCH 1/2] mmc: meson-mx-sdhc: Fix error check for dma_map_sg Jack Wang
2022-08-27 20:40 ` Martin Blumenstingl
2022-08-25 7:40 ` [PATCH 2/2] mmc: jz4740_mmc: " Jack Wang
2022-08-25 22:38 ` Paul Cercueil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).